New issue
Advanced search Search tips

Issue 708605 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocked on:
issue 807623

Blocking:
issue 770175



Sign in to add a comment

username and password are not autofilled for capitalone360.com

Project Member Reported by linds...@chromium.org, Apr 5 2017

Issue description

App Version:59.0.3054.0
iOS Version: iOs10.3.1
Device: iPhone7
URL: capitalone360.com

Steps to reproduce:
  1. On desktop (signed in for sync) go to capitalone360.com and login, opt to save the u/p
  2. On ios, open Chrome (signed in for sync), go to capitalone360.com
  3. Tap on Sign in, note that the fields are not pre-populated as expected
  4. Tap on the username field to put cursor there

Observed results:
Username shows in the keyboard toolbar as an option to select for autofill, but if you tap it nothing happens.

Expected results:
Username and password are never filled in.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install:Yes
Bug reproducible after clearing cache and cookies:Yes
Observed behavior in Chrome Mobile on Android: n/a
Check for similar behavior on Firefox/Safari: n/a
Bug reproducible on current stable build (App Version, iOS Version): Yes M57
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes M58

Video: will attach once uploading finishes.
 
Labels: Hotlist-UP

Comment 3 by sczs@chromium.org, Apr 5 2017

Cc: melandory@chromium.org
Labels: M-59
Owner: vabr@chromium.org
Status: Assigned (was: Untriaged)
Hi vabr@ , melandory@ could you please take a look.

Comment 4 by vabr@chromium.org, Apr 6 2017

Labels: Hotlist-Polish
Owner: ----
Status: Available (was: Assigned)
As explained to lindsayw@ in an e-mail, I am moving these bugs to our TODO list, and reducing some unnecessary noise they cause.

Comment 5 by vabr@chromium.org, Apr 16 2017

Blockedon: 710374
Cc: -melandory@chromium.org
Labels: -Pri-2 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows OS-All Pri-3
This is interesting also on other platforms.

What happens currently (version 57) on desktop:
* Chrome's renderer parses the page and notices the login forms.
* The renderer asks the browser process to retrieve the saved logins and send them back.
* The browser finds the saved logins and sends them back.
* The renderer process is unable to find the forms to fill.

This is getting fixed in steps:
* Since Chrome 58, a suggestion in the password field to fill the saved password will be available.
* Filling of the username is tracked by  issue 710374 .

While the first partial fix (filling the username) should get fixed for iOS once we start sharing more code with other platforms, I am not marking this bug with Hotlist-WorksOnDesktop yet, because of the second part.
Labels: -Pri-3 Pri-1
Cc: linds...@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b7f62478df1974a2742137afe572f3621464af

commit 97b7f62478df1974a2742137afe572f3621464af
Author: pkalinnikov <pkalinnikov@chromium.org>
Date: Mon May 29 10:13:04 2017

Autofill username when the user interacts with the password field.

Previously, when the user clicked on a password field, only this field
was autocompleted with their password. This CL ensures that the username
field is autocompleted as well.

If the user interacts with a password field then the username is filled
only if it was empty or *autofilled*, i.e. the user-supplied data is
never overridden.

Note that this works only if the username field was found.

BUG= 710374 , 708605 , 708602 

Review-Url: https://codereview.chromium.org/2902113004
Cr-Commit-Position: refs/heads/master@{#475329}

[modify] https://crrev.com/97b7f62478df1974a2742137afe572f3621464af/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/97b7f62478df1974a2742137afe572f3621464af/components/autofill/content/renderer/password_autofill_agent.cc

After https://codereview.chromium.org/2902113004 the username field gets autofilled together with the password field when the user interacts with the latter.

Although, I don't think this changes the iOS story.
Blockedon: -710374
Project Member

Comment 11 by bugdroid1@chromium.org, May 31 2017

Labels: merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27a63fbaf769d23df0973c9d01ee9763ce3ca862

commit 27a63fbaf769d23df0973c9d01ee9763ce3ca862
Author: Pavel Kalinnikov <pkalinnikov@chromium.org>
Date: Wed May 31 13:46:16 2017

Autofill username when the user interacts with the password field.

Previously, when the user clicked on a password field, only this field
was autocompleted with their password. This CL ensures that the username
field is autocompleted as well.

If the user interacts with a password field then the username is filled
only if it was empty or *autofilled*, i.e. the user-supplied data is
never overridden.

Note that this works only if the username field was found.

BUG= 710374 , 708605 , 708602 

Review-Url: https://codereview.chromium.org/2902113004
Cr-Original-Commit-Position: refs/heads/master@{#475329}
Review-Url: https://codereview.chromium.org/2910403003 .
Cr-Commit-Position: refs/branch-heads/3112@{#51}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/27a63fbaf769d23df0973c9d01ee9763ce3ca862/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/27a63fbaf769d23df0973c9d01ee9763ce3ca862/components/autofill/content/renderer/password_autofill_agent.cc

Labels: TE-NeedsTriageFromMTV
Labels: -TE-NeedsTriageFromMTV
Requesting Bling team to verify the fix, we do not have the device to proceed.
Username and password are still not filled in for me. It suggests a saved value for capitalone360 but the fields are not populated if I tap the suggestion. The suggestion is only shown in soft keyboard toolbar when the cursor is placed in username field, nothing is suggested when cursor is in password field.

Please see video (and either ignore the audio or turn audio off :):
https://drive.google.com/file/d/0By4O1f2IQqQ_RHZtYmRFblRJQ0k/view 
Owner: dvadym@chromium.org
Status: Assigned (was: Available)

Comment 16 by kolos@chromium.org, Jan 26 2018

Blocking: 770175

Comment 17 by kolos@chromium.org, Jan 26 2018

Labels: -OS-Linux -OS-Android -OS-Windows -OS-All -OS-Chrome -OS-Mac
On Desktop it works fine. This is probably iOS-only issue. 
Blockedon: 807623
The problem is that there is an invisible password field before username and Password Manager tries to fill it.
It should be fixed after with rewriting of form parsing on  bug 807623 
Status: Fixed (was: Assigned)

Sign in to add a comment