username and password does not autofill for jcpenney.com |
||||||||||||
Issue descriptionApp Version:59.0.3054.0 iOS Version: iOs10.3.1 Device: iPhone7 URL: jcpenney.com Steps to reproduce: 1. On desktop (signed in for sync) go to jcpenney.com and login, opt to save the u/p 2. On ios, open Chrome (signed in for sync), go to jcpenney.com 3. Tap Account Observed results: Username and password should be filled in Expected results: Username and password are never filled in. Note: on desktop, the password at least gets filled in, but not the username. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install:Yes Bug reproducible after clearing cache and cookies:Yes Observed behavior in Chrome Mobile on Android: n/a Check for similar behavior on Firefox/Safari: n/a Bug reproducible on current stable build (App Version, iOS Version): Yes M57 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes M58
,
Apr 5 2017
Hi vabr@ , melandory@ could you please take a look.
,
Apr 6 2017
As explained to lindsayw@ in an e-mail, I am moving these bugs to our TODO list, and reducing some unnecessary noise they cause.
,
Apr 16 2017
This is hard to debug currently, because all I get when loading jcpenney.com is: """ Access Denied You don't have permission to access "http://www.jcpenney.com/" on this server. """ Judging from the description, this might be one of the issues tracked by bug 710374 .
,
May 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97b7f62478df1974a2742137afe572f3621464af commit 97b7f62478df1974a2742137afe572f3621464af Author: pkalinnikov <pkalinnikov@chromium.org> Date: Mon May 29 10:13:04 2017 Autofill username when the user interacts with the password field. Previously, when the user clicked on a password field, only this field was autocompleted with their password. This CL ensures that the username field is autocompleted as well. If the user interacts with a password field then the username is filled only if it was empty or *autofilled*, i.e. the user-supplied data is never overridden. Note that this works only if the username field was found. BUG= 710374 , 708605 , 708602 Review-Url: https://codereview.chromium.org/2902113004 Cr-Commit-Position: refs/heads/master@{#475329} [modify] https://crrev.com/97b7f62478df1974a2742137afe572f3621464af/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/97b7f62478df1974a2742137afe572f3621464af/components/autofill/content/renderer/password_autofill_agent.cc
,
May 30 2017
After https://codereview.chromium.org/2902113004 the username field gets autofilled together with the password field when the user interacts with the latter on jcpenney.com. Although, I don't think this changes the iOS story. Lindsay, can you please check how it works now?
,
May 30 2017
Is this bug different from crbug.com/708605 ? (by other than the visited site)
,
May 30 2017
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27a63fbaf769d23df0973c9d01ee9763ce3ca862 commit 27a63fbaf769d23df0973c9d01ee9763ce3ca862 Author: Pavel Kalinnikov <pkalinnikov@chromium.org> Date: Wed May 31 13:46:16 2017 Autofill username when the user interacts with the password field. Previously, when the user clicked on a password field, only this field was autocompleted with their password. This CL ensures that the username field is autocompleted as well. If the user interacts with a password field then the username is filled only if it was empty or *autofilled*, i.e. the user-supplied data is never overridden. Note that this works only if the username field was found. BUG= 710374 , 708605 , 708602 Review-Url: https://codereview.chromium.org/2902113004 Cr-Original-Commit-Position: refs/heads/master@{#475329} Review-Url: https://codereview.chromium.org/2910403003 . Cr-Commit-Position: refs/branch-heads/3112@{#51} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/27a63fbaf769d23df0973c9d01ee9763ce3ca862/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/27a63fbaf769d23df0973c9d01ee9763ce3ca862/components/autofill/content/renderer/password_autofill_agent.cc
,
May 31 2017
Answering comment #7 - we have filed bugs separately for every site we encounter username/passwords not autofilling when expected. Because sites are implemented differently, and so the heuristics used for password autofill could follow a different path from site to site, it's hard to say if the only difference between these 2 bugs is that the one is capitalone360 and the other is jcpenney. A detailed analysis of both sites and why password autofill isn't properly triggered would be needed to answer that definitively... sorry I don't have a better answer for you. As for testing request in Comment #6 I'll try today. Also, if you are working on this CL can you please put yourself as owner and the status as started so that no one else picks this up while you are working on it?
,
Jun 1 2017
Tested this issue on Mac 10.12.4 with chrome #61.0.3112.10 and Android Device with chrome #61.0.3113.0 . These are the steps followed. 1. On Mac, logged into chrome browser then navigated to jcpenny.com and saved the credentials 2. On the android device, logged with same account then navigated to jcpenny.com 3. While signing in, on clicking on the username filed, it has displayed the autofill option for username and after selecting username password is autofilled. Device Details: Device: Nexus 10 Tab, Build : LRX22C Android version : 5.0.1 Anyone from dev team, would confirm that this is the expected behavior of this issue.
,
Jun 1 2017
#11: Am I getting you right that the username was NOT autofilled (only password), even though you tapped the username field? Can you also check what happens when you tap the password field?
,
Jun 2 2017
Username and password are still not filled in for me. It seems it suggests a saved value for jcpenney but the fields are not populated if I tap the suggestion. The suggestion is only shown in soft keyboard toolbar when the cursor is placed in username field, nothing is suggested when cursor is in password field. Please see video: https://drive.google.com/file/d/0By4O1f2IQqQ_UlI5V2I5ODdoWm8/view
,
Jun 6 2017
Thank you for the detailed feedback. I am returning this bug to Available, because the iOS story will be fixed by other team members.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdd46b0be27f87114037e15970f97209fea79bca commit cdd46b0be27f87114037e15970f97209fea79bca Author: Vadym Doroshenko <dvadym@chromium.org> Date: Wed Aug 02 18:05:54 2017 [Bling Password Manager] Unifying treating of password form action Normalizing of password form action is done in 2 different cases with different code: 1.On Load, in Obj-C code in password_controller.mm 2.On fill in JS in password_controller.js That's bad, as any duplicating code, because in some cases it generates different canonical actions (for example when the action is empty). This CL unifying canonical action calculation. As a model for canonical action calculation GetCanonicalActionForForm from Desktop/Android implementation is taken. Bug: 710438 , 708602 Change-Id: I1ea879c60d01cf02bed6ea9715089221971ff4a0 Reviewed-on: https://chromium-review.googlesource.com/596031 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491434} [modify] https://crrev.com/cdd46b0be27f87114037e15970f97209fea79bca/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/cdd46b0be27f87114037e15970f97209fea79bca/ios/chrome/browser/passwords/password_controller_js_unittest.mm [modify] https://crrev.com/cdd46b0be27f87114037e15970f97209fea79bca/ios/chrome/browser/passwords/password_controller_unittest.mm [modify] https://crrev.com/cdd46b0be27f87114037e15970f97209fea79bca/ios/chrome/browser/passwords/resources/password_controller.js
,
Aug 4 2017
,
Aug 8 2017
Saved Username and Password are filled into Sign in form correctly. Verified on M62.0.3079.0 canary Device: iPhone7 plus, ipad Pro iOS: 11.0 beta#5, iOS10.3.3 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by linds...@chromium.org
, Apr 5 2017