New issue
Advanced search Search tips

Issue 708601 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

username and password is not autofilled for buybuybaby.com or bedbathandbeyond.com

Project Member Reported by linds...@chromium.org, Apr 5 2017

Issue description

App Version:59.0.3054.0
iOS Version: iOs10.3.1
Device: iPhone7
URL: bedbathandbeyond.com

Steps to reproduce:
  1. On desktop (signed in for sync) go to bedbathandbeyond.com and login, opt to save the u/p
  2. On ios, open Chrome (signed in for sync), go to bedbathandbeyond.com

Observed results:
Username and password should be filled in

Expected results:
Username and password are never filled in.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install:Yes
Bug reproducible after clearing cache and cookies:Yes
Observed behavior in Chrome Mobile on Android: n/a
Check for similar behavior on Firefox/Safari: n/a
Bug reproducible on current stable build (App Version, iOS Version): Yes M57
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes M58
 
Labels: Hotlist-UP

Comment 2 by sczs@chromium.org, Apr 5 2017

Cc: melandory@chromium.org
Labels: M-59
Owner: vabr@chromium.org
Status: Assigned (was: Untriaged)
Hi vabr@ , melandory@ could you please take a look.

Comment 3 by vabr@chromium.org, Apr 6 2017

Labels: Hotlist-Polish
Owner: ----
Status: Available (was: Assigned)
As explained to lindsayw@ in an e-mail, I am moving these bugs to our TODO list, and reducing some unnecessary noise they cause.

Comment 4 by vabr@chromium.org, Apr 16 2017

Cc: -melandory@chromium.org
Labels: Hotlist-WorksOnDesktop Pri-3
This is working on desktop and hence likely to be fixed once we start sharing desktop heuristics with iOS code.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c312133cc23628484d67ce590320a5aab7ac3c

commit f4c312133cc23628484d67ce590320a5aab7ac3c
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Tue Nov 21 09:58:56 2017

Improving fill on account select in IOS Password Manager.

The current implementation of fill on account select on IOS is very limited - it supports only
1 form on the page, doesn't support forms without <form> tag, filling of only password fields
and manual fallbacks for clicking on password field. Logic for filling on account select is
pretty complex and it's worth a separate class, it would also allow to test better this
functionality. This CL introduces a new class AccountSelectFillData for handling fill on
account select. Automatically it allows filling multiple forms on account select.

The future plans: base on newly introduced class AccountSelectFillData to implement in the following
CLs filling
 1.Forms without <form> tag
 2.Filling password fields on click (a.k.a. manual fallback for filling).

Bug:  708601 ,  786966 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4549c8056f91aece3cf643e2540871c60820f4d8
Reviewed-on: https://chromium-review.googlesource.com/733093
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518199}
[modify] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/BUILD.gn
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/account_select_fill_data.cc
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/account_select_fill_data.h
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/account_select_fill_data_unittest.cc
[modify] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/password_controller_unittest.mm
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/test_helpers.cc
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/test_helpers.h

Comment 6 by dvadym@chromium.org, Nov 21 2017

Status: Fixed (was: Available)
Status: Verified (was: Fixed)
Verified in 64.0.3280.0 Canary on iPhone 8plus(iOS 11.2 beta5)

Followed the steps from comment #0, both Email and password fields are autofilled when the desktop site or mobile version is loaded in the iPhone device.

tested on both websites http://bedbathandbeyond.com/ and http://buybuybaby.com/, looks good

Sign in to add a comment