twitter username/password not autofilled |
|||||||||||||
Issue descriptionApp Version:59.0.3054.0 iOS Version: iOs10.3.1 Device: iPhone7 URL: twitter.com Steps to reproduce: 1. On desktop (signed in for sync) go to twitter and login, opt to save the u/p 2. On ios, open Chrome (signed in for sync), go to twitter.com Observed results: Username and password should be filled in Expected results: Username and password are never filled in. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install:Yes Bug reproducible after clearing cache and cookies:Yes Observed behavior in Chrome Mobile on Android: n/a Check for similar behavior on Firefox/Safari: n/a Bug reproducible on current stable build (App Version, iOS Version): Yes M57 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes M58
,
Apr 5 2017
,
Apr 5 2017
Hi vabr@ , melandory@ could you please take a look.
,
Apr 6 2017
As explained to lindsayw@ in an e-mail, I am moving these bugs to our TODO list, and reducing some unnecessary noise they cause.
,
Apr 16 2017
This is working on desktop and hence likely to be fixed once we start sharing desktop heuristics with iOS code.
,
May 4 2017
,
May 4 2017
,
Aug 9 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75c63e7a07f0dbdf77372e4aeff543eee680e463 commit 75c63e7a07f0dbdf77372e4aeff543eee680e463 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Fri Aug 25 12:54:26 2017 [Bling Password Manager] Send request to browser on input onFocus. Password Manager on other platforms listens to DOM changes in order to detect dynamically added forms. In Bling there is no such mechanism. This CL adds mitigation for this, namely if the user clicks on an input element and no password forms found on this page, Password Manager would try to find password forms. So this CL would allow to process dynamically added forms in principle, both for filling (when the user clicks) and saving (if the form is not found, it would be skipped on submission in PasswordManager, since in the current architecture PasswordFormManager should be created before submission). The request to the password store on the focus is sent only once for a page, and that's controlled by |sent_request_to_store_| variable. Bug: 708597 , 709011 , 708634 Change-Id: Ie47f6335c6c7681dadfef7b53276007527e400c4 Reviewed-on: https://chromium-review.googlesource.com/601969 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#497383} [modify] https://crrev.com/75c63e7a07f0dbdf77372e4aeff543eee680e463/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/75c63e7a07f0dbdf77372e4aeff543eee680e463/ios/chrome/browser/passwords/password_controller_unittest.mm
,
Oct 5 2017
Is this considered fixed and ready for verification?
,
Feb 13 2018
Any updates on this one?
,
Feb 14 2018
Issue still exists. Checked on chrome beta version 65.0.3325.70 on iPhone 7 with iOS 10.3.3, following the steps mentioned in comment #0.
,
Feb 14 2018
Partially filling on twitter was fixed on #9 (i.e. from M-62), for checking this, please save on Desktop, 1.go to sign-in page in IOS. 2.click on username field. 3.type the first letter of the saved username, password suggestions should be shown. It's not ideal, but at least it makes Password Manager usable if the user knows the first letter of username. I'm going to make that it would work without step 3, i.e. it would be possible to get suggestions, just by clicking on username, but it's going to be a pretty big change, and now I have more important fixes. I leave this issue open until implementing this patch. Please note that it's not going to be filled automatically anyway, since a mobile version of the site (mobile.twitter.com) and Desktop one (twitter.com) are fuzzy match and Password Manager never fills fuzzy matched credentils automatically.
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/680972d7f662ac2414aaa8fa73f66cacf9e88c9b commit 680972d7f662ac2414aaa8fa73f66cacf9e88c9b Author: Vadym Doroshenko <dvadym@chromium.org> Date: Thu Mar 01 17:31:40 2018 [IOS Password Manager] Async suggestions retrieval. When a password form is added dynamically (i.e. with JavaScript after finishing of a page load) IOS Password Manager may learn about existing of this form only after user clicking on some field in this form. On CL https://chromium-review.googlesource.com/c/chromium/src/+/601969 it was implemented retrieving credentials from the Password Store as soon as the user clicked on dynamically added form and then credentials are autofilled. But fill on account select is not available until the user makes another interaction with the form (for example start typing of username). That's suboptimal user experience, it would be good to propose fill on account select immediately as soon as the user clicks the first time in the form. This CL implements async suggestion response to Autofill framework in the same way as it's already implemented in Autofill: 1.When checkIfSuggestionsAvailableForForm (password_controller.mm) is called, and it's found that credentials haven't been retrieved yet for this page, the callback is saved untile response from the Password Store is received. 2.It's implemented that Password Store response is propagated to PasswordController even if case when there are no credentials saved for this page in order to inform Autofill framework that no suggestions are available. Bug: 708597 , 709011 , 708634 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idecc3e621100f3e1b0a3803ce944c4cc116fc3a4 Reviewed-on: https://chromium-review.googlesource.com/921961 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540200} [modify] https://crrev.com/680972d7f662ac2414aaa8fa73f66cacf9e88c9b/components/password_manager/core/browser/password_form_manager.cc [modify] https://crrev.com/680972d7f662ac2414aaa8fa73f66cacf9e88c9b/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/680972d7f662ac2414aaa8fa73f66cacf9e88c9b/components/password_manager/core/browser/password_manager_driver.h [modify] https://crrev.com/680972d7f662ac2414aaa8fa73f66cacf9e88c9b/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h [modify] https://crrev.com/680972d7f662ac2414aaa8fa73f66cacf9e88c9b/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm [modify] https://crrev.com/680972d7f662ac2414aaa8fa73f66cacf9e88c9b/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/680972d7f662ac2414aaa8fa73f66cacf9e88c9b/ios/chrome/browser/passwords/password_controller_unittest.mm
,
Mar 15 2018
Mobile twitter site is fuzzy matched to Desktop (mobile.twitter.com vs twitter.com), that means it could be filled only on account select, i.e. by clicking on the username field and choosing username from keyboard accessories. Now it works.
,
Mar 27 2018
Tested in 61.0.3381.0 Canary on iPhone 8(iOS 11.2.6), ipad Air(iOS 11.2.6), iPhone 7plus(iOS 10.3.3), iPad mini(iOS 10.3.3) Followed the steps mentioned in comment#0, Password suggestions are not displayed on clicking for the first time in the form. On second click the password suggestions are displayed. Link to video: https://drive.google.com/file/d/13rOcfSKLHRpM8hRpvMZL6TPktpsw6ezq/view?usp=sharing Note: Few times the password suggestions display on first click (using same steps)
,
Mar 27 2018
"Tested in 61.0.3381.0 Canary" ? Maybe we should be testing on a later version like what's in beta currently (M66?) dvadym@: is the fix in M66 branch?
,
Mar 27 2018
Its a typo. Based on video at 0.24 sec, Chrome version is M67.0.3381.0 canary.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b245d69b638b18b829172f50a00875bcb381b80b commit b245d69b638b18b829172f50a00875bcb381b80b Author: Vadym Doroshenko <dvadym@chromium.org> Date: Thu Apr 05 16:37:12 2018 Ignore form_changed message in FormInputAccessoryViewController. On CL https://chromium-review.googlesource.com/c/chromium/src/+/943321 it was implemented JS message of type "form_changed", which is called when dynamically added form is found. This message shouldn't initiate showing autofill input accessories, because input accessories has to be shown only on user action. Bug: 708597 , 798675 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib4d687ab2c7b344ec8f448ebef5025e7b68c3883 Reviewed-on: https://chromium-review.googlesource.com/997840 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#548449} [modify] https://crrev.com/b245d69b638b18b829172f50a00875bcb381b80b/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
,
Apr 5 2018
It should be in dev in 1 week or so (any version > 67.0.3387.0)
,
Apr 10 2018
Verified in: App Version: 67.0.3393.0 canary Devices: iPhone 6S Plus, iPhone X iOS Versions: 10.3.3, 11.4 Beta 1 Username and Password fields are filled in by clicking on username field and choosing suggestions displayed on keyboard accessories. Video: https://drive.google.com/open?id=1IYSSbTjzjm76nJywP9llwBI5SgEjXIHy |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by linds...@chromium.org
, Apr 5 2017