New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708585 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

BookmarkTest#testSearchBookmarks failing on large devices

Reported by kra...@amazon.com, Apr 5 2017

Issue description

Version: Tip of master
OS: Android

What steps will reproduce the problem?
(1) Run BookmarkTest#testSearchBookmarks on a Nexus 10 (or any other large tablet)

What is the expected output?
The test passes

What do you see instead?
I   88.353s Main  FINISHED TRY #1/1
I   88.354s Main  1 failed tests remain.
C   88.354s Main  ********************************************************************************
C   88.354s Main  Detailed Logs
C   88.354s Main  ********************************************************************************
C   88.355s Main  [FAIL] org.chromium.chrome.browser.bookmarks.BookmarkTest#testSearchBookmarks:
C   88.355s Main  junit.framework.AssertionFailedError: Wrong number of items before starting search. expected:<3> but was:<4>
C   88.355s Main        at org.chromium.chrome.browser.bookmarks.BookmarkTest.testSearchBookmarks(BookmarkTest.java:190)
C   88.355s Main        at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C   88.355s Main        at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C   88.355s Main        at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C   88.355s Main        at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
C   88.355s Main        at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C   88.355s Main        at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C   88.355s Main        at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C   88.356s Main        at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C   88.356s Main        at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C   88.356s Main        at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
C   88.356s Main  ********************************************************************************
C   88.356s Main  Summary
C   88.356s Main  ********************************************************************************
C   88.356s Main  [==========] 1 test ran.
C   88.356s Main  [  PASSED  ] 0 tests.
C   88.357s Main  [  FAILED  ] 1 test, listed below:
C   88.357s Main  [  FAILED  ] org.chromium.chrome.browser.bookmarks.BookmarkTest#testSearchBookmarks
C   88.357s Main
C   88.357s Main  1 FAILED TEST
C   88.357s Main  ********************************************************************************

Please use labels and text to provide additional information.
 
Components: UI>Browser>Bookmarks
Labels: OS-Android
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca8a360ea076f91656d102229049c0fee2b46be

commit 3ca8a360ea076f91656d102229049c0fee2b46be
Author: kraush <kraush@amazon.com>
Date: Thu Apr 06 00:11:00 2017

Adjust BookmarkTest for large devices

This change makes sure the divider is taken into account
when counting items in BookmarkTest#testSearchBookmarks.

BUG= 708585 

Review-Url: https://codereview.chromium.org/2800763002
Cr-Commit-Position: refs/heads/master@{#462287}

[modify] https://crrev.com/3ca8a360ea076f91656d102229049c0fee2b46be/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java

Comment 4 by ltian@chromium.org, Apr 19 2018

Cc: kra...@amazon.com twelling...@chromium.org
Labels: android-fe-triaged
Status: Fixed (was: Untriaged)
kraush@: does your cl fix the problem?

Sign in to add a comment