New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 708583 link

Starred by 2 users
Status: Fixed
Owner:
█ joenotcharles@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Rename reason to message in csd.proto

Project Member Reported by joenotcharles@chromium.org, Apr 5 2017 
The "reason" field of csd.proto was renamed to "message" on the server side. The client should be updated to match.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee02108c6c8a064f04bbbb214c07c60cb48f48c

commit dee02108c6c8a064f04bbbb214c07c60cb48f48c
Author: joenotcharles <joenotcharles@chromium.org>
Date: Wed Apr 05 21:21:09 2017

Rename reason to message in csd.proto, to match a server-side change.

This does _not_ change the tag number, so the proto is still wire-compatible, so there are no compatibility concerns.

BUG= 708583 

Review-Url: https://codereview.chromium.org/2783143002
Cr-Commit-Position: refs/heads/master@{#462219}

[modify] https://crrev.com/dee02108c6c8a064f04bbbb214c07c60cb48f48c/components/safe_browsing/csd.proto

Comment 2 by joenotcharles@chromium.org, Apr 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment