New issue
Advanced search Search tips

Issue 708582 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task

Blocking:
issue 567293



Sign in to add a comment

Add test cases for mask tiling

Project Member Reported by sunxd@chromium.org, Apr 5 2017

Issue description

This is a task tracking bug: we want cc pixel tests with tiled mask layers; we also want to break existing cc unit tests that conditionally choose one code path based on the flag enable_mask_tiling, into separate tests that tests tiled masks and single texture masks.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8cb0d0aaee74d9e4a01276a1ee366b65bc3261a

commit f8cb0d0aaee74d9e4a01276a1ee366b65bc3261a
Author: sunxd <sunxd@chromium.org>
Date: Wed Apr 26 14:42:06 2017

cc: Add mask tiling unit tests

This patch is intended to make existing cc unit tests test both
ways of mask tiling flag.

Notice that the cc pixel test is already testing multi texture
masks.

BUG= 708582 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2835213002
Cr-Commit-Position: refs/heads/master@{#467323}

[modify] https://crrev.com/f8cb0d0aaee74d9e4a01276a1ee366b65bc3261a/cc/trees/layer_tree_host_unittest.cc

Comment 2 by sunxd@chromium.org, Apr 27 2017

Blocking: 567293
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60e148f1da0c27818ec63406b731ca686393440c

commit 60e148f1da0c27818ec63406b731ca686393440c
Author: sunxd <sunxd@chromium.org>
Date: Tue May 02 19:33:21 2017

cc: cc pixel tests test both single/multi texture mask code paths.

We want to test both code paths that tile or not tile any mask in cc
pixel tests.

BUG= 708582 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2852083002
Cr-Commit-Position: refs/heads/master@{#468744}

[modify] https://crrev.com/60e148f1da0c27818ec63406b731ca686393440c/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/60e148f1da0c27818ec63406b731ca686393440c/cc/test/layer_tree_pixel_resource_test.h
[modify] https://crrev.com/60e148f1da0c27818ec63406b731ca686393440c/cc/trees/layer_tree_host_pixeltest_masks.cc

Comment 4 by sunxd@chromium.org, May 2 2017

Status: Fixed (was: Assigned)

Sign in to add a comment