Keep track of the size of ad frames on pages.
Hope to get the CL out for review on Monday. https://codereview.chromium.org/2798953002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6616a885b4f18edd4f6aa178146c14538ca1d429 commit 6616a885b4f18edd4f6aa178146c14538ca1d429 Author: jkarlin <jkarlin@chromium.org> Date: Tue May 02 19:26:46 2017 [PageLoadMetrics] Keep track of Ad Sizes on Pages In order to help us understand the resource footprint that ads have on webpages, we need to measure things like their network and cache utilizations. This CL adds a PageLoadObserver that keeps track of frames with ads and reports statistics on the number of ad frames found on the page, the size of the ad frames, and the percentage that came from cache vs network. As part of the work, the following additional changes were necessary: 1) Frame Tree ID and URL are added to extra request info 2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that ChromeResourceDispatcherHostDelegate can get at the frame tree node id of the resource. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation BUG= 708570 Review-Url: https://codereview.chromium.org/2798953002 Cr-Commit-Position: refs/heads/master@{#468738} [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/BUILD.gn [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/metrics_web_contents_observer.h [add] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [add] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [add] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/page_load_metrics_observer.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/chrome/test/BUILD.gn [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/content/browser/loader/resource_request_info_impl.h [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/content/public/browser/resource_request_info.h [modify] https://crrev.com/6616a885b4f18edd4f6aa178146c14538ca1d429/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cf1c346b92fe3d9a5013608b88982fe99f02d60 commit 1cf1c346b92fe3d9a5013608b88982fe99f02d60 Author: jkarlin <jkarlin@chromium.org> Date: Wed May 03 13:31:39 2017 Revert "[PageLoadMetrics] Keep track of Ad Sizes on Pages" This reverts commit 6616a885b4f18edd4f6aa178146c14538ca1d429, https://codereview.chromium.org/2798953002/. We're seeing subframes created of navigations that failed to commit. TBR=bmcquade,clamy,jam,csharrison,isherman # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 717892 ,715547 Review-Url: https://codereview.chromium.org/2857963002 Cr-Commit-Position: refs/heads/master@{#468956} [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/BUILD.gn [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/metrics_web_contents_observer.h [delete] https://crrev.com/ee63feacd7199214bf9673efd957afabe9be13bb/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [delete] https://crrev.com/ee63feacd7199214bf9673efd957afabe9be13bb/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [delete] https://crrev.com/ee63feacd7199214bf9673efd957afabe9be13bb/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/page_load_metrics_observer.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/chrome/test/BUILD.gn [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/content/browser/loader/resource_request_info_impl.h [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/content/public/browser/resource_request_info.h [modify] https://crrev.com/1cf1c346b92fe3d9a5013608b88982fe99f02d60/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73af8befbc973943ac062ccd7d48b73ecc61de60 commit 73af8befbc973943ac062ccd7d48b73ecc61de60 Author: jkarlin <jkarlin@chromium.org> Date: Wed May 03 18:36:58 2017 Reland of https://codereview.chromium.org/2798953002 where the observer is disabled since it's still broken. [PageLoadMetrics] Keep track of Ad Sizes on Pages In order to help us understand the resource footprint that ads have on webpages, we need to measure things like their network and cache utilizations. This CL adds a PageLoadObserver that keeps track of frames with ads and reports statistics on the number of ad frames found on the page, the size of the ad frames, and the percentage that came from cache vs network. As part of the work, the following additional changes were necessary: 1) Frame Tree ID and URL are added to extra request info 2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that ChromeResourceDispatcherHostDelegate can get at the frame tree node id of the resource. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation BUG= 708570 ,717892 TBR=bmcquade,clamy,jam,csharrison,isherman Review-Url: https://codereview.chromium.org/2861473003 Cr-Commit-Position: refs/heads/master@{#469042} [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/BUILD.gn [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/metrics_web_contents_observer.h [add] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [add] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [add] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/page_load_metrics_observer.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/chrome/test/BUILD.gn [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/content/browser/loader/resource_request_info_impl.h [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/content/public/browser/resource_request_info.h [modify] https://crrev.com/73af8befbc973943ac062ccd7d48b73ecc61de60/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71 commit 6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71 Author: jkarlin <jkarlin@chromium.org> Date: Wed May 10 20:50:47 2017 [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts It turns out that a frame can abort and continue to load resources even if it has no previous navigation. This happens if a doc.write overwrites the frame navigation while the navigation is still provisional. This CL now labels all finished frame navigations (regardless of success) and removes an incorrect dcheck. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation BUG= 708570 Review-Url: https://codereview.chromium.org/2861433005 Cr-Commit-Position: refs/heads/master@{#470701} [modify] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [add] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/test/BUILD.gn [add] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/test/data/ads_observer/docwrite_provisional_frame.html [add] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/test/data/ads_observer/pixel.png [add] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/test/data/ads_observer/pixel2.png [add] https://crrev.com/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71/chrome/test/data/ads_observer/pixel3.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98e70d364070da7465beea8205d99adc89279e66 commit 98e70d364070da7465beea8205d99adc89279e66 Author: jkarlin <jkarlin@chromium.org> Date: Fri May 12 21:27:18 2017 [PageLoadMetrics] Reland handling of nav aborts in ads metrics This is a reland of https://codereview.chromium.org/2861433005 but with ads metrics disabled and the browsertest fixed to enable the feature (in case it's disabled by default). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation BUG= 708570 Review-Url: https://codereview.chromium.org/2883433002 Cr-Commit-Position: refs/heads/master@{#471446} [modify] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [add] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/test/BUILD.gn [add] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/test/data/ads_observer/docwrite_provisional_frame.html [add] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/test/data/ads_observer/pixel.png [add] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/test/data/ads_observer/pixel2.png [add] https://crrev.com/98e70d364070da7465beea8205d99adc89279e66/chrome/test/data/ads_observer/pixel3.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c33a8ddef6ca33f58a8a76b24db5a00073e5a9aa commit c33a8ddef6ca33f58a8a76b24db5a00073e5a9aa Author: jkarlin <jkarlin@chromium.org> Date: Tue May 16 22:20:07 2017 [PageLoadMetrics] Relax invariants and log the exceptions It turns out that: 1) We can get resource loads for frames that don't belong to the page and 2) We can get notice of frame commits for frames that don't belong to the page. We hope this is rare (and record histograms to verify) and relax the constraints. BUG= 708570 Review-Url: https://codereview.chromium.org/2884753002 Cr-Commit-Position: refs/heads/master@{#472230} [modify] https://crrev.com/c33a8ddef6ca33f58a8a76b24db5a00073e5a9aa/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc [modify] https://crrev.com/c33a8ddef6ca33f58a8a76b24db5a00073e5a9aa/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/c33a8ddef6ca33f58a8a76b24db5a00073e5a9aa/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/c33a8ddef6ca33f58a8a76b24db5a00073e5a9aa/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/c33a8ddef6ca33f58a8a76b24db5a00073e5a9aa/tools/metrics/histograms/enums.xml [modify] https://crrev.com/c33a8ddef6ca33f58a8a76b24db5a00073e5a9aa/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26 commit 6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26 Author: jkarlin <jkarlin@chromium.org> Date: Tue May 16 23:36:49 2017 [PageLoadMetrics] Enable AdsPageLoadMetrics by default Now that we've addressed all of the known causes of crashes, it's time to reenable. BUG= 708570 Review-Url: https://codereview.chromium.org/2887773003 Cr-Commit-Position: refs/heads/master@{#472248} [modify] https://crrev.com/6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbfd1d204f097c0dc0e48de1b4cca0169aaf35e6 commit bbfd1d204f097c0dc0e48de1b4cca0169aaf35e6 Author: bmcquade <bmcquade@chromium.org> Date: Wed May 17 02:06:45 2017 Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default (patchset #1 id:1 of https://codereview.chromium.org/2887773003/ ) Reason for revert: Reverting based on findit-for-me notification Original issue's description: > [PageLoadMetrics] Enable AdsPageLoadMetrics by default > > Now that we've addressed all of the known causes of crashes, it's time to > reenable. > > BUG= 708570 > > Review-Url: https://codereview.chromium.org/2887773003 > Cr-Commit-Position: refs/heads/master@{#472248} > Committed: https://chromium.googlesource.com/chromium/src/+/6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26 TBR=jkarlin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 708570 Review-Url: https://codereview.chromium.org/2890603005 Cr-Commit-Position: refs/heads/master@{#472285} [modify] https://crrev.com/bbfd1d204f097c0dc0e48de1b4cca0169aaf35e6/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40c27d78b91fc87eb549e263640e66d8a3f4ba67 commit 40c27d78b91fc87eb549e263640e66d8a3f4ba67 Author: jkarlin <jkarlin@chromium.org> Date: Thu May 18 16:16:45 2017 [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed This is a simple fix with a complex test. BUG=723219, 708570 Review-Url: https://codereview.chromium.org/2893633003 Cr-Commit-Position: refs/heads/master@{#472833} [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8dedd689f7ca1b0f4f64d8c238f8b960a3f54a8a commit 8dedd689f7ca1b0f4f64d8c238f8b960a3f54a8a Author: jkarlin <jkarlin@chromium.org> Date: Thu May 18 17:49:45 2017 [PageLoadMetrics] Enable AdsPageLoadMetrics once again BUG= 708570 Review-Url: https://codereview.chromium.org/2889933003 Cr-Commit-Position: refs/heads/master@{#472866} [modify] https://crrev.com/8dedd689f7ca1b0f4f64d8c238f8b960a3f54a8a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72 commit 5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72 Author: Charles Harrison <csharrison@chromium.org> Date: Mon Jun 05 20:39:44 2017 [subresource_filter] Add observer interface for subframe filtering This will allow observers to see when subframes are filtered, or when subframes would have been filtered in DRYRUN. Bug: 708570 Change-Id: Ie85f38f9577f3e0b2a055619c0ffe3c37f460834 Reviewed-on: https://chromium-review.googlesource.com/523224 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#477076} [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/chrome/browser/subresource_filter/subresource_filter_unittest.cc [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/BUILD.gn [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/async_document_subresource_filter.h [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.cc [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/subresource_filter_observer.h [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/subresource_filter_observer_manager.cc [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/subresource_filter_observer_manager.h [add] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.cc [add] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/content/renderer/web_document_subresource_filter_impl.cc [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/core/common/BUILD.gn [modify] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/core/common/document_subresource_filter.h [add] https://crrev.com/5f1a6e36f7b0d82a1dd0c4ddab5911e82c16db72/components/subresource_filter/core/common/load_policy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1fee60d6261d4a1016dd5a574abbca43d84a4d9 commit d1fee60d6261d4a1016dd5a574abbca43d84a4d9 Author: Josh Karlin <jkarlin@chromium.org> Date: Fri Jul 14 17:37:30 2017 [AdsPageLoadMetrics] Track frames identified as ads by SubresourceFilter Labels frames identified as ads by the SubresourceFilter as ads. Also adds an AdType to each frame tracked by AdsPageLoadMetrics. When it's time to record the metrics, the same logic is applied once to collect stats for each ad type. There is also an additional ad type, "All", which records stats on all of the identified ads, regardless of which detector discovered it. Bug: 708570 Change-Id: Ic0f1f1cfd7176ffdba459b607735a6aa6b4318ff Reviewed-on: https://chromium-review.googlesource.com/567324 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486797} [modify] https://crrev.com/d1fee60d6261d4a1016dd5a574abbca43d84a4d9/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/d1fee60d6261d4a1016dd5a574abbca43d84a4d9/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/d1fee60d6261d4a1016dd5a574abbca43d84a4d9/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/d1fee60d6261d4a1016dd5a574abbca43d84a4d9/tools/metrics/histograms/histograms.xml
Comment 1 by animohan@chromium.org
, Apr 5 2017