New issue
Advanced search Search tips

Issue 708557 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Global PRESUBMIT format check incorrectly insists that third_party be formatted

Project Member Reported by mark@chromium.org, Apr 5 2017

Issue description

Since PRESUBMIT.py began insisting on formatting tree-wide, even changes in third_party are now raising this PRESUBMIT warning:

--
Running presubmit upload checks ...

** Presubmit Warnings **
The src directory requires source formatting. Please run git cl format .

Presubmit checks took 4.6s to calculate.

There were presubmit warnings. Are you sure you wish to continue? (y/N): 
--

It is inappropriate to insist on any particular formatting in third_party. This check is misleading people into thinking that they should be adapting code in third_party to Chrome’s conventions, when in fact it’s far more important to leave it alone so that it can easily be diffed against upstream and updated in the future.
 

Sign in to add a comment