New issue
Advanced search Search tips

Issue 708523 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Flaky test: WebApkIntegrationTest#testLaunch failing on chromium.linux/Android Tests

Project Member Reported by awdf@chromium.org, Apr 5 2017

Issue description

chrome_public_test_apk failing on chromium.linux/Android Tests

Builders failed on: 
- Android Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests

findit says it's flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=org.chromium.chrome.browser.webapps.WebApkIntegrationTest%23testLaunch&testType=chrome_public_test_apk 

org.chromium.chrome.browser.webapps.WebApkIntegrationTest#testLaunch (run #1):
junit.framework.AssertionFailedError: Page did not load.  Tab information at time of failure -- url: http://127.0.0.1:41287/chrome/test/data/android/test.html, final URL: http://127.0.0.1:41287/chrome/test/data/android/test.html, load progress: 100, is loading: false
	at org.chromium.chrome.test.util.ChromeTabUtils.waitForTabPageLoaded(ChromeTabUtils.java:84)
	at org.chromium.chrome.browser.webapps.WebApkIntegrationTest.startWebApkActivity(WebApkIntegrationTest.java:46)
	at org.chromium.chrome.browser.webapps.WebApkIntegrationTest.testLaunch(WebApkIntegrationTest.java:84)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7576d8453c3b3147136b19180fbf10464d22be07

commit 7576d8453c3b3147136b19180fbf10464d22be07
Author: awdf <awdf@chromium.org>
Date: Wed Apr 05 14:51:07 2017

Retry flaky WebApkIntegrationTest#testLaunch on failure

TBR=nyquist
BUG= 708523 

Review-Url: https://codereview.chromium.org/2796393002
Cr-Commit-Position: refs/heads/master@{#462070}

[modify] https://crrev.com/7576d8453c3b3147136b19180fbf10464d22be07/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java

Owner: ----
Status: Untriaged (was: Assigned)
Not sure why this was assigned to me. I don't know much about chrome tests on Android.

Comment 3 by awdf@chromium.org, Apr 7 2017

Components: -Tests Mobile>WebAPKs
Labels: Pri-3 Type-Task
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
Apologies sergeyu@ - I ran a git blame on the test class and saw your username, but on closer inspection I see you simply reverted & relanded a cl that added the test. 

Reassigning to pkotwicz@ as the original author of the test.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac2c353dc23284cca32db9ca76a21567f77e088

commit 3ac2c353dc23284cca32db9ca76a21567f77e088
Author: pkotwicz <pkotwicz@chromium.org>
Date: Thu Jun 15 15:22:08 2017

[Android] Remove RetryOnFailure from WebApkIntegrationTest

It is likely that the source of flakiness was fixed by
https://codereview.chromium.org/2859053004

BUG= 708523 

Review-Url: https://codereview.chromium.org/2935903002
Cr-Commit-Position: refs/heads/master@{#479710}

[modify] https://crrev.com/3ac2c353dc23284cca32db9ca76a21567f77e088/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment