Improve the injection of diagnostic info in feedback reports following profile errors |
|||||||||||
Issue descriptionFor users who opt to send a feedback report following a profile error, it would be nice to include the data in some better way than injecting it into the text field where the user is asked to provide data.
,
Apr 7 2017
,
May 8 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 8 2017
I'll get to it soon.
,
Jun 8 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2017
,
Jun 13 2017
,
Jun 14 2017
,
Jun 14 2017
[See attachment] I improved the wording a bit of the pre-populated feedback description, and removed the extra diagnostics part from it. Now feedback reports can be requested with given extra diagnostics that will be injected in the feedback's system information.
,
Jun 14 2017
,
Jun 14 2017
Thank you! +srahim for text review. "exactly before" is a little awkward to my ears, perhaps "right before"?
,
Jun 14 2017
Makes sense. I changed it.
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a28874006914c75dd23d022efc192ecdb9f9213b commit a28874006914c75dd23d022efc192ecdb9f9213b Author: afakhry <afakhry@chromium.org> Date: Thu Jun 15 18:24:36 2017 Provide a better way of injecting extra diagnostics in feedbacks Instead of adding them to the body of the feedback description, inject them in the feedback's system information. BUG= 708511 TEST=browser_tests --gtest_filter=FeedbackTest.ExtraDiagnostics Review-Url: https://codereview.chromium.org/2934303002 Cr-Commit-Position: refs/heads/master@{#479761} [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/app/generated_resources.grd [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/chromeos/login/ui/login_feedback.cc [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/feedback/show_feedback_page.cc [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/supervised_user/supervised_user_interstitial.cc [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/ui/browser_commands.cc [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/ui/chrome_pages.h [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/ui/profile_error_dialog.cc [modify] https://crrev.com/a28874006914c75dd23d022efc192ecdb9f9213b/chrome/browser/ui/sad_tab.cc
,
Jun 15 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by grt@chromium.org
, Apr 5 2017