Feedback on profile error should be opt-in and only present when useful |
||||||
Issue descriptionThis dialog has a "Send feedback to help us fix this issue." checkbox that is checked by default. This should be opt-in (unchecked by default) rather than opt-out (checked by default). Also, it should only be shown for cases where there is extra info to be included. Would a feedback report give us useful data for every one of: - IDS_PREFERENCES_CORRUPT_ERROR - IDS_PREFERENCES_UNREADABLE_ERROR - IDS_OPEN_PROFILE_DATA_LOSS - IDS_COULDNT_OPEN_PROFILE_ERROR - IDS_PROFILE_TOO_NEW_ERROR - IDS_COULDNT_STARTUP_PROFILE_ERROR
,
Apr 14 2017
Issue 707036 has been merged into this issue.
,
May 22 2017
,
May 22 2017
Changed the checkbox to be opt in. Changed the scary screamy message "DO NOT CHANGE BELOW THIS LINE" to "Please do not change below this line". We only show the above message if the diagnostics is not empty. Please check screenshots.
,
May 22 2017
Thanks, this is a huge improvement. LGTM. Remaining issue is to answer grt's question: in which circumstances do we need input from the user? And can we transmit the debug info below the line without putting it in that text box, which is for user input?
,
May 22 2017
We need input from the user to know what happened. Did they upgrade or downgrade? From which version to which version? Or is it not related to upgrade at all? Were they doing something to the files on the file system? .. So on so forth. Yes, we can. That's another bug I'll be working on soon tracked by Issue 708511 .
,
May 22 2017
+Shimi, could you help us find a way to ask for the info in #6 in a user-friendly way? I think as currently worded (see #4), people are likely to say "I launched chrome" which isn't helpful. Maybe we can refer to what happened "before this message first appeared" or give a hint about reinstalling Chrome or deleting files.
,
May 22 2017
Also be aware of Issue 708510, in which we will create an HC article that will direct users to what to do to resolve the issue. That would be easier than including instructions in the feedback form, which isn't really designed for that.
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4d990302ab30a05aada8e4928e3ec19a02222a7 commit e4d990302ab30a05aada8e4928e3ec19a02222a7 Author: afakhry <afakhry@chromium.org> Date: Tue May 23 05:09:19 2017 Make profile error dialog checkbox opt-in and improve feedback description 1) Change the profile error dialog checkbox to report a feedback when the dialog is dismissed to be opt-in instead of opt-out. 2) Change the scary message "DO NOT CHANGE BELOW THIS LINE" to "Please do not change below this line". 3) Only show the above message if we actually have some diagnostics data to add to the report. Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=708505#c4 BUG= 708505 TEST=On Chrome OS, run 'stop ui', trigger a profile error by 'echo "<some long random text>" > /home/chronos/Default/History'. Run 'start ui'. Make sure the checkbox is opt in in the error dialog, check the box, and click OK, the feedback is pre-populated with a message like the one in the screenshots. Review-Url: https://codereview.chromium.org/2896133002 Cr-Commit-Position: refs/heads/master@{#473813} [modify] https://crrev.com/e4d990302ab30a05aada8e4928e3ec19a02222a7/chrome/app/generated_resources.grd [modify] https://crrev.com/e4d990302ab30a05aada8e4928e3ec19a02222a7/chrome/browser/ui/profile_error_dialog.cc [modify] https://crrev.com/e4d990302ab30a05aada8e4928e3ec19a02222a7/chrome/browser/ui/views/simple_message_box_views.cc
,
May 23 2017
,
May 23 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by afakhry@chromium.org
, Apr 7 2017