omnibox.UrlBarTest#testCutHuge failed on Android |
|||
Issue descriptionomnibox.UrlBarTest#testCutHuge failed: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/40222. Looks like it might be flaky. Mpearson: I see your recent CL https://codereview.chromium.org/2790993003. Any chance it made this test flaky? Looks like there's some timeout in the test? Please have a look.
,
Apr 5 2017
Makes sense. I did https://codereview.chromium.org/2799653002/.
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8b12e10d8ad68dda1a2b19b42e2366541e61f70 commit d8b12e10d8ad68dda1a2b19b42e2366541e61f70 Author: maxmorin <maxmorin@chromium.org> Date: Wed Apr 05 14:26:21 2017 Add RetryOnFailure annotation to omnibox.UrlBarTest#testCutHuge. BUG= 708501 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2799653002 Cr-Commit-Position: refs/heads/master@{#462063} [modify] https://crrev.com/d8b12e10d8ad68dda1a2b19b42e2366541e61f70/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
,
Apr 5 2017
Hopefully there won't be more flakes?
,
Apr 5 2017
It's pretty unlikely that my changelist is the cause. That code I submitted is disabled by default. Marking this as fixed. If the flakiness is still an issue (that doesn't fix it), or if someone wants the @RetryOnFailure annotations cleaned up (I'm not sure how much we care about these things if they're only added manually, by hand, so cannot be too widespread / slow down the testing bots too much), please file a new bug in this component. |
|||
►
Sign in to add a comment |
|||
Comment 1 by awdf@chromium.org
, Apr 5 2017