New issue
Advanced search Search tips

Issue 708499 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

touchpad-scroll-impl-to-main.html is flaky

Project Member Reported by maxmorin@chromium.org, Apr 5 2017

Issue description

touchpad-scroll-impl-to-main.html occationally times out, see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9402 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9421. It seems quite rare, so I won't disable it right away.
 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=touchpad-scroll-impl-to-main.html

From this is looks like timeouts are several times per day and on multiple platforms. I will mark it as flaky.
It's already marked as slow for debug, but even there it's timing out, at least twice on WebKit Win7 (dbg).
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3179ff9cfb7dce149af24d9c9d17ed12234a018

commit c3179ff9cfb7dce149af24d9c9d17ed12234a018
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Thu Apr 06 08:23:40 2017

Mark touchpad-scroll-impl-to-main.html as flaky timeout

Marking it slow was not enough, it would still timeout on at least
WebKit Win7 (dbg).

BUG=708499
TBR=sahel@chromium.org

Review-Url: https://codereview.chromium.org/2800923003 .
Cr-Commit-Position: refs/heads/master@{#462391}

[modify] https://crrev.com/c3179ff9cfb7dce149af24d9c9d17ed12234a018/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/c3179ff9cfb7dce149af24d9c9d17ed12234a018/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Note, this test has also crashed on Mac 10.11 dbg:
 bug 724817 
Example build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/8838

Project Member

Comment 6 by bugdroid1@chromium.org, May 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d24c69cb0795cf270e983e945a004dbddfe43f3

commit 6d24c69cb0795cf270e983e945a004dbddfe43f3
Author: qyearsley <qyearsley@chromium.org>
Date: Sat May 20 21:20:48 2017

Mark touchpad-scroll-impl-to-main.html as flaky crash.

(This test was already marked flaky timeout before).

TBR=sahel
TBR_REASON=Making Mac 10.11 dbg green again
BUG= 724817 ,708499

Review-Url: https://codereview.chromium.org/2895063002
Cr-Commit-Position: refs/heads/master@{#473450}

[modify] https://crrev.com/6d24c69cb0795cf270e983e945a004dbddfe43f3/third_party/WebKit/LayoutTests/TestExpectations

Cc: qyears...@chromium.org
 Issue 724817  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f19e77150ac8a7bef7c0916096a4b958eb18a53e

commit f19e77150ac8a7bef7c0916096a4b958eb18a53e
Author: Sahel Sharify <sahel@chromium.org>
Date: Fri Aug 04 18:41:43 2017

touchpad-scroll-impl-to-main.html flaky test fixed.

promise test used to reduce flakiness.

virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html

Bug: 708499,  724817 
Test: fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html,
Change-Id: I0a240de95b5bcb53ed167a6fe7a855cebe740dcd
Reviewed-on: https://chromium-review.googlesource.com/601011
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492084}
[modify] https://crrev.com/f19e77150ac8a7bef7c0916096a4b958eb18a53e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f19e77150ac8a7bef7c0916096a4b958eb18a53e/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350a1053dc2a1ce6574f425cc917ba4066e52bad

commit 350a1053dc2a1ce6574f425cc917ba4066e52bad
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Mon Aug 07 06:01:57 2017

Mark virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html as flaky on Mac 10.11 Dbg

BUG=708499
TBR=vasilii@chromium.org

Change-Id: I660ad4c5a7d6e19c8316d01932c63e2f35e7822b
Reviewed-on: https://chromium-review.googlesource.com/602097
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#492268}
[modify] https://crrev.com/350a1053dc2a1ce6574f425cc917ba4066e52bad/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac52dfae0506a18df0c1ccaa6cda19fcc502e658

commit ac52dfae0506a18df0c1ccaa6cda19fcc502e658
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Mon Aug 07 11:16:03 2017

Mark virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html as flaky on Win7 Debug.

virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html
 is also failing on Win7 Debug.

BUG=708499
TBR=vasilii@chromium.org

Change-Id: I55ac0291e0d588b7c18905f51526bfe73a559cc6
Reviewed-on: https://chromium-review.googlesource.com/603428
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#492299}
[modify] https://crrev.com/ac52dfae0506a18df0c1ccaa6cda19fcc502e658/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f477066a71a0c629dc55a89a00cee67eb9b30511

commit f477066a71a0c629dc55a89a00cee67eb9b30511
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Aug 31 05:16:19 2017

Mark virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html as flaky on Linux

virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html
is flaky on Linux.

On the other hand, it looks not flaky on Mac.

BUG=708499
TBR=vasilii@chromium.org

Change-Id: I2c616d450df03c684ae21d04ca67e0c7f9951b18
Reviewed-on: https://chromium-review.googlesource.com/644927
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498760}
[modify] https://crrev.com/f477066a71a0c629dc55a89a00cee67eb9b30511/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be87f9d72a446ff1816cba3f7be16d771e68d5bc

commit be87f9d72a446ff1816cba3f7be16d771e68d5bc
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Nov 01 15:25:46 2017

Clean up flaky expectations with update-flaky-expectations

Bug:  457273 , 605525 ,626703, 667560 ,708499, 731509 , 731535 , 732103 , 736548 , 746904 , 747163 , 752845 , 771729 
Change-Id: Ibf4be93e26a364e91d44375379aa8b5a7b59b94f
Reviewed-on: https://chromium-review.googlesource.com/736047
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513134}
[modify] https://crrev.com/be87f9d72a446ff1816cba3f7be16d771e68d5bc/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e

commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e
Author: Sahel Sharify <sahel@chromium.org>
Date: Thu Mar 15 17:30:49 2018

Send GSB before switching to mainthread scrolling in smooth scroll path.

This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling
path,if the compositor handles the GSB and during the scrolling we have to switch to main thread
since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original
GSB was handled on the compositor rather than being sent to the main thread.

touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main
thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling
in this cl I've moved the test to a new virtual test suite that has default scroll animation
value.

I have removed the test expectations since I have changed the test and this might fix the flake.

subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to
a new test suite.

Bug: 820979, 708499, 757165,  800840 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0
Reviewed-on: https://chromium-review.googlesource.com/961264
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543425}
[modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling
[modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html
[rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html
[copy] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt
[rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt
[modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/ui/events/blink/input_handler_proxy.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a6d89788324987fbad1450b2db6f113129a7130

commit 0a6d89788324987fbad1450b2db6f113129a7130
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Thu Mar 15 19:20:17 2018

Revert "Send GSB before switching to mainthread scrolling in smooth scroll path."

This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e.

Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see  issue 822386 

bug:  822386 

Original change's description:
> Send GSB before switching to mainthread scrolling in smooth scroll path.
> 
> This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling
> path,if the compositor handles the GSB and during the scrolling we have to switch to main thread
> since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original
> GSB was handled on the compositor rather than being sent to the main thread.
> 
> touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main
> thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling
> in this cl I've moved the test to a new virtual test suite that has default scroll animation
> value.
> 
> I have removed the test expectations since I have changed the test and this might fix the flake.
> 
> subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to
> a new test suite.
> 
> Bug: 820979, 708499, 757165,  800840 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0
> Reviewed-on: https://chromium-review.googlesource.com/961264
> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543425}

TBR=tdresser@chromium.org,sahel@chromium.org

Change-Id: I3c5253d96d011c9723063effac91c969ee352305
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820979, 708499, 757165,  800840 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/963388
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543467}
[modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling
[modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/subpixel-accumulation.html
[rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html
[rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/README.txt
[delete] https://crrev.com/44f923b213a284825b87fd7a8b9dea048c964653/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt
[modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/ui/events/blink/input_handler_proxy.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0842dc1779dae371e2bda39bdbe19c73bcac2f0

commit f0842dc1779dae371e2bda39bdbe19c73bcac2f0
Author: Sahel Sharify <sahel@chromium.org>
Date: Thu Mar 15 21:22:26 2018

Reland "Send GSB before switching to mainthread scrolling in smooth scroll path."

This reverts commit 0a6d89788324987fbad1450b2db6f113129a7130.

Reason for revert: touchpad-scroll-impl-to-main.html is a flaky test
that I changed it in the original cl and removed the tests expectations to see if the flake is fixed or not. Changing the test expectations caused unexpected test failure. In this reland I left the test expectations for touchpad-scroll-impl-to-main.html unchanged.

Original change's description:
> Revert "Send GSB before switching to mainthread scrolling in smooth scroll path."
>
> This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e.
>
> Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see  issue 822386 
>
> bug:  822386 
>
> Original change's description:
> > Send GSB before switching to mainthread scrolling in smooth scroll path.
> >
> > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling
> > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread
> > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original
> > GSB was handled on the compositor rather than being sent to the main thread.
> >
> > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main
> > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling
> > in this cl I've moved the test to a new virtual test suite that has default scroll animation
> > value.
> >
> > I have removed the test expectations since I have changed the test and this might fix the flake.
> >
> > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to
> > a new test suite.
> >
> > Bug: 820979, 708499, 757165,  800840 
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0
> > Reviewed-on: https://chromium-review.googlesource.com/961264
> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
> > Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#543425}
>
> TBR=tdresser@chromium.org,sahel@chromium.org
>
> Change-Id: I3c5253d96d011c9723063effac91c969ee352305
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 820979, 708499, 757165,  800840 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/963388
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543467}

TBR=tdresser@chromium.org,crouleau@chromium.org

Change-Id: I460ff89a12c94772564c77418f2c1e58c72314a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820979, 708499, 757165,  800840 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/964809
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543498}
[modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling
[modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html
[rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html
[copy] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt
[rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt
[modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/ui/events/blink/input_handler_proxy.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 3 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b

commit dfc61b12139e0a086e7e24994c7ef10a98b1aa2b
Author: Sahel Sharify <sahel@chromium.org>
Date: Tue Apr 03 15:56:43 2018

Reland "Send GSB before switching to mainthread scrolling in smooth scroll path."

This reverts commit 0a6d89788324987fbad1450b2db6f113129a7130.

Reason for revert: touchpad-scroll-impl-to-main.html is a flaky test
that I changed it in the original cl and removed the tests expectations to see if the flake is fixed or not. Changing the test expectations caused unexpected test failure. In this reland I left the test expectations for touchpad-scroll-impl-to-main.html unchanged.

Original change's description:
> Revert "Send GSB before switching to mainthread scrolling in smooth scroll path."
>
> This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e.
>
> Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see  issue 822386 
>
> bug:  822386 
>
> Original change's description:
> > Send GSB before switching to mainthread scrolling in smooth scroll path.
> >
> > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling
> > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread
> > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original
> > GSB was handled on the compositor rather than being sent to the main thread.
> >
> > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main
> > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling
> > in this cl I've moved the test to a new virtual test suite that has default scroll animation
> > value.
> >
> > I have removed the test expectations since I have changed the test and this might fix the flake.
> >
> > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to
> > a new test suite.
> >
> > Bug: 820979, 708499, 757165,  800840 
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0
> > Reviewed-on: https://chromium-review.googlesource.com/961264
> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
> > Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#543425}
>
> TBR=tdresser@chromium.org,sahel@chromium.org
>
> Change-Id: I3c5253d96d011c9723063effac91c969ee352305
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 820979, 708499, 757165,  800840 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/963388
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543467}

TBR=tdresser@chromium.org,crouleau@chromium.org

Change-Id: I460ff89a12c94772564c77418f2c1e58c72314a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820979, 708499, 757165,  800840 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/964809
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#543498}(cherry picked from commit f0842dc1779dae371e2bda39bdbe19c73bcac2f0)
Reviewed-on: https://chromium-review.googlesource.com/992852
Cr-Commit-Position: refs/branch-heads/3359@{#551}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling
[modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html
[rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html
[copy] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt
[rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt
[modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/ui/events/blink/input_handler_proxy.cc

Sign in to add a comment