New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708487 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

TracingBrowserTest.TestBackgroundMemoryInfra is very flaky on mac asan

Project Member Reported by maxmorin@chromium.org, Apr 5 2017

Issue description

See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TracingBrowserTest.

Logs looks like
TracingBrowserTest.TestBackgroundMemoryInfra (run #1):
[ RUN      ] TracingBrowserTest.TestBackgroundMemoryInfra
[31426:52739:0405/031640.620507:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.p1WNHt/dS6agGw/Default/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[31426:52739:0405/031640.773818:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.p1WNHt/dS6agGw/Default/Favicons': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[31437:3335:0405/031641.184115:WARNING:vt_video_decode_accelerator_mac.cc(178)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973)
[31437:3335:0405/031641.186156:WARNING:vt_video_decode_accelerator_mac.cc(200)] Failed to create hardware VideoToolbox session
[31437:3335:0405/031641.350221:ERROR:vt_video_encode_accelerator_mac.cc(495)]  VTCompressionSessionCreate failed: -12908
../../chrome/test/base/tracing_browsertest.cc:36: Failure
Value of: success
  Actual: false
Expected: true
[31426:7175:0405/031646.889652:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.

Primiano: Do you know who could have a look at this?
 
Components: Speed>Tracing Tests>Flaky
Cc: primiano@chromium.org
Owner: ssid@chromium.org
ssid can you take a look, IIRC you refactored the bg tracing recently?
Labels: Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a731dee06622f7ed04bf0335ec98ed2189570a

commit 65a731dee06622f7ed04bf0335ec98ed2189570a
Author: maxmorin <maxmorin@chromium.org>
Date: Wed Apr 05 12:47:16 2017

Disable flaky TracingBrowserTest.TestBackgroundMemoryInfra on mac/asan.

BUG=708487
TBR=primiano@chromium.org

Review-Url: https://codereview.chromium.org/2799613002
Cr-Commit-Position: refs/heads/master@{#462042}

[modify] https://crrev.com/65a731dee06622f7ed04bf0335ec98ed2189570a/chrome/test/base/tracing_browsertest.cc

Labels: -Sheriff-Chromium

Comment 6 by ssid@chromium.org, Apr 5 2017

Cc: hjd@chromium.org
The failure seems to be because of memory dump not succeeding. It is likely the refactoring that is happening for UMA or servicification. We should add more logs to why a dump failed.

Comment 7 by ssid@chromium.org, Apr 12 2017

I just realized we have VLOG(1) messages on all possible places which can cause a failure in global dump. But, the test does not output any of these messagees. Should we change VLOG(1) to DLOG(INFO)?
> Should we change VLOG(1) to DLOG(INFO)?
That would make the tests too spammy (unless the proposal was doing that just for few days to collect data).

Q: is't this the same root cause of what chiniforooshan found in Issue 709524? see comments #10-#11 there.
Status: Assigned (was: Untriaged)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a1f2e12b5ba7d4702f06efbec6722a775786687

commit 7a1f2e12b5ba7d4702f06efbec6722a775786687
Author: calamity <calamity@chromium.org>
Date: Mon Jul 10 08:31:01 2017

Disable flaky TracingBrowserTest.TestMemoryInfra on mac/asan.

BUG=708487
TBR=primiano@chromium.org

Review-Url: https://codereview.chromium.org/2975743002
Cr-Commit-Position: refs/heads/master@{#485201}

[modify] https://crrev.com/7a1f2e12b5ba7d4702f06efbec6722a775786687/chrome/test/base/tracing_browsertest.cc

Comment 11 by mark@chromium.org, Jul 12 2017

This seems flaky on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1) as well. It failed there in builds 61521 and 61524. I’m disabling it everywhere.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d325a838d276fc9f593b2c2167649b52ae9a050a

commit d325a838d276fc9f593b2c2167649b52ae9a050a
Author: Mark Mentovai <mark@chromium.org>
Date: Wed Jul 12 18:15:14 2017

Disable browser_tests TracingBrowserTest.Test{Background,}MemoryInfra

This was previously disabled for macOS with AddressSanitizer in
7a1f2e12b5ba, but has shown itself to be flaky on
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)
as well, so it should be disabled everywhere.

Bug: 708487
Change-Id: Idd3382b0a0bb6396a608f3c3f896a26c6fc8f6b8
TBR: primiano@chromium.org
NoTry: true
NoPresubmit: true
Reviewed-on: https://chromium-review.googlesource.com/568376
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486026}
[modify] https://crrev.com/d325a838d276fc9f593b2c2167649b52ae9a050a/chrome/test/base/tracing_browsertest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3f624bd0e196abcec3e29c18c353b7c6724fc87

commit b3f624bd0e196abcec3e29c18c353b7c6724fc87
Author: Siddhartha <ssid@chromium.org>
Date: Wed Aug 30 01:14:53 2017

Enable Memory-infra tracing browser tests

The tests were disabled due to the dumps failing because of requesting
dumps before tracing is enabled in renderers. The fix is blocked on
tracing servicification work. Meanwhile enable the tests without check
for dump success to ensure tracing does not crash.
Also do not fail process dump if MDM is not initialized.
Fix test memory dump configs to not include default categories.

BUG=708487, 709524
TBR=primiano@chromium.org

Change-Id: Ib5f4f69c76bdba889828ab8b2907fd03b770d7fe
Reviewed-on: https://chromium-review.googlesource.com/634485
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498328}
[modify] https://crrev.com/b3f624bd0e196abcec3e29c18c353b7c6724fc87/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/b3f624bd0e196abcec3e29c18c353b7c6724fc87/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/b3f624bd0e196abcec3e29c18c353b7c6724fc87/base/trace_event/trace_config_memory_test_util.h
[modify] https://crrev.com/b3f624bd0e196abcec3e29c18c353b7c6724fc87/chrome/test/BUILD.gn
[rename] https://crrev.com/b3f624bd0e196abcec3e29c18c353b7c6724fc87/chrome/test/base/memory_tracing_browsertest.cc
[modify] https://crrev.com/b3f624bd0e196abcec3e29c18c353b7c6724fc87/content/browser/tracing/memory_tracing_browsertest.cc

Sign in to add a comment