Create a private API for controlling AEC3 |
|||||||
Issue descriptionThis is a tracking bug for adding a new feature to the WebRTC private API. The API should be a generic way of toggling various experiments on or off, and is motivated by the current need to control the new WebRTC echo canceller (AEC3).
,
Apr 5 2017
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/77492860a9d332079fc887740d3254ed0fdcb543 commit 77492860a9d332079fc887740d3254ed0fdcb543 Author: henrik.lundin <henrik.lundin@webrtc.org> Date: Fri Apr 07 06:28:09 2017 Make AudioProcessing::GetConfig() pure virtual BUG= chromium:708475 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.webrtc.org/2796223004 Cr-Commit-Position: refs/heads/master@{#17581} [modify] https://crrev.com/77492860a9d332079fc887740d3254ed0fdcb543/webrtc/modules/audio_processing/include/audio_processing.cc [modify] https://crrev.com/77492860a9d332079fc887740d3254ed0fdcb543/webrtc/modules/audio_processing/include/audio_processing.h
,
Apr 10 2017
,
Apr 11 2017
,
Apr 27 2017
This work is done with https://chromium.googlesource.com/chromium/src/+/95829c0d06a5bcfb677bfd1d65799a43ddae4f46 (https://codereview.chromium.org/2801853005). That CL did not get posted to this bug, for reasons unknown.
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66e6a51773c74189058e55c8b7e63353b4f469f8 commit 66e6a51773c74189058e55c8b7e63353b4f469f8 Author: hlundin <hlundin@chromium.org> Date: Thu Jun 22 15:06:48 2017 WebrtcAudioPrivateSetAudioExperimentsFunction dummy implementation This change introduces a dummy implementation of WebrtcAudioPrivateSetAudioExperimentsFunction::RunAsync() which is invoked when Chrome is build without support for WebRTC (enable_webrtc=false). BUG= 730019 , 708475 Review-Url: https://codereview.chromium.org/2949563002 Cr-Commit-Position: refs/heads/master@{#481532} [modify] https://crrev.com/66e6a51773c74189058e55c8b7e63353b4f469f8/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
,
Jul 5 2017
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7933c57f94e3cedbfdbda3e61b55ede90ef2dac5 commit 7933c57f94e3cedbfdbda3e61b55ede90ef2dac5 Author: hlundin <hlundin@chromium.org> Date: Fri Jul 07 15:22:30 2017 Cache the override for WebRTC's AEC3 in RenderProcessHostImpl If setAudioExperiments is called before the audio track has been created, the value of the AEC3 experiment state should be chached and later used when a track is created. BUG= 708475 , 739379 Review-Url: https://codereview.chromium.org/2973643002 Cr-Commit-Position: refs/heads/master@{#484932} [modify] https://crrev.com/7933c57f94e3cedbfdbda3e61b55ede90ef2dac5/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/7933c57f94e3cedbfdbda3e61b55ede90ef2dac5/content/browser/renderer_host/render_process_host_impl.h
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a897318436de09adc6b966fe343996d6abd3c702 commit a897318436de09adc6b966fe343996d6abd3c702 Author: henrika <henrika@chromium.org> Date: Tue Jul 11 11:16:51 2017 Cache the override for WebRTC's AEC3 in RenderProcessHostImpl If setAudioExperiments is called before the audio track has been created, the value of the AEC3 experiment state should be chached and later used when a track is created. BUG= 708475 , 739379 TBR=hlundin@chromium.org (cherry picked from commit 7933c57f94e3cedbfdbda3e61b55ede90ef2dac5) Review-Url: https://codereview.chromium.org/2973643002 Cr-Original-Commit-Position: refs/heads/master@{#484932} Change-Id: Ia806f1c9f829549b39759bcacdc0c7cf13642bee Reviewed-on: https://chromium-review.googlesource.com/566998 Reviewed-by: Henrik Andreasson <henrika@webrtc.org> Cr-Commit-Position: refs/branch-heads/3112@{#581} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/a897318436de09adc6b966fe343996d6abd3c702/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/a897318436de09adc6b966fe343996d6abd3c702/content/browser/renderer_host/render_process_host_impl.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 5 2017