Issue metadata
Sign in to add a comment
|
Crash in cricket::TurnRefreshRequest::OnErrorResponse(cricket::StunMessage *
Reported by
sa.yunc...@gmail.com,
Apr 5 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.75 Safari/537.36 Steps to reproduce the problem: 1.start setInterval with scope.$apply() 2. 3. What is the expected behavior? as we know it doesn't occurs on canary. Want to be fixed and investigate the issue What went wrong? Aw snap error occurs rarely in users of the application with webRTC and angular js Did this work before? Yes 55.0.2883.75 Chrome version: 56.0.2924.87 Channel: stable OS Version: 10.0 Flash Version:
,
Apr 5 2017
,
Apr 6 2017
We have a large audience. Users report bug from chrome 57.0.2987.133v May be you need some additional information? We attach dump crach file and debug logs. Thank great.
,
Apr 6 2017
Reproduction stems are not accurate
,
Apr 6 2017
sa.yunchic@ could you please provide us a sample Html file to triage the issue further from TE end. Thanks.
,
Apr 6 2017
i was try to reproduce the issue. But unsuccessfully, find only one solution: change code in debugger (setInterval with scope.apply() with 0 delay) and save code in debugger mode. May be it is not the same like our issue. Without debugger it is not reproduced fast. Sorry for that report. But it is very critical for us. Thanks great
,
Apr 6 2017
Thank you for providing more feedback. Adding requester "sureshkumari@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 7 2017
Hello dear developers. This issue reproduced on canary too!
,
Apr 10 2017
,
Apr 12 2017
sa.yunchic@gmail.com, in order to investigate this further please provide: - IDs of associated crashers (see chrome://crashes/) - a sample page/URL
,
Apr 12 2017
Could you please provide email, in order for us to provide a grids to our application. We are very grateful to you. Thank you very match.
,
Apr 12 2017
Thank you for providing more feedback. Adding requester "hablich@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 12 2017
grids(credentials)
,
Apr 13 2017
Hello dear developers! This is few crash reports. Thank you very much! Crash ID bec46891-b491-4fab-a9e8-49fffe4990b6 (Server ID: 334403de10000000) Crash report captured on Monday, April 10, 2017 at 4:53:51 PM, uploaded on Wednesday, April 12, 2017 at 9:30:23 AM Crash ID cd84565f-1a4d-4338-8b1e-48fd4f068d05 (Server ID: adc0134050000000) Crash report captured on Monday, April 3, 2017 at 10:53:12 AM, uploaded on Wednesday, April 12, 2017 at 9:30:27 AM Crash ID b74f1515-1f67-4fc3-aa90-ab6bfc67d1fb (Server ID: e841de2110000000) Crash ID 1f9f34d1-e6f7-415b-8637-85f55a5d8bb9 (Server ID: 74835d4850000000)
,
Apr 19 2017
Thanks sa.yunchic. These reports say that this is not a problem with JavaScript but indicate that is has something to do with the network stack: (chrome_child.dll -turnport.cc:1296 ) cricket::TurnRefreshRequest::OnErrorResponse(cricket::StunMessage * I moving it into a better bucket.
,
Apr 19 2017
,
Apr 19 2017
Thank you very much!
,
Apr 20 2017
Would it be possible to please raise the priority for this issue? This is having a major negative impact on our product since it cause the Chrome tab to crash when the users are in the middle of a WebRTC conference call. Here is another crash ID if it helps. Crash ID ac913843-eb05-4ccb-a569-b42825c93806 (Server ID: fb3046c850000000)
,
Apr 24 2017
I can confirm the crashes in WebRTC sessions. Would be very helpful if you could fix this issue.
,
Apr 24 2017
Is it possible to change this ticket's summary to indicate that the "Aw Snap" happens with WebRTC calls since the problem has nothing to do with the fact that the app is written in Angular?
,
Apr 24 2017
Taylor, this looks like a crash in turnport.cc. PTAL when you have time.
,
Apr 25 2017
Based on the stack trace, it looks like this would occur if a TURN server responds with an error, as indicated by the "message type" field, but doesn't include the ERROR-CODE attribute. I can fix the crash, but if this is really what's happening, it seems like a bug with the TURN server.
,
Apr 25 2017
Thank you for the feedback. We are also investigating this issue from the TURN server side to understand how it can be sending an error message without ERROR-CODE. Nonetheless, this should definitely not trigger a crash, so it would be really appreciated if you could also provide a correction for Chrome.
,
Apr 25 2017
Here's my fix: https://codereview.webrtc.org/2837133003/
,
Apr 25 2017
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/996fc6bdb70c5e855fb8eb8fdde29640c028983c commit 996fc6bdb70c5e855fb8eb8fdde29640c028983c Author: deadbeef <deadbeef@webrtc.org> Date: Wed Apr 26 16:21:22 2017 Don't crash if STUN error message is missing ERROR-CODE attribute. This is something a well-behaving STUN server shouldn't do, but we shouldn't crash if it does happen. Also adding helper function for the common operation of extracting just the error code out of a STUN packet. BUG= chromium:708469 Review-Url: https://codereview.webrtc.org/2837133003 Cr-Commit-Position: refs/heads/master@{#17892} [modify] https://crrev.com/996fc6bdb70c5e855fb8eb8fdde29640c028983c/webrtc/p2p/base/port.cc [modify] https://crrev.com/996fc6bdb70c5e855fb8eb8fdde29640c028983c/webrtc/p2p/base/relayport.cc [modify] https://crrev.com/996fc6bdb70c5e855fb8eb8fdde29640c028983c/webrtc/p2p/base/stun.cc [modify] https://crrev.com/996fc6bdb70c5e855fb8eb8fdde29640c028983c/webrtc/p2p/base/stun.h [modify] https://crrev.com/996fc6bdb70c5e855fb8eb8fdde29640c028983c/webrtc/p2p/base/stun_unittest.cc [modify] https://crrev.com/996fc6bdb70c5e855fb8eb8fdde29640c028983c/webrtc/p2p/base/stunport.cc [modify] https://crrev.com/996fc6bdb70c5e855fb8eb8fdde29640c028983c/webrtc/p2p/base/turnport.cc
,
Apr 26 2017
,
Jul 11 2017
Issue 711274 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Apr 5 2017