Issue metadata
Sign in to add a comment
|
Regression: Clicking 'Open appearance settings' from chrome://md-settings/manageAccessibility page scrolls to top of page |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3062.0/9430.1.0 dev-channel Daisy,Peppy and Minnie OS: Chrome OS What steps will reproduce the problem? (1)Launch chrome>> Navigate to chrome://md-settings/manageAccessibility page (2)Click on 'Open appearance settings' option and Observe Expected: Page should naviagte to Appearance section on clicking 'Open appearance settings' option of chrome://md-settings/manageAccessibility page. Actual: Instead unnecessary navigation to network section is seen. This is regression issue as no such unnecessary navigation to network section is not seen in 58.0.3029.40/9334.28.0 Beta channel Daisy. Attaching screen-cast for reference.
,
Apr 6 2017
FWIW, the last boolean parameter (/* removeSearch */ true) was added at https://codereview.chromium.org/2713553004 to fix a different bug. Worth checking if that caused a new problem.
,
Apr 6 2017
I tried setting that to false and it didn't matter; haven't tried a revert or bisect. The bug appears in 59.0.3054.0, so about 10 days back at least.
,
Apr 10 2017
I can confirm this is a bug.
,
Apr 10 2017
Bisected to https://chromium.googlesource.com/chromium/src/+/cd286e8aba904530c17eeafbd626769822c8a746 I have also confirmed that reverting that patch fixes the above behavior.
,
Apr 12 2017
It's a bit odd that this subpage navigates to the main page with a subpage row. Also, it's talking about changing the font sizes in the label. Should/could this go to the font settings subpage instead of the top level page? The first image is the page navigating from. The second image is where it was navigating to. The third image is where I'm proposing that it navigate to.
,
Apr 12 2017
If comment #6 and #7 sound good, there is a CL at https://codereview.chromium.org/2812983004/
,
Apr 13 2017
Comments 6, 7, and 8 moved to Issue 711110.
,
Apr 13 2017
CL for scrolling to the Appearance section on the main page at https://codereview.chromium.org/2815163003/
,
Apr 13 2017
Issue 711211 has been merged into this issue.
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70df80adfac5d24b6ade4507b919e05df88ab029 commit 70df80adfac5d24b6ade4507b919e05df88ab029 Author: dschuyler <dschuyler@chromium.org> Date: Thu Apr 13 19:24:48 2017 [MD settings] limit scope of subpage animating attribute This CL reduces the occurrances where isSubpageAnimating is used. We primarily need this hack to fix an issue going between subpages, but we had broadened it to all animations for good measure. There is an issue transitioning from the a11y subpage to the appearance on the main page that we don't yet have another solution for. Reducing the scope fixes scrolling issue in bug 708465 . BUG= 708465 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2815163003 Cr-Commit-Position: refs/heads/master@{#464500} [modify] https://crrev.com/70df80adfac5d24b6ade4507b919e05df88ab029/chrome/browser/resources/settings/settings_page/main_page_behavior.js
,
Apr 13 2017
,
May 11 2017
9534.0.0, 60.0.3092.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Apr 6 2017Owner: tommycli@chromium.org
Summary: Regression: Clicking 'Open appearance settings' from chrome://md-settings/manageAccessibility page scrolls to top of page (was: Regression: Unnecessary navigation to network section is seen on clicking 'Open appearance settings' option of chrome://md-settings/manageAccessibility page.)