New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708456 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Prevent notification from being closed by timer while it's active

Project Member Reported by yoshiki@chromium.org, Apr 5 2017

Issue description

This is a chromium side issue of b/36801560.

This is solved on ToT, but need to be merged to M58.
 
Labels: Merge-Request-58
Hi, branch master, can I merge the following CL to the M58 branch?
- https://codereview.chromium.org/2788673004/
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 6 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81c8a2325bc0031153204b95ebc7e8cb860d6b4

commit f81c8a2325bc0031153204b95ebc7e8cb860d6b4
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Fri Apr 07 07:56:08 2017

Pause close timer of notification while it's active

This patch makes notifications keeping visible while the focus is in notification. Previously, notification disappeared while user is typing direct reply. This patch solves this issue.

BUG= 708456 
BUG=b/36801560
TEST=manually

Review-Url: https://codereview.chromium.org/2788673004
Cr-Commit-Position: refs/heads/master@{#461637}
(cherry picked from commit d9271fbbafb0fcc5e104d7e397cf3dbb9f9aeda1)

Review-Url: https://codereview.chromium.org/2800923005 .
Cr-Commit-Position: refs/branch-heads/3029@{#622}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/f81c8a2325bc0031153204b95ebc7e8cb860d6b4/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/f81c8a2325bc0031153204b95ebc7e8cb860d6b4/ui/message_center/views/message_popup_collection.h
[modify] https://crrev.com/f81c8a2325bc0031153204b95ebc7e8cb860d6b4/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/f81c8a2325bc0031153204b95ebc7e8cb860d6b4/ui/message_center/views/toast_contents_view.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
on b/36801560.

Sign in to add a comment