This is meta bug to track the issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d966311c415628293f997e32d64a4a3f56ab25ad commit d966311c415628293f997e32d64a4a3f56ab25ad Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Dec 12 00:17:45 2017 [LayoutNG] Implement NG offset conversion and LayoutSelectionStartEndForNG(). This patch is a part of crrev.com/c/813336 ([LayoutNG] Paint text selection on load.) LayoutSelection.cpp: - This converts legacy offset to NG offset if LayoutObject has enclosing NGBlockFlowlayout before paint phase. - LayoutSelectionStartEndForNG() returns start/end offsets that the NGPhysicalTextFragment is selected. LayoutSelectionTest.cpp: - This patch adds NGLayoutSelectionTest to confirm/demonstrate how we use the function. Also you can refer my following painting patch(crrev.com/c/818884). Bug: 708452 Change-Id: Ic9fc6822f83e0821c5f2f4917d4ac316543702e2 Reviewed-on: https://chromium-review.googlesource.com/818864 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#523263} [modify] https://crrev.com/d966311c415628293f997e32d64a4a3f56ab25ad/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/d966311c415628293f997e32d64a4a3f56ab25ad/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/d966311c415628293f997e32d64a4a3f56ab25ad/third_party/WebKit/Source/core/editing/LayoutSelection.cpp [modify] https://crrev.com/d966311c415628293f997e32d64a4a3f56ab25ad/third_party/WebKit/Source/core/editing/LayoutSelection.h [modify] https://crrev.com/d966311c415628293f997e32d64a4a3f56ab25ad/third_party/WebKit/Source/core/editing/LayoutSelectionTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68a3ceba923b0151f7cbeb6c07b43f5a8915d7d0 commit 68a3ceba923b0151f7cbeb6c07b43f5a8915d7d0 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Dec 12 06:08:46 2017 [LayoutNG] Paint text fragment selection on load. This patch is a part of crrev.com/c/813336 ([LayoutNG] Paint text selection on load.) This patch depends on crrev.com/c/818864 (Implement NG offset conversion and LayoutSelectionStartEndForNG()) ng_text_fragment_painter.cc: - This paints selection background and selected text. - PaintSelection() paints selection background. This is copied from InlineTextBoxPainter::PaintSelection() w/o ltr, expanding new line wrap,,, which uses InlineTextBox functions. - NGTextFragmentPainter::Paint paints text partially: Suppose we have "b[a]r" (selected only 'a'), -- 1. Paint 'b' -- 2. Paint white 'a' -- 3. Paint 'r' Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id9001b6fdadda084dae5531a5dfd0725bae293f8 Reviewed-on: https://chromium-review.googlesource.com/818884 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523352} [modify] https://crrev.com/68a3ceba923b0151f7cbeb6c07b43f5a8915d7d0/third_party/WebKit/Source/core/paint/ng/ng_text_fragment_painter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54ea01fa3019561f12f5e3ced1cbe41f76947c86 commit 54ea01fa3019561f12f5e3ced1cbe41f76947c86 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Dec 12 10:00:03 2017 [LayoutNG] Update comment in ng_text_fragment_painter.cc Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iafc4c16aac974aa50bbd79960179ba17a3dff7cb Reviewed-on: https://chromium-review.googlesource.com/821337 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#523387} [modify] https://crrev.com/54ea01fa3019561f12f5e3ced1cbe41f76947c86/third_party/WebKit/Source/core/paint/ng/ng_text_fragment_painter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba08b886d089a4af973d02b96aa7f385c603b5d2 commit ba08b886d089a4af973d02b96aa7f385c603b5d2 Author: Koji Ishii <kojii@chromium.org> Date: Tue Dec 12 23:39:13 2017 [LayoutNG] Add layout_ng try bots for core/paint/ng and FlagExpectations This patch adds layout_ng try bots for following directories: - Source/core/paint/ng - LayoutTests/FlagExpectations/enable-blink-features=LayoutNG - LayoutTests/flag-specific/enable-blink-features=LayoutNG in the same way as slimming-paint does. Bug: 591099, 708452 Change-Id: I1d4f5d0655794837f6292f0030862cece6db4f55 Reviewed-on: https://chromium-review.googlesource.com/822553 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523604} [modify] https://crrev.com/ba08b886d089a4af973d02b96aa7f385c603b5d2/third_party/WebKit/PRESUBMIT.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89ae89fb0062ebb3d7944bdb8814d87e9169b23c commit 89ae89fb0062ebb3d7944bdb8814d87e9169b23c Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Dec 14 05:31:18 2017 [LayoutNG] Paint RTL text selection. Since this patch, we use ShapeResult.Direction() to get appropriate CharacterRange to paint RTL text such as: <div id="d1">אבג</div> <script> getSelection().setBaseAndExtent(d1.firstChild, 0, d1.firstChild, 1); </script> Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id858f508c41b7231e73b25ef11933f88b2b2993e Reviewed-on: https://chromium-review.googlesource.com/821797 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524009} [modify] https://crrev.com/89ae89fb0062ebb3d7944bdb8814d87e9169b23c/third_party/WebKit/Source/core/paint/ng/ng_text_fragment_painter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cf79da9eef971c4638376e49a5f2bbf90905bed commit 8cf79da9eef971c4638376e49a5f2bbf90905bed Author: Yoichi Osato <yoichio@chromium.org> Date: Mon Jan 15 08:57:53 2018 [LayoutNG] Have LayoutText invalidating NGPaintFragments We invalidate DisplayItemClients corresponding LayoutText through InlineTextBox but we need to invalidate NGPaintFragments on NG. This patch introduces such invalidation for Selection in ObjectPaintInvalidater. This fixes 34 crashes on FlagExpectations/enable-blink-features=LayoutNG. Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id2430f9a238d892b13131a599e7a91ce84e75cbb Reviewed-on: https://chromium-review.googlesource.com/821394 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#529230} [modify] https://crrev.com/8cf79da9eef971c4638376e49a5f2bbf90905bed/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/8cf79da9eef971c4638376e49a5f2bbf90905bed/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp [modify] https://crrev.com/8cf79da9eef971c4638376e49a5f2bbf90905bed/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h [modify] https://crrev.com/8cf79da9eef971c4638376e49a5f2bbf90905bed/third_party/WebKit/Source/core/layout/LayoutInline.cpp [modify] https://crrev.com/8cf79da9eef971c4638376e49a5f2bbf90905bed/third_party/WebKit/Source/core/layout/LayoutText.cpp [modify] https://crrev.com/8cf79da9eef971c4638376e49a5f2bbf90905bed/third_party/WebKit/Source/core/layout/ng/layout_ng_mixin.cc [modify] https://crrev.com/8cf79da9eef971c4638376e49a5f2bbf90905bed/third_party/WebKit/Source/core/layout/ng/layout_ng_mixin.h [modify] https://crrev.com/8cf79da9eef971c4638376e49a5f2bbf90905bed/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b13aa2ae0f04d37bfa13775183ccdb0c5a274d9c commit b13aa2ae0f04d37bfa13775183ccdb0c5a274d9c Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jan 31 02:37:17 2018 [LayoutNG] Mark LayoutSelection::LayoutSelectionStartEndForNG const. This patch marks LayoutSelection::LayoutSelectionStartEndForNG and FrameSelection::LayoutSelectionStartEndForNG const because of the function constness. Bug: 708452 Change-Id: I462fa178a9c656f184f43aac62eedff552290219 Reviewed-on: https://chromium-review.googlesource.com/892943 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533171} [modify] https://crrev.com/b13aa2ae0f04d37bfa13775183ccdb0c5a274d9c/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/b13aa2ae0f04d37bfa13775183ccdb0c5a274d9c/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/b13aa2ae0f04d37bfa13775183ccdb0c5a274d9c/third_party/WebKit/Source/core/editing/LayoutSelection.cpp [modify] https://crrev.com/b13aa2ae0f04d37bfa13775183ccdb0c5a274d9c/third_party/WebKit/Source/core/editing/LayoutSelection.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff0336d30ba8b2040331cc42cd1c22ab460d0f3a commit ff0336d30ba8b2040331cc42cd1c22ab460d0f3a Author: Yoichi Osato <yoichio@chromium.org> Date: Fri Feb 02 06:44:33 2018 [LayoutNG] Invalidate block flow rect for each PaintFragment On SlimmingPaintV175, we should point LayoutRect to invalidate with DisplayItem::PartialInvalidationRect() virtual function but PaintFragment didn't override it. This patch implements the override that returns visual rect of including NGBlockFlow. This patch reduces 7 image failures of selection in NG. Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9342e72791e4a8eec533081fb5da2f6d16c3d4b2 Reviewed-on: https://chromium-review.googlesource.com/897303 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#533980} [modify] https://crrev.com/ff0336d30ba8b2040331cc42cd1c22ab460d0f3a/third_party/WebKit/Source/core/paint/ng/ng_paint_fragment.cc [modify] https://crrev.com/ff0336d30ba8b2040331cc42cd1c22ab460d0f3a/third_party/WebKit/Source/core/paint/ng/ng_paint_fragment.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85aaee327912d336e3dd11403c5c10fe944878ea commit 85aaee327912d336e3dd11403c5c10fe944878ea Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Apr 26 09:29:49 2018 [LayoutNG] Update LayoutSelectionStartEndForNG signature This patch updates LayoutSelectionStartEndForNG signature by 1. Introducing LayoutSelectionStatus structure for return type consisting of start/end. 2. Change argument type from NGPhysicalTextFragment to NGPaintFragment. This is a preparation for line break selection painting: crbug.com/c/896780 Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idca785e841a577b1a591ae10cf3d9771d21c6ce1 Reviewed-on: https://chromium-review.googlesource.com/1029563 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553962} [modify] https://crrev.com/85aaee327912d336e3dd11403c5c10fe944878ea/third_party/blink/renderer/core/editing/frame_selection.cc [modify] https://crrev.com/85aaee327912d336e3dd11403c5c10fe944878ea/third_party/blink/renderer/core/editing/frame_selection.h [modify] https://crrev.com/85aaee327912d336e3dd11403c5c10fe944878ea/third_party/blink/renderer/core/editing/layout_selection.cc [modify] https://crrev.com/85aaee327912d336e3dd11403c5c10fe944878ea/third_party/blink/renderer/core/editing/layout_selection.h [modify] https://crrev.com/85aaee327912d336e3dd11403c5c10fe944878ea/third_party/blink/renderer/core/editing/layout_selection_test.cc [modify] https://crrev.com/85aaee327912d336e3dd11403c5c10fe944878ea/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7508ecbfe46e265cb227541978cbf102bfe33c7 commit c7508ecbfe46e265cb227541978cbf102bfe33c7 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue May 15 04:51:01 2018 [LayoutNG] Paint selection line break. This patch implements painting selection line break. Design doc: https://goo.gl/ovMr8x This patch changes LayoutSelection::SelectionStartEndForNG( text_fragment) to return LayoutSelectionStatus which has selection |start|,|end| and new boolean member |has_line_break|, which means we need expand selection rect of the fragment to paint line break. The caller NGTextFragmentPainter paints line break selection by extending existing selection rect when selection wraps line. This patch fixes 4 selection painting test. Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idef2d7135a5d7f27a217365cc3e8d55b191fa60b Reviewed-on: https://chromium-review.googlesource.com/896780 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#558614} [modify] https://crrev.com/c7508ecbfe46e265cb227541978cbf102bfe33c7/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/c7508ecbfe46e265cb227541978cbf102bfe33c7/third_party/blink/renderer/core/editing/frame_selection.h [modify] https://crrev.com/c7508ecbfe46e265cb227541978cbf102bfe33c7/third_party/blink/renderer/core/editing/layout_selection.cc [modify] https://crrev.com/c7508ecbfe46e265cb227541978cbf102bfe33c7/third_party/blink/renderer/core/editing/layout_selection_test.cc [modify] https://crrev.com/c7508ecbfe46e265cb227541978cbf102bfe33c7/third_party/blink/renderer/core/layout/ng/inline/ng_physical_line_box_fragment.cc [modify] https://crrev.com/c7508ecbfe46e265cb227541978cbf102bfe33c7/third_party/blink/renderer/core/layout/ng/inline/ng_physical_line_box_fragment.h [modify] https://crrev.com/c7508ecbfe46e265cb227541978cbf102bfe33c7/third_party/blink/renderer/core/layout/ng/inline/ng_physical_line_box_fragment_test.cc [modify] https://crrev.com/c7508ecbfe46e265cb227541978cbf102bfe33c7/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf commit a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf Author: Yoichi Osato <yoichio@chromium.org> Date: Wed May 23 08:27:30 2018 [LayoutNG] Rebaseline image failure about line gap selection. At the discussion on the painting line gap patch, we decided not to paint selection gap: https://chromium-review.googlesource.com/c/chromium/src/+/989519/7/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc#120 This patch rebaselines image failures not painting such selection following the decision. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idb2452d50da896081265a6b9628912c92c60d6f4 Reviewed-on: https://chromium-review.googlesource.com/1068577 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#561003} [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/line-wrap-2-expected.png [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/selection-button-text-expected.png [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/selection-button-text-expected.txt [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/transformed-selection-rects-expected.png [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/fast/overflow/image-selection-highlight-expected.png [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/fast/text/selection/flexbox-selection-expected.png [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/selection-highlight-adjust-expected.png [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/selection-highlight-adjust-expected.txt [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/overflow/image-selection-highlight-expected.png [add] https://crrev.com/a5e08f9630c1b5d3a144a6a762d141f2b9e4dddf/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/flexbox-selection-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e22bb5db740545858fab6fc9b92b37b8e187a73 commit 6e22bb5db740545858fab6fc9b92b37b8e187a73 Author: Yoichi Osato <yoichio@chromium.org> Date: Mon May 28 09:10:54 2018 [LayoutNG] Rebaseline image failure about line gap selection. At the discussion on the painting line gap patch, we decided not to paint selection gap: https://chromium-review.googlesource.com/c/chromium/src/+/989519/7/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc#120 This patch rebaselines image failures not painting such selection following the decision. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icab156abb120b06264053890367bc899e02ffdf2 Reviewed-on: https://chromium-review.googlesource.com/1074510 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#562214} [add] https://crrev.com/6e22bb5db740545858fab6fc9b92b37b8e187a73/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/selection-repaint-with-gaps-expected.png [add] https://crrev.com/6e22bb5db740545858fab6fc9b92b37b8e187a73/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/selection-repaint-with-gaps-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7db58841abd2ff10d09a479ecd2b45feb1c4079 commit b7db58841abd2ff10d09a479ecd2b45feb1c4079 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue May 29 03:20:43 2018 [LayoutNG] Rebaseline image failure about block end selection. At the discussion on the line break patch, we decided not to paint block end line break selection: https://chromium-review.googlesource.com/c/chromium/src/+/896780/36/third_party/blink/renderer/core/editing/layout_selection.cc#649 This patch rebaselines image failures not painting block end line break selection following the decision. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie30af1328f66e59759862e1fb2a359682bb60418 Reviewed-on: https://chromium-review.googlesource.com/1074669 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#562318} [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/invalidation-rect-includes-newline-expected.png [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/invalidation-rect-includes-newline-expected.txt [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/invalidation-rect-includes-newline-for-rtl-expected.png [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/invalidation-rect-includes-newline-for-rtl-expected.txt [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/markers-in-selection-expected.png [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/text-selection-newline-across-blocks-expected.png [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/text-selection-newline-br-expected.png [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/text-selection-newline-br-expected.txt [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/text-selection-newline-span-across-line-expected.png [add] https://crrev.com/b7db58841abd2ff10d09a479ecd2b45feb1c4079/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/text-selection-newline-span-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98fe9fd252710d87f6f2c67fcee432aae4fd8501 commit 98fe9fd252710d87f6f2c67fcee432aae4fd8501 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue May 29 09:50:56 2018 [LayoutNG] Paint vertical text selection This patch enables to paint selection vertically on writing-mode:vertical-lr/rl style. Since paint_fragment.ComputeLocalSelectionRect() returns physical coordinate rect rather than logical, this patch delays GraphicsContext flip after selection painting. This patch fixes following tests leaving line gap paint: fast/writing-mode/japanese-lr-selection.html fast/writing-mode/japanese-rl-selection.html Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I626e3e532a49928065de1bc2ea5478a72c867638 Reviewed-on: https://chromium-review.googlesource.com/1071497 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#562379} [modify] https://crrev.com/98fe9fd252710d87f6f2c67fcee432aae4fd8501/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-vertical-rl-expected.png [modify] https://crrev.com/98fe9fd252710d87f6f2c67fcee432aae4fd8501/third_party/blink/renderer/core/layout/layout_text_test.cc [modify] https://crrev.com/98fe9fd252710d87f6f2c67fcee432aae4fd8501/third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc [modify] https://crrev.com/98fe9fd252710d87f6f2c67fcee432aae4fd8501/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4739c922151d919d6d1a3cf3702b348beb11d91a commit 4739c922151d919d6d1a3cf3702b348beb11d91a Author: Yoichi Osato <yoichio@chromium.org> Date: Wed May 30 08:44:38 2018 [LayoutNG] Fix expected images path This patch moves expected images to each correct path. The images were introduced at crrev.com/c/1074669 Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If8ccb06f52c4fb4b4db5073ec33da3cc5fbd6d71 Reviewed-on: https://chromium-review.googlesource.com/1077911 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#562765} [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/lists/markers-in-selection-expected.png [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-includes-newline-expected.png [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.png [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-across-blocks-expected.png [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-br-expected.png [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-br-expected.txt [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-span-across-line-expected.png [rename] https://crrev.com/4739c922151d919d6d1a3cf3702b348beb11d91a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-span-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8979ab37ae740192a58ca12aafe35997115b4a2 commit e8979ab37ae740192a58ca12aafe35997115b4a2 Author: Yoichi Osato <yoichio@chromium.org> Date: Fri Jun 01 06:27:30 2018 [LayoutNG] Rebaseline image failure about block end selection. At the discussion on the line break patch, we decided not to paint block end line break selection: https://chromium-review.googlesource.com/c/chromium/src/+/896780/36/third_party/blink/renderer/core/editing/layout_selection.cc#649 This patch rebaselines image failures not painting block end line break selection following the decision. Bug: 708452 TEST: paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr.html paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl.html paint/invalidation/selection/invalidation-rect-with-br-includes-newline.html paint/selection/text-selection-newline-vertical-lr.html Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icdef2eff8e12c13d532ad6897111b94db2d9a305 Reviewed-on: https://chromium-review.googlesource.com/1080356 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#563551} [add] https://crrev.com/e8979ab37ae740192a58ca12aafe35997115b4a2/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.png [add] https://crrev.com/e8979ab37ae740192a58ca12aafe35997115b4a2/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt [add] https://crrev.com/e8979ab37ae740192a58ca12aafe35997115b4a2/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.png [add] https://crrev.com/e8979ab37ae740192a58ca12aafe35997115b4a2/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt [add] https://crrev.com/e8979ab37ae740192a58ca12aafe35997115b4a2/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.png [add] https://crrev.com/e8979ab37ae740192a58ca12aafe35997115b4a2/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [add] https://crrev.com/e8979ab37ae740192a58ca12aafe35997115b4a2/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-vertical-lr-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6949b55c622141ba727436658998429e92b8ef3d commit 6949b55c622141ba727436658998429e92b8ef3d Author: Yoichi Osato <yoichio@chromium.org> Date: Mon Jun 04 08:49:16 2018 [LayoutNG] Fill selection paint line gap. This patch changes NGPhysicalTextFragment selection painting rect by expanding its top and height to the line height so that we paint selection filling line gap. There are 2 difference between this patch and old: #1: On old layout, we extends selection height to each pinching RootInlineBox.SelectionTop()/ SelectionBottom() if each of them exists but we simply extends the height to containing NGPhysicalContainerFragment height on NG. This paints differently if we select multiple lines: NG paints more 'fat' than old: NG: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/6045/layout-test-results/editing/selection/inline-closest-leaf-child-actual.png Old: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/6045/layout-test-results/editing/selection/inline-closest-leaf-child-expected.png #2: Since old selection compute height by InlineBox::LogicalHeight(), which depends font height and on many cases NGPhysicalContainerFragment has 1px wider height, we need rebaseline: NG: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/6045/layout-test-results/editing/execCommand/findString-2-actual.png Old: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/6045/layout-test-results/editing/execCommand/findString-2-expected.png Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0ac37c45cc4c1d7d9f5a43ce90fd5d1d641a1026 Reviewed-on: https://chromium-review.googlesource.com/1080442 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#564027} [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/selection-repaint-with-gaps-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/selection-repaint-with-gaps-expected.txt [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/execCommand/findString-2-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/inline-closest-leaf-child-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/line-wrap-1-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/line-wrap-2-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/linux_selection_color-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/range-between-block-and-inline-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/selection-background-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/selection-button-text-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/transformed-selection-rects-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/backgrounds/selection-background-color-of-list-style-expected.png [delete] https://crrev.com/62986f4b5de984b9783829ace49dd8c616ed4ccd/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/fast/overflow/image-selection-highlight-expected.png [delete] https://crrev.com/62986f4b5de984b9783829ace49dd8c616ed4ccd/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/fast/text/selection/flexbox-selection-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/selection-highlight-adjust-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/lists/markers-in-selection-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/overflow/image-selection-highlight-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/reflections/inline-crash-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/selectors/159-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/selectors/177a-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/selectors/selection-window-inactive-expected.html [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/selectors/shadow-host-div-with-span-expected.html [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/selectors/shadow-host-div-with-text-expected.html [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/atsui-kerning-and-ligatures-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/atsui-rtl-override-selection-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/complex-text-rtl-selection-repaint-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/flexbox-selection-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/flexbox-selection-nested-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/justified-selection-at-edge-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/justified-selection-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/khmer-selection-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/selection-multiple-runs-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/selection-painting-hidpi-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/selection-rect-line-height-too-big-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/selection-rect-line-height-too-small-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/shaping-selection-rect-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/should-use-atsui-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-clipped-by-overflow-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.png [add] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/text/foreignObject-text-clipping-bug-expected.png [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/blink/renderer/core/layout/layout_text_test.cc [modify] https://crrev.com/6949b55c622141ba727436658998429e92b8ef3d/third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd33f23dab2f6ff0b84d792b277b279e79f82c2a commit cd33f23dab2f6ff0b84d792b277b279e79f82c2a Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jun 06 08:29:25 2018 Make editing/selection/modify_move/move-forward-after-line-break.html contenteditable This patch make the layout test contenteditable to reduce NG failure. Bug: 679977, 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iafc1d315fe9b3b88b66bf68a46939c98bda25409 Reviewed-on: https://chromium-review.googlesource.com/1086891 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#564822} [modify] https://crrev.com/cd33f23dab2f6ff0b84d792b277b279e79f82c2a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/cd33f23dab2f6ff0b84d792b277b279e79f82c2a/third_party/WebKit/LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d32cf308e7a64854608b7e7672740435875753b9 commit d32cf308e7a64854608b7e7672740435875753b9 Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jun 06 08:43:22 2018 [LayoutNG] Rebaseline selection painting expectations around line height This patch rebases image failures that NG paints 1px taller than old. This is by-product but got lgtm at the previous patch: crrev.com/c/1080442 ([LayoutNG] Fill selection paint line gap.) Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I26ab17747655017be2750355ab5c23708398fa40 Reviewed-on: https://chromium-review.googlesource.com/1086671 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564824} [modify] https://crrev.com/d32cf308e7a64854608b7e7672740435875753b9/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [add] https://crrev.com/d32cf308e7a64854608b7e7672740435875753b9/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/4402375-expected.png [add] https://crrev.com/d32cf308e7a64854608b7e7672740435875753b9/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/4402375-expected.txt [add] https://crrev.com/d32cf308e7a64854608b7e7672740435875753b9/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/backgrounds/selection-background-color-of-image-list-style-expected.png [add] https://crrev.com/d32cf308e7a64854608b7e7672740435875753b9/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt [add] https://crrev.com/d32cf308e7a64854608b7e7672740435875753b9/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/writing-mode/japanese-rl-selection-expected.png [add] https://crrev.com/d32cf308e7a64854608b7e7672740435875753b9/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/text/selection-no-clip-text-expected.png [add] https://crrev.com/d32cf308e7a64854608b7e7672740435875753b9/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/text/selection-no-clip-text-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fdbbb3ee8656ae6b4f067aea89b262a93ecb119 commit 5fdbbb3ee8656ae6b4f067aea89b262a93ecb119 Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jun 06 09:54:06 2018 [LayoutNG] Rebase hyphen image failure. This patch rebases editing/selection/paint-hyphen.html image expectation. On NG, we don't paint block end hyphen. That's reasonable because no following word after that. Plus, this follows Edge and Firefox. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I976691f32be99283b526b1daf2dbfbe893fbfd4f Reviewed-on: https://chromium-review.googlesource.com/1088465 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#564840} [add] https://crrev.com/5fdbbb3ee8656ae6b4f067aea89b262a93ecb119/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/paint-hyphen-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71928014cfea7f230d87ae1358008efd83bc3712 commit 71928014cfea7f230d87ae1358008efd83bc3712 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Jun 07 09:42:57 2018 Convert editing/selection/4776665.html to reftest The test confirms no caret painting in contenteditable body inside iframe. This patch converts the test to reftest with no contenteditable body. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ifb49d72e83b64a7eecb9c9d16c1eeab4ad61f3f2 Reviewed-on: https://chromium-review.googlesource.com/1090418 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#565212} [add] https://crrev.com/71928014cfea7f230d87ae1358008efd83bc3712/third_party/WebKit/LayoutTests/editing/selection/4776665-expected.html [modify] https://crrev.com/71928014cfea7f230d87ae1358008efd83bc3712/third_party/WebKit/LayoutTests/editing/selection/4776665.html [delete] https://crrev.com/b437a8d206476ec1e6ca6074440bd004b046d97a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/4776665-expected.png [delete] https://crrev.com/b437a8d206476ec1e6ca6074440bd004b046d97a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/4776665-expected.txt [delete] https://crrev.com/b437a8d206476ec1e6ca6074440bd004b046d97a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/4776665-expected.png [delete] https://crrev.com/b437a8d206476ec1e6ca6074440bd004b046d97a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/4776665-expected.txt [delete] https://crrev.com/b437a8d206476ec1e6ca6074440bd004b046d97a/third_party/WebKit/LayoutTests/platform/win/editing/selection/4776665-expected.png [delete] https://crrev.com/b437a8d206476ec1e6ca6074440bd004b046d97a/third_party/WebKit/LayoutTests/platform/win/editing/selection/4776665-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e847c5474433c30e8112e1f9090796519a454f25 commit e847c5474433c30e8112e1f9090796519a454f25 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Jun 07 10:37:31 2018 Convert editing/pasteboard/copy-paste-pre-line-content.html with selection_test This patch rewrites the layout test with selection_test inside contenteditable. Bug: 679977, 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0003c34020bb54c565d6bd169fd2cffd17c76030 Reviewed-on: https://chromium-review.googlesource.com/1086897 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#565221} [modify] https://crrev.com/e847c5474433c30e8112e1f9090796519a454f25/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [delete] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/WebKit/LayoutTests/editing/pasteboard/copy-paste-pre-line-content-expected.txt [modify] https://crrev.com/e847c5474433c30e8112e1f9090796519a454f25/third_party/WebKit/LayoutTests/editing/pasteboard/copy-paste-pre-line-content.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ff505f7a0d2c8bc76e2ba275095f4714cf8b35a commit 4ff505f7a0d2c8bc76e2ba275095f4714cf8b35a Author: Yoichi Osato <yoichio@chromium.org> Date: Fri Jun 08 05:55:00 2018 Convert editing/selection/extend-inside-transforms-backward.html with selection_test This patch rewrites the layout test with selection_test inside contenteditable. Bug: 679977, 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iff922bbff0dd0835a9e648c32a1ef6b67e404660 Reviewed-on: https://chromium-review.googlesource.com/1086822 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565562} [modify] https://crrev.com/4ff505f7a0d2c8bc76e2ba275095f4714cf8b35a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/editing/selection/extend-inside-transforms-backward.html [modify] https://crrev.com/4ff505f7a0d2c8bc76e2ba275095f4714cf8b35a/third_party/WebKit/LayoutTests/editing/selection/extend-inside-transforms-forward.html [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-inside-transforms-backward-expected.png [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-inside-transforms-forward-expected.png [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/selection/extend-inside-transforms-backward-expected.png [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/selection/extend-inside-transforms-forward-expected.png [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-inside-transforms-backward-expected.png [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-inside-transforms-backward-expected.txt [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-inside-transforms-forward-expected.png [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-inside-transforms-forward-expected.txt [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-inside-transforms-backward-expected.png [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-inside-transforms-backward-expected.txt [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-inside-transforms-forward-expected.png [delete] https://crrev.com/ba18a4b63d68610518fa8f27b7d2482431ab7740/third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-inside-transforms-forward-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6910227ad00dab58cf1c6c1804aa82682a8b5fea commit 6910227ad00dab58cf1c6c1804aa82682a8b5fea Author: Yoichi Osato <yoichio@chromium.org> Date: Sat Jun 09 01:49:20 2018 [LayoutNG] Paint single hard line break. This patch lets NGTextFragmentPainter paint hard line break: BR and \n on white-space:pre, even it is only character in a line or only selected in a line. To implement that, this patch splits existing algorithm to soft line break and hard line break. This patch almost reuse existing code for soft line break and implement new for hard line break: 1. Update LayoutSelection to compute inline offset for BR element. 2. Update NGPaintFragment::ComputeLocalSelectionRect to return space width rect for BR. LayoutNG/fast/text/selection/selection-hard-linebreak-expected.png This rebase is needed only for 1 px gap. Linebreak paint is compatible to old. Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7134b169120c9c152dfc366da3695f1af15e36e4 Reviewed-on: https://chromium-review.googlesource.com/1084573 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#565814} [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [add] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/selection-hard-linebreak-expected.png [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/blink/renderer/core/editing/frame_selection.h [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/blink/renderer/core/editing/layout_selection.cc [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/blink/renderer/core/editing/layout_selection_test.cc [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/blink/renderer/core/layout/layout_text_test.cc [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/blink/renderer/core/layout/ng/inline/ng_physical_line_box_fragment.h [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc [modify] https://crrev.com/6910227ad00dab58cf1c6c1804aa82682a8b5fea/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b62d187cb66ed2a7f4ff6ff06fab87cf81afe50 commit 1b62d187cb66ed2a7f4ff6ff06fab87cf81afe50 Author: Yoichi Osato <yoichio@chromium.org> Date: Mon Jun 11 04:26:37 2018 [LayoutNG] Rebaseline selection painting expectations around line height This patch fixes: fast/text/selection/selection-with-inline-padding.html paint/invalidation/selection/selection-rl.html This patch rebases image failures that NG paints 1px taller than old. This is by-product but got lgtm at the previous patch: crrev.com/c/1080442 ([LayoutNG] Fill selection paint line gap.) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452 Change-Id: Iba5a07531f2cabf70707e6a9dfaed51fdc653e53 Reviewed-on: https://chromium-review.googlesource.com/1092567 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#565924} [add] https://crrev.com/1b62d187cb66ed2a7f4ff6ff06fab87cf81afe50/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/selection-with-inline-padding-expected.png [add] https://crrev.com/1b62d187cb66ed2a7f4ff6ff06fab87cf81afe50/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/selection-rl-expected.png [add] https://crrev.com/1b62d187cb66ed2a7f4ff6ff06fab87cf81afe50/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/selection-rl-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ee731bc0786a1d9520194cdf9934b73fc6ef388 commit 7ee731bc0786a1d9520194cdf9934b73fc6ef388 Author: Yoichi Osato <yoichio@chromium.org> Date: Mon Jun 11 06:59:51 2018 Remove editing/selection/5354455-2.html The test confirms right click on element should create a selection. That was introduced 11 years ago: https://chromium.googlesource.com/chromium/src/+/563113d2b16713e83a7507637a28973c8cf7db82 However, the feature was removed at some point and no platform expects that. Currently the test only confirms right click on element doesn't create selection unlike its description and right click behavior is tested at another tests well, e.g. LayoutTests/editing/selection/context-menu-text-selection.html Then this patch removes the test. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452 Change-Id: I2886aeb05728df9f84bb10ee87e062362f1fd0ce Reviewed-on: https://chromium-review.googlesource.com/1092552 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#565936} [modify] https://crrev.com/7ee731bc0786a1d9520194cdf9934b73fc6ef388/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [delete] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/WebKit/LayoutTests/editing/selection/5354455-2.html [delete] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/WebKit/LayoutTests/platform/linux/editing/selection/5354455-2-expected.png [delete] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/WebKit/LayoutTests/platform/linux/editing/selection/5354455-2-expected.txt [delete] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/WebKit/LayoutTests/platform/mac/editing/selection/5354455-2-expected.png [delete] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/WebKit/LayoutTests/platform/mac/editing/selection/5354455-2-expected.txt [delete] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/WebKit/LayoutTests/platform/win/editing/selection/5354455-2-expected.png [delete] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/WebKit/LayoutTests/platform/win/editing/selection/5354455-2-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aeec4140d02480bb690c9e290bfb1ded42e2fd97 commit aeec4140d02480bb690c9e290bfb1ded42e2fd97 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Jun 12 05:52:33 2018 [LayoutNG] Rewrite editing/selection/4960137.html with w3c test harness. This patch rewrite editing/selection/4960137.html using w3c harness instead of image/text test because the test only confirms not crash. This patch fixes NG failure for the test. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452 Change-Id: I2dc4cfcb0606b40b2449b6c1770c1e9f72fbc9fc Reviewed-on: https://chromium-review.googlesource.com/1092405 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566332} [modify] https://crrev.com/aeec4140d02480bb690c9e290bfb1ded42e2fd97/third_party/WebKit/LayoutTests/editing/selection/4960137.html [delete] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/4960137-expected.png [delete] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/4960137-expected.txt [delete] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/4960137-expected.png [delete] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/4960137-expected.txt [delete] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/third_party/WebKit/LayoutTests/platform/win/editing/selection/4960137-expected.png [delete] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/third_party/WebKit/LayoutTests/platform/win/editing/selection/4960137-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74deed423f1d5c9d0d621fce83dd254db666e255 commit 74deed423f1d5c9d0d621fce83dd254db666e255 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Jun 12 15:55:04 2018 Convert editing/selection/paint-hyphen.html NG expect to reftest. That test is reftest so that image expectation doesn't work. This patch replaces it with ref expectation for NG flag specific result. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452, 851812 Change-Id: I0e4331f9cd4a1064541048cd196cd8f54b3aa727 Reviewed-on: https://chromium-review.googlesource.com/1092408 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#566443} [modify] https://crrev.com/74deed423f1d5c9d0d621fce83dd254db666e255/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/74deed423f1d5c9d0d621fce83dd254db666e255/third_party/WebKit/LayoutTests/editing/selection/paint-hyphen-expected.html [delete] https://crrev.com/6d87036a5d48b2775e0ec6069b7c64a5fb5e3331/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/paint-hyphen-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e7835ddebd862f9c38461f41aad77a2a1a6ef3e commit 0e7835ddebd862f9c38461f41aad77a2a1a6ef3e Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Jun 12 15:59:58 2018 [LayoutNG] Rebase paint/selection/text-selection-newline-rtl-double-linebreak.html This patch rebases the image expectation since old image expect is painted line break on the right side but since text is styled rtl, the expectations is wrong. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I61f373f6f27b2f1f06a46f23f863e532a8bd4ec5 Reviewed-on: https://chromium-review.googlesource.com/1096810 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#566444} [add] https://crrev.com/0e7835ddebd862f9c38461f41aad77a2a1a6ef3e/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png [add] https://crrev.com/0e7835ddebd862f9c38461f41aad77a2a1a6ef3e/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-newline-rtl-double-linebreak-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2e0b2d7c7a5d410180402ce5c2360956f150d8b commit d2e0b2d7c7a5d410180402ce5c2360956f150d8b Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jun 13 05:34:26 2018 [LayoutNG] Fix paint/invalidation/selection/japanese-rl-selection-repaint.html This patch converts the test to reftest since that test just confirms repaint after load. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452 Change-Id: Iffc00614c617a64c5f185029014f1d43734fbbca Reviewed-on: https://chromium-review.googlesource.com/1092610 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566729} [add] https://crrev.com/d2e0b2d7c7a5d410180402ce5c2360956f150d8b/third_party/WebKit/LayoutTests/paint/invalidation/selection/japanese-rl-selection-repaint-expected.html [modify] https://crrev.com/d2e0b2d7c7a5d410180402ce5c2360956f150d8b/third_party/WebKit/LayoutTests/paint/invalidation/selection/japanese-rl-selection-repaint.html [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/japanese-rl-selection-repaint-expected.png [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/japanese-rl-selection-repaint-expected.txt [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/selection/japanese-rl-selection-repaint-expected.png [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/selection/japanese-rl-selection-repaint-expected.txt [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/japanese-rl-selection-repaint-expected.png [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/japanese-rl-selection-repaint-expected.txt [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/japanese-rl-selection-repaint-expected.png [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/japanese-rl-selection-repaint-expected.txt [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/selection/japanese-rl-selection-repaint-expected.png [delete] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/selection/japanese-rl-selection-repaint-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0472829d1cfc323081f6ccf2c4014b6a2bc369e8 commit 0472829d1cfc323081f6ccf2c4014b6a2bc369e8 Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jun 13 10:33:52 2018 [LayoutNG] Fix paint/invalidation/selection/selection-change-in-iframe-with-relative-parent.html This patch cancels selection painting if the NGPaintFragment has no selection rect. This happens when we select the last line break but it is not painted whether it is selected or not anyway. The test was virtually passed image expectation but PaintUnderInvalidationChecking has made crash for above reason. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia1939c02aa6327f3dd7620920ec6b60a6b74b790 Reviewed-on: https://chromium-review.googlesource.com/1096592 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#566790} [add] https://crrev.com/0472829d1cfc323081f6ccf2c4014b6a2bc369e8/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/selection-change-in-iframe-with-relative-parent-expected.txt [modify] https://crrev.com/0472829d1cfc323081f6ccf2c4014b6a2bc369e8/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34e7893828d0a959144b1a42d7282be90a8b1a2d commit 34e7893828d0a959144b1a42d7282be90a8b1a2d Author: Yoichi Osato <yoichio@chromium.org> Date: Fri Jun 15 02:32:30 2018 [LayoutNG] Rebase fast/writing-mode/japanese-lr-selection.html image expectation. This patch rebases image expectations for - fast/writing-mode/japanese-lr-selection.html since they are styled "writing-mode:vertical-lr" and the 1px diff is accepted. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I015c144effcba7ef57f24d475607f372c3a46a70 Reviewed-on: https://chromium-review.googlesource.com/1100374 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567520} [add] https://crrev.com/34e7893828d0a959144b1a42d7282be90a8b1a2d/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/writing-mode/japanese-lr-selection-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9549db41ac21578128914ec57c2b68dc73ddcfda commit 9549db41ac21578128914ec57c2b68dc73ddcfda Author: Yoichi Osato <yoichio@chromium.org> Date: Fri Jun 15 16:03:26 2018 [LayoutNG] Not paint a line break at the end of inline-block This patch stops painting a line break the end of inline-block because if an inline-block is at the middle of line, we should not paint a line break. Old layout paints line break if the inline-block is at the end of line, but since its complex to determine if the inline-block is at the end of line on NG, this patch just cancels block-end line break painting for any inline-block. This patch fixes: paint/selection/text-selection-inline-block-rtl.html paint/selection/text-selection-inline-block.html (rebase is for 1px line height). Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I270b48fd432e31b327796b098edc7c9553b356ad Reviewed-on: https://chromium-review.googlesource.com/1096922 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567670} [modify] https://crrev.com/9549db41ac21578128914ec57c2b68dc73ddcfda/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/selection-repaint-with-gaps-expected.png [modify] https://crrev.com/9549db41ac21578128914ec57c2b68dc73ddcfda/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/selection-repaint-with-gaps-expected.txt [add] https://crrev.com/9549db41ac21578128914ec57c2b68dc73ddcfda/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/selection/inline-block-in-selection-root-expected.html [modify] https://crrev.com/9549db41ac21578128914ec57c2b68dc73ddcfda/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-inline-block-expected.png [modify] https://crrev.com/9549db41ac21578128914ec57c2b68dc73ddcfda/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/text-selection-inline-block-rtl-expected.png [modify] https://crrev.com/9549db41ac21578128914ec57c2b68dc73ddcfda/third_party/blink/renderer/core/editing/layout_selection.cc [modify] https://crrev.com/9549db41ac21578128914ec57c2b68dc73ddcfda/third_party/blink/renderer/core/editing/layout_selection_test.cc [modify] https://crrev.com/9549db41ac21578128914ec57c2b68dc73ddcfda/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_test.cc
fast/css/text-overflow-ellipsis-vertical-select.html looks like reasonable in NG, tried to rebaseline but it was a ref test...
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38a2825ff7b3a2fd80f4a0b269345d38717d869f commit 38a2825ff7b3a2fd80f4a0b269345d38717d869f Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jun 20 05:53:13 2018 [LayoutNG] Paint LayoutReplaced selection considering line height. This patch changes LayoutReplaced selection painting rect by expanding its top and height to the line height so that we paint selection filling line gap. This patch updates LayoutReplaced::LocalSelectionRect adapting NGPaintFragment. New image-writing-modes.html test confirms image selection painting on horizontal, vertical-lr/rt. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id7a74f0961109cc458b973664ff56e14655bf257 Reviewed-on: https://chromium-review.googlesource.com/1102287 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568741} [modify] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/overflow/image-selection-highlight-expected.png [add] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/image-writing-modes-expected.png [add] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/selection/image-writing-modes-expected.txt [add] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/WebKit/LayoutTests/paint/selection/image-writing-modes-expected.png [add] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/WebKit/LayoutTests/paint/selection/image-writing-modes-expected.txt [add] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/WebKit/LayoutTests/paint/selection/image-writing-modes.html [add] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/WebKit/LayoutTests/platform/mac/paint/selection/image-writing-modes-expected.png [modify] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/blink/renderer/core/layout/layout_replaced.cc [modify] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/blink/renderer/core/layout/layout_text.cc [modify] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc [modify] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/blink/renderer/core/paint/ng/ng_paint_fragment.h [modify] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc [modify] https://crrev.com/38a2825ff7b3a2fd80f4a0b269345d38717d869f/third_party/blink/renderer/core/paint/paint_invalidator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e6d049fd249ec5f07624df9f67c2d43b37324d2 commit 6e6d049fd249ec5f07624df9f67c2d43b37324d2 Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jun 20 19:03:32 2018 [LayoutNG] Rebase fast/writing-mode/vertical-lr-replaced-selection.html This patch is a follow-up of previous patch: [LayoutNG] Paint LayoutReplaced selection considering line height: crrev.com/c/1102287 The test is styled "writing-mode:vertical-lr" and the 1px diff is accepted. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I253917127951a4139ece4191df37a9b68b9a4da3 Reviewed-on: https://chromium-review.googlesource.com/1107526 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568962} [add] https://crrev.com/6e6d049fd249ec5f07624df9f67c2d43b37324d2/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/writing-mode/vertical-lr-replaced-selection-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba4cfa8ea85018176af83062b37cc2c44c2fb279 commit ba4cfa8ea85018176af83062b37cc2c44c2fb279 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Jun 28 02:22:55 2018 [LayoutNG] Not paint ellipsis selection This patch stops painting selection on ellipsis like legacy implementation. This patch fixes: fast/css/text-overflow-ellipsis-vertical-select.html Rebases are image updates for that. Notes: FireFox and Edge don't paint it either. WebKit paints them when any truncated text were selected. No one (including NG) seems to have implemented the spec behavior: https://www.w3.org/TR/css-ui-4/#ellipsis-interaction > Selecting the ellipsis should select the ellipsed text. > If all of the ellipsed text is selected, UAs should show selection of the ellipsis. > Behavior of partially-selected ellipsed text is up to the UA. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4a9c3bc1904b762acefadaf6a90b511de4004078 Reviewed-on: https://chromium-review.googlesource.com/1116401 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570998} [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png [modify] https://crrev.com/ba4cfa8ea85018176af83062b37cc2c44c2fb279/third_party/blink/renderer/core/editing/layout_selection.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a11e57ffc2fc0deb0007338dcdcd3282a9a391ec commit a11e57ffc2fc0deb0007338dcdcd3282a9a391ec Author: Yoichi Osato <yoichio@chromium.org> Date: Fri Jun 29 21:43:01 2018 Refactor layout_selection_test using NextLayoutObjectOnFlatTree This patch refactors the test using NextLayoutObjectOnDOMTreeIncludeShadow rather than layout tree order to confirm SelectionStatus exactly. This patch also introduces understandable error output for ease of debugging. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibd09fa39cbd2f98b84951ba41e091b8f3ae68494 Reviewed-on: https://chromium-review.googlesource.com/1117737 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#571648} [modify] https://crrev.com/a11e57ffc2fc0deb0007338dcdcd3282a9a391ec/third_party/blink/renderer/core/editing/layout_selection.cc [modify] https://crrev.com/a11e57ffc2fc0deb0007338dcdcd3282a9a391ec/third_party/blink/renderer/core/editing/layout_selection_test.cc [modify] https://crrev.com/a11e57ffc2fc0deb0007338dcdcd3282a9a391ec/third_party/blink/renderer/core/layout/layout_text_fragment.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de286a999618fa1cf967fca97db36db6bd5342e4 commit de286a999618fa1cf967fca97db36db6bd5342e4 Author: Yoichi Osato <yoichio@chromium.org> Date: Mon Jul 09 09:19:59 2018 [LayoutNG] Rebase fast/writing-mode/vertical-rl-replaced-selection.html image expectation. This patch rebases image expectations for the test since they are styled "writing-mode:vertical-rl" and the 1px diff is accepted. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icbae29c3cbf890100c39c746ffbf00db5d727f86 Reviewed-on: https://chromium-review.googlesource.com/1128673 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#573251} [add] https://crrev.com/de286a999618fa1cf967fca97db36db6bd5342e4/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/writing-mode/vertical-rl-replaced-selection-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c08801b27c5363b4d3816842f0e4e6a91de8884c commit c08801b27c5363b4d3816842f0e4e6a91de8884c Author: Yoichi Osato <yoichio@chromium.org> Date: Fri Aug 31 04:59:48 2018 Rebase paint/invalidation/selection/selection-rl.html For LegacyLayout, we have to do character-range-based partial invalidation for selections because a LayoutText is too big to be fully invalidates for selection. In the other hand, we're invalidating each NGPaintfragment. So no further grain invalidation, which is based on character range that we're doing for legacy, is not needed. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id011ced00ee2de43efdc9bf35f7ad922b0cf1078 Reviewed-on: https://chromium-review.googlesource.com/1198744 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#587946} [modify] https://crrev.com/c08801b27c5363b4d3816842f0e4e6a91de8884c/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [add] https://crrev.com/c08801b27c5363b4d3816842f0e4e6a91de8884c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/selection-rl-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cb73e6590a6c6c4b34088196b77ed492f7b77ce commit 3cb73e6590a6c6c4b34088196b77ed492f7b77ce Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Sep 12 10:15:43 2018 Change old and new selection representation to use Node instead of LayoutObject This patch is a preparation of moving SelectionState bit to Node from LayoutObject. We're collecting existing selected LayoutObjects when selection is changed. There are structures to represent new selected LayoutObjects and old ones: |SelectionPaintRange| and |OldSelectionLayoutObject|, they are virtually set or map. This patch converts the representation using Node rather than LayoutObject. Conversion is simple: |layout_object->GetSelectionState()| to |node->GetLayoutObject()->GetSelectionState()| except LayoutTextFragment. The collecting while considering LayoutTextFragment is complicated. This patch refactors the code from marking LayoutTextFragment at prepaint (LayoutSelection::Commit()) to check its SelectionState at painting(ComputeSelectionStatus()). This patch stops setting SelectionState on LayoutTextFragment and only watch Node's LayoutObjects SelectionState. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I161c519fb97c1b7134028b2d47321eb3ac4c692a Reviewed-on: https://chromium-review.googlesource.com/1160066 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#590634} [modify] https://crrev.com/3cb73e6590a6c6c4b34088196b77ed492f7b77ce/third_party/blink/renderer/core/editing/layout_selection.cc [modify] https://crrev.com/3cb73e6590a6c6c4b34088196b77ed492f7b77ce/third_party/blink/renderer/core/editing/layout_selection.h [modify] https://crrev.com/3cb73e6590a6c6c4b34088196b77ed492f7b77ce/third_party/blink/renderer/core/editing/layout_selection_test.cc [modify] https://crrev.com/3cb73e6590a6c6c4b34088196b77ed492f7b77ce/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/3cb73e6590a6c6c4b34088196b77ed492f7b77ce/third_party/blink/renderer/core/layout/layout_object.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23e29dd3cb25a9adb0d70882a71c4325efc600bb commit 23e29dd3cb25a9adb0d70882a71c4325efc600bb Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Sep 13 07:51:19 2018 [LayoutNG] Rebase paint/invalidation/selection/selection-partial-invalidation-between-blocks.html This patch rebases image failures that NG paints 1px taller than old. This is by-product but got lgtm at the previous patch: crrev.com/c/1080442 ([LayoutNG] Fill selection paint line gap.) There is also an anti-areas rendering diff but it seems O.K. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I387c6dc68dd5c4f01d5fb3d3548e88bf2b6c8bf9 Reviewed-on: https://chromium-review.googlesource.com/1223287 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#590944} [add] https://crrev.com/23e29dd3cb25a9adb0d70882a71c4325efc600bb/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.png [modify] https://crrev.com/23e29dd3cb25a9adb0d70882a71c4325efc600bb/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt
Comment 1 by yoichio@chromium.org
, Apr 5 2017