Issue metadata
Sign in to add a comment
|
Regression: 'Enable Ok Google to start a voice search' option is missing in chrome://md-settings/search page on clicking reset button. |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3062.0/9430.1.0 dev-channel Daisy,Peppy and Minnie OS: Chrome OS What steps will reproduce the problem? (1)Navigate to chrome://md-settings/search page>> Click on 'Search engine used in the address bar' drop-down (2)Now select any option other than Google( Here observe 'Enable Ok Google to start a voice search' option is seen only when default search engine is Google) (3)Reset chrome://md-settings page by clicking on reset button in Reset overlay . (4)Now go to chrome://md-settings/search page and Observe 'Enable Ok Google to start a voice search' option is missing when default search engine is changed to Google on reset. Expected: On clicking on reset button 'Enable Ok Google to start a voice search' option should be seen in chrome://md-settings/search when default search engine is 'Google' Actual: Instead Enable Ok Google to start a voice search' option is missing. This is regression issue as it is working fine in chrome://settings. Attaching screen-cast for reference.
,
Apr 6 2017
Not a P1, but already started, it's an easy fix.
,
Apr 6 2017
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a1fd7a7f2fc50b1fa4311ebd75d43195d69d00 commit e6a1fd7a7f2fc50b1fa4311ebd75d43195d69d00 Author: stevenjb <stevenjb@chromium.org> Date: Thu Apr 06 19:43:05 2017 MD Settings: Search engine: Request hotword info on engine change When a reset or other external search engine change occurs, we also need to re-request the hotword info. BUG= 708451 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2804593003 Cr-Commit-Position: refs/heads/master@{#462588} [modify] https://crrev.com/e6a1fd7a7f2fc50b1fa4311ebd75d43195d69d00/chrome/browser/resources/settings/search_page/search_page.js [modify] https://crrev.com/e6a1fd7a7f2fc50b1fa4311ebd75d43195d69d00/chrome/test/data/webui/settings/search_page_test.js
,
Apr 6 2017
,
Apr 21 2017
The screenshot shows the search engine as Yahoo; OK Google is not expected to be visible with non Google search engines. The behavior appears to be correct on my ToT build. If this is still reproducible, please provide specific steps or a video.
,
May 8 2017
Verified on ChromeOS 9532.0.0, 60.0.3092.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jbanavatu@chromium.org
, Apr 5 201712.4 MB
12.4 MB View Download