New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708440 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

revive chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

Project Member Reported by tapted@chromium.org, Apr 5 2017

Issue description

Chrome Version       : 59.0.3047.0

chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc isn't in any BUILD.gn file. It doesn't currently compile:

../../chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc:46:71: error: too few arguments to function call, expected 2, have 1
    message_center::MessageCenter::Get()->RemoveAllNotifications(false);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~      ^
../../ui/message_center/message_center.h:109:3: note: 'RemoveAllNotifications' declared here
  virtual void RemoveAllNotifications(bool by_user, RemoveType type) = 0;
  ^
../../chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc:63:20: error: no matching constructor for initialization of '::Notification'
    ::Notification notification(
                   ^
../../chrome/browser/notifications/notification.h:25:3: note: candidate constructor not viable: requires 10 arguments, but 7 were provided
  Notification(
 

Comment 1 by awdf@chromium.org, Jul 5 2017

Labels: -OS-Linux -OS-Windows
Owner: yoshiki@chromium.org
Status: Assigned (was: Untriaged)
Hi yoshiki@ - could you or someone on the ChromeOS team decide what to do with this please? I understand the web notification tray is only used on Chrome OS these days.
Status: Started (was: Assigned)
ok, let me fix it

Sign in to add a comment