New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708428 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , iOS
Pri: 1
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Crash in CXFA_FMLogicalOrExpression::ToJavaScript

Project Member Reported by ClusterFuzz, Apr 5 2017

Issue description

Cc: msrchandra@chromium.org dsinclair@chromium.org
Components: Internals>Plugins>PDF
Labels: Test-Predator-Correct-CLs M-58
Owner: och...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
Regression information is not available. The result is the blame information. 

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/1770c021cf998ff1b33855b1397f6ea8ff9f7cd7
Time: Mon Mar 14 14:14:16 2016 -0400
The CL last changed line 314 of file xfa_simpleexpression.cpp, which is stack frame 0. 

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/1770c021cf998ff1b33855b1397f6ea8ff9f7cd7
Time: Mon Mar 14 14:14:16 2016 -0400
The CL last changed line 194 of file xfa_expression.cpp, which is stack frame 1. 

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/1770c021cf998ff1b33855b1397f6ea8ff9f7cd7
Time: Mon Mar 14 14:14:16 2016 -0400
The CL last changed line 36 of file xfa_program.cpp, which is stack frame 3. 

Author: Oliver Chang
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/e67d21825c9fd4b805b9bea211e09225f3c2a85d
Time: Tue Feb 16 11:42:07 2016 -0800
The CL last changed line 25 of file pdf_fm2js_fuzzer.cc, which is stack frame 4.

@Oliver Chang -- Could you please take a look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: -dsinclair@chromium.org
Labels: -M-58
Owner: dsinclair@chromium.org
Blocking: 62400
XFA issue.
Labels: -OS-Linux OS-iOS
Owner: thestig@chromium.org
Status: Started (was: Assigned)
https://pdfium-review.googlesource.com/5331 or change the error handling mechanisms to have an extra boolean error flag, and check for that consistently.
Project Member

Comment 5 by ClusterFuzz, May 11 2017

Labels: OS-Linux
Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5228a2833da014443b36abc4e1c15e035d5d4d69

commit 5228a2833da014443b36abc4e1c15e035d5d4d69
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Wed May 17 02:50:16 2017

Roll src/third_party/pdfium/ 58854942e..d3a3cc24a (5 commits)

https://pdfium.googlesource.com/pdfium.git/+log/58854942e06d..d3a3cc24a034

$ git log 58854942e..d3a3cc24a --date=short --no-merges --format='%ad %ae %s'
2017-05-16 thestig Handle when XFA parser error handlers cannot format error messages.
2017-05-16 dsinclair Add formcalc lexer tests.
2017-05-16 dsinclair Update formcalc return types
2017-05-16 dsinclair Do not walk off end of formcalc string
2017-05-16 dsinclair Minor xfa_lexer.cpp cleanup

Created with:
  roll-dep src/third_party/pdfium
BUG= 708428 , 721533 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I3fe337c83eaa5f58ee723b5111bc9dcc2b2adcd9
Reviewed-on: https://chromium-review.googlesource.com/506659
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472296}
[modify] https://crrev.com/5228a2833da014443b36abc4e1c15e035d5d4d69/DEPS

Project Member

Comment 9 by ClusterFuzz, May 17 2017

ClusterFuzz has detected this issue as fixed in range 472292:472325.

Detailed report: https://clusterfuzz.com/testcase?key=6013720242421760

Fuzzer: afl_pdf_fm2js_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  CXFA_FMLogicalOrExpression::ToJavaScript
  CXFA_FMExpExpression::ToImpliedReturnJS
  CXFA_FMFunctionDefinition::ToJavaScript
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=472292:472325

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6013720242421760


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment