New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708425 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Page gets scrolled in middle after adding new words in chrome://md-settings/editDictionary.

Reported by rp...@etouch.net, Apr 5 2017

Issue description

Version: 59.0.3063.0 eb509f59b8e9f31569d0dad0d90d8f755291d497-refs/heads/master@{#461928}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/editDictionary and add several words such as scroll bar appears on page,observe

Actual: Page gets scrolled in middle after adding new words
Expected: Page should get scrolled downwards as new words are added at the bottom end

This is regression issue, broken in ‘M 59’ and will soon update other info :
Good build:59.0.3057.0
Bad build: 59.0.3059.0

Note : Issue is not seen on Mac OS.
 
Actual_video.mp4
1.0 MB View Download
Expected_video.mp4
481 KB View Download

Comment 1 by rp...@etouch.net, Apr 5 2017

Correction :  OS: Windows (7,8,8.1,10),Linux (14.04 LTS)
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3057.0 (Revision:460966).
Bad build:59.0.3059.0 (Revision:461269).

You are probably looking for a change made after 461188 (known good), but no later than 461189 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/1bafcfdfcc6867b9be120e54c73b0ea526cd886e..b87ba7ea439809c7a7ccd76a4ce55b1aae3aeeed

From the CL above, assigning the issue to the concern owner

@dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2792463002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Not in Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3063.0
Status: Started (was: Assigned)
CL at https://codereview.chromium.org/2797133007/
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4d9ba0b0e6c15675c151733e4a77902a9fae02

commit 5d4d9ba0b0e6c15675c151733e4a77902a9fae02
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Apr 06 22:32:04 2017

[MD settings] add custom spelling words to top of list

This CL changes how new custom spelling words are added in the settings.
Rather than adding to the bottom of the list and trying to scroll to the
new word, the new word is added to the top of the list. This also keeps
the input field visible on long lists of words (it's frustrating to need
to repeatedly scroll to the top to add the next word).

BUG= 708425 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2797133007
Cr-Commit-Position: refs/heads/master@{#462654}

[modify] https://crrev.com/5d4d9ba0b0e6c15675c151733e4a77902a9fae02/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js

Status: Fixed (was: Started)

Sign in to add a comment