New issue
Advanced search Search tips

Issue 708404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD Bookmarks] Search bar is misaligned in new profile

Project Member Reported by tsergeant@chromium.org, Apr 5 2017

Issue description

Steps to reproduce:

1. Create a new profile
2. (Optionally) add a bookmark to that profile
3. Open MD Bookmarks

Expected behavior: Search field is correctly aligned relative to the bookmark card.

Actual behavior: Search field is not correctly aligned. Resizing the window will temporarily fix the layout, but reloading the page returns it to its misaligned position.
 
bookmark_search_misaligned.png
30.5 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5019f85de11bc85d3d8ab32cf4aca11fb6f1381d

commit 5019f85de11bc85d3d8ab32cf4aca11fb6f1381d
Author: calamity <calamity@chromium.org>
Date: Tue Apr 11 05:19:56 2017

[MD Bookmarks] Fix sidebar issues.

This CL fixes the search box not accounting for the sidebar on a fresh
profile, makes the search box update every frame of a drag, and adds a
test for storing the sidebar width in local storage.

BUG= 708404 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2804543002
Cr-Commit-Position: refs/heads/master@{#463543}

[modify] https://crrev.com/5019f85de11bc85d3d8ab32cf4aca11fb6f1381d/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/5019f85de11bc85d3d8ab32cf4aca11fb6f1381d/chrome/browser/resources/md_bookmarks/constants.js
[modify] https://crrev.com/5019f85de11bc85d3d8ab32cf4aca11fb6f1381d/chrome/test/data/webui/md_bookmarks/app_test.js
[modify] https://crrev.com/5019f85de11bc85d3d8ab32cf4aca11fb6f1381d/ui/webui/resources/js/cr/ui/splitter.js

Status: Fixed (was: Assigned)

Sign in to add a comment