New issue
Advanced search Search tips

Issue 708396 link

Starred by 1 user
Status: Archived
Owner:
henryhsu@chromium.org
Closed: Apr 2017
Cc:
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Test more required resolutions in camera_V4L2 autotest

Project Member Reported by wuchengli@chromium.org, Apr 5 2017 
camera_V4L2 autotest checks only 640x480 and 320x240. It should also check 720p and/or 1080p if the sensor maximum resolution >= 720p.

chromeos_public/src/third_party/autotest/files/client/site_tests/camera_V4L2/camera_V4L2.py

https://developer.android.com/reference/android/hardware/camera2/CameraCharacteristics.html#SCALER_STREAM_CONFIGURATION_MAP

1920x1080 (1080p)       if 1080p <= activeArraySize
1280x720 (720p) if 720p <= activeArraySize
640x480 (480p)  if 480p <= activeArraySize
320x240 (240p)  if 240p <= activeArraySize

Comment 1 by wuchengli@chromium.org, Apr 7 2017 

We need to check two more resolutions. 1280x960 and 1600x1200. Both should be at least 30fps.

For resolutions > 1600x1200, check it has at least 1fps for now.

Comment 2 by henryhsu@chromium.org, Apr 10 2017 

Final decision after discussion:

if camera_characteristics.conf exists, it means the device supports arc++.
Then we have to check:
1920x1080 (1080p) if 1080p <= activeArraySize
1280x720 (720p)   if 720p <= activeArraySize
640x480 (480p)    if 480p <= activeArraySize
320x240 (240p)    if 240p <= activeArraySize

If camera maximum resolution exceeds 3M pixels, we also have to check 1280x960 and 1600x1200. Because we may use these two resolutions as preview size.

Comment 3 by henryhsu@chromium.org, Apr 10 2017

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/472646/
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/20854f5205ff51c7b194906c9c85212651a97e1a

commit 20854f5205ff51c7b194906c9c85212651a97e1a
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Thu Apr 13 05:42:02 2017

Fix pylint error for camera_V4L2

Also remove unused run_v4l2_default_capture_test().

BUG= chromium:708396 
TEST=test_that -b ${BOARD} ${IP} camera_V4L2

Change-Id: I258aa3e7dda1aff24807e6c693ae890c0b9a33fd
Reviewed-on: https://chromium-review.googlesource.com/475530
Commit-Ready: Heng-ruey Hsu <henryhsu@chromium.org>
Tested-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Wu-cheng Li <wuchengli@chromium.org>

[modify] https://crrev.com/20854f5205ff51c7b194906c9c85212651a97e1a/client/site_tests/camera_V4L2/camera_V4L2.py
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/86746edf4e917844b447564b5806fd0c3bdd1a13

commit 86746edf4e917844b447564b5806fd0c3bdd1a13
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Fri Apr 14 06:54:05 2017

Simplfy Run() function in camera_V4L2

Using frame number cannot guarantee the total test time since frame rate
is variable in different light environment.
Change it to use time_to_capture only and check the actual fps to avoid
that the camera device doesn't output any frames.

BUG= chromium:708396 
TEST=test_that -b ${BOARD} ${IP} camera_V4L2

Change-Id: I6d1e7cfd0f772b4dda6c3eb6d6241f59c99e81bb
Reviewed-on: https://chromium-review.googlesource.com/476430
Commit-Ready: Heng-ruey Hsu <henryhsu@chromium.org>
Tested-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org>

[modify] https://crrev.com/86746edf4e917844b447564b5806fd0c3bdd1a13/client/site_tests/camera_V4L2/src/media_v4l2_device.cc
[modify] https://crrev.com/86746edf4e917844b447564b5806fd0c3bdd1a13/client/site_tests/camera_V4L2/src/media_v4l2_device.h
[modify] https://crrev.com/86746edf4e917844b447564b5806fd0c3bdd1a13/client/site_tests/camera_V4L2/src/media_v4l2_test.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/project-cheets-private/+/76d9be72a2939150f717b61e7ed375d2a6f791d2

commit 76d9be72a2939150f717b61e7ed375d2a6f791d2
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Mon Apr 17 13:23:41 2017
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/project-cheets-private/+/9f8854989a4f526fc2371fc30193ab8646460133

commit 9f8854989a4f526fc2371fc30193ab8646460133
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Tue Apr 25 12:52:35 2017
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-caroline-private/+/e0c8aea05b7f7d68526d004fc5aaaeca331f34d6

commit e0c8aea05b7f7d68526d004fc5aaaeca331f34d6
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 04:19:57 2017
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-hana-private/+/66e4d1a97959a4b11744a348084efadf2d7c0320

commit 66e4d1a97959a4b11744a348084efadf2d7c0320
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 09:03:31 2017
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-elm-private/+/31c5ca125ea38016f9c550b8779248fb77eca30f

commit 31c5ca125ea38016f9c550b8779248fb77eca30f
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 09:03:32 2017
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-pyro-private/+/990bfa0149442218964156b46794ced02689b4b0

commit 990bfa0149442218964156b46794ced02689b4b0
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 09:03:31 2017
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-snappy-private/+/217c403f5051ca1c01c1dbe0585c627f327ac515

commit 217c403f5051ca1c01c1dbe0585c627f327ac515
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 09:03:33 2017
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-squawks-private/+/922a776755dfbb4cb01b52df0e4af7d2f336073d

commit 922a776755dfbb4cb01b52df0e4af7d2f336073d
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 09:03:34 2017
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-samus-private/+/3bf18c1fc2f84a223210ac3dde42917373a49133

commit 3bf18c1fc2f84a223210ac3dde42917373a49133
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 09:03:30 2017
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-cave-private/+/f416db9b1f379543470d10458b24551a05577fa2

commit f416db9b1f379543470d10458b24551a05577fa2
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 09:03:33 2017
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-ultima-private/+/594f9e0e0f30b2ac879c480fd1fa9f4e2ef3bf5a

commit 594f9e0e0f30b2ac879c480fd1fa9f4e2ef3bf5a
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 09:03:34 2017
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/5d267140ea220b1c3f45c4b894a2fad5e38ac7a1

commit 5d267140ea220b1c3f45c4b894a2fad5e38ac7a1
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 11:28:08 2017
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/5d267140ea220b1c3f45c4b894a2fad5e38ac7a1

commit 5d267140ea220b1c3f45c4b894a2fad5e38ac7a1
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 11:28:08 2017
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-cyan-private/+/26f1325d26cd20b4e45c5138a00fe7b2f09aea73

commit 26f1325d26cd20b4e45c5138a00fe7b2f09aea73
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Apr 26 11:28:12 2017
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 27 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-kevin-private/+/3414ec4089a86e6ad8c4b10d01517efe64e30b8a

commit 3414ec4089a86e6ad8c4b10d01517efe64e30b8a
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Thu Apr 27 05:13:15 2017
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/403afe118e2b5e737426b68d13714899078e3886

commit 403afe118e2b5e737426b68d13714899078e3886
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Thu Apr 27 11:16:50 2017

Add tool for parsing camera config file in camera_V4L2

The three files are copied from arc-camera-service.
Only remove namespace and add constructor of SupportedFormat.

BUG= chromium:708396 
TEST=test_that -b ${BOARD} ${IP} camera_V4L2

Change-Id: I3c9017289975358d8a61b3a329f0b0ebd5e68d10
Reviewed-on: https://chromium-review.googlesource.com/477734
Commit-Ready: Heng-ruey Hsu <henryhsu@google.com>
Tested-by: Heng-ruey Hsu <henryhsu@google.com>
Reviewed-by: Heng-ruey Hsu <henryhsu@google.com>

[add] https://crrev.com/403afe118e2b5e737426b68d13714899078e3886/client/site_tests/camera_V4L2/src/camera_characteristics.cc
[modify] https://crrev.com/403afe118e2b5e737426b68d13714899078e3886/client/site_tests/camera_V4L2/src/Makefile
[add] https://crrev.com/403afe118e2b5e737426b68d13714899078e3886/client/site_tests/camera_V4L2/src/common_types.h
[add] https://crrev.com/403afe118e2b5e737426b68d13714899078e3886/client/site_tests/camera_V4L2/src/camera_characteristics.h
Project Member

Comment 26 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/80c5f569569254b504338b652609dcfe485d8287

commit 80c5f569569254b504338b652609dcfe485d8287
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Fri Apr 28 05:54:51 2017

Check more resolutions in camera_V4L2

We have to test more resolutions for those devices that support arc++.
Since two formats may support the same resolution with different
frame rate, we have to add ENUM_FRAMEINTERVALS to use correct format
to test.

Move some test logic from camera_V4L2.py to media_v4l2_test.cc.
Then we don't have to parse log to configure test anymore.

BUG= chromium:708396 
TEST=test_that -b ${BOARD} ${IP} camera_V4L2

Change-Id: I96e99e7dd11d82af940f214ba7b3bc563f4d3949
Reviewed-on: https://chromium-review.googlesource.com/472646
Commit-Ready: Heng-ruey Hsu <henryhsu@google.com>
Tested-by: Heng-ruey Hsu <henryhsu@google.com>
Reviewed-by: Heng-ruey Hsu <henryhsu@google.com>

[modify] https://crrev.com/80c5f569569254b504338b652609dcfe485d8287/client/site_tests/camera_V4L2/src/media_v4l2_unittest.cc
[modify] https://crrev.com/80c5f569569254b504338b652609dcfe485d8287/client/site_tests/camera_V4L2/src/media_v4l2_test.cc
[modify] https://crrev.com/80c5f569569254b504338b652609dcfe485d8287/client/site_tests/camera_V4L2/src/media_v4l2_device.h
[modify] https://crrev.com/80c5f569569254b504338b652609dcfe485d8287/client/site_tests/camera_V4L2/camera_V4L2.py
[modify] https://crrev.com/80c5f569569254b504338b652609dcfe485d8287/client/site_tests/camera_V4L2/src/media_v4l2_device.cc
[modify] https://crrev.com/80c5f569569254b504338b652609dcfe485d8287/client/site_tests/camera_V4L2/src/media_v4l2_is_capture_device.cc

Comment 27 by henryhsu@chromium.org, Apr 28 2017

Status: Fixed (was: Started)
Project Member

Comment 28 by bugdroid1@chromium.org, May 17 2017

Labels: merge-merged-release-R58-9334.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-variant-veyron-tiger-private/+/b39cb8727fe997f8f9a82bc028489de16c39a6da

commit b39cb8727fe997f8f9a82bc028489de16c39a6da
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed May 17 23:45:38 2017
Project Member

Comment 29 by bugdroid1@chromium.org, May 23 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/bdb9efd9f848c4168ccab3600e64ead116e7b8b7

commit bdb9efd9f848c4168ccab3600e64ead116e7b8b7
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Tue May 23 08:01:28 2017

Comment 30 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 31 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment