New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708393 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Make patching and rolling libxml and libxslt more transparent

Project Member Reported by dominicc@chromium.org, Apr 5 2017

Issue description

The script I have been using to roll libxml and libxslt isn't in the Chromium repo, and it uses a mixture of sed, git cherry-pick and patch to apply patches. This makes it hard to understand what is in a libxml roll or libxslt roll.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82

commit dd3c9a967d856c4dc8b41fc1738caa4c035c6b82
Author: dominicc <dominicc@chromium.org>
Date: Thu Apr 06 03:49:19 2017

Check in the libxml roll script.

This rolls libxml to the same upstream point,
e905f08123e4a6e7731549e6f09dadff4cab65bd, but with these important
differences:

- The script which does the roll is included along with the roll
  itself.

- libxml2 src used to be patched with a mixture of sed, git
  cherry-pick, and patch. Now there is just a set of patch files in
  chromium/*.patch. This should make the delta to libxml2 more
  transparent. When a patch needs to be rebased, the changes to the
  patch file should be committed along with the roll.

- libxml2's features are now done with configure flags instead of
  editing the xmlversion.h headers.

- More unused files are deleted. This makes it clearer what may
  actually be built into Chromium.

BUG= 708393 

Review-Url: https://codereview.chromium.org/2804483002
Cr-Commit-Position: refs/heads/master@{#462348}

[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/BUILD.gn
[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/README.chromium
[add] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/chromium/chromium-issue-599427.patch
[add] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/chromium/chromium-issue-620679.patch
[add] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/chromium/chromium-issue-628581.patch
[add] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/chromium/chromium-issue-683629.patch
[add] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/chromium/roll.py
[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/linux/config.h
[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/linux/include/libxml/xmlversion.h
[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/linux/xml2-config
[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/mac/config.h
[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/mac/include/libxml/xmlversion.h
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/DOCBparser.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/SAX.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/bakefile/Bakefiles.bkgen
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/bakefile/Readme.txt
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/bakefile/libxml2.bkl
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/c14n.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/catalog.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/debugXML.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/legacy.c
[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/src/libxml2.spec
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/relaxng.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/schematron.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/trio.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/trio.h
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/triop.h
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/triostr.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/triostr.h
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/xinclude.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/xlink.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/xmlmodule.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/xmlregexp.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/xmlschemas.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/xmlschemastypes.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/xpointer.c
[delete] https://crrev.com/d138af58ead4b9965944f5cb7ed2a37cfed91617/third_party/libxml/src/xzlib.c
[modify] https://crrev.com/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82/third_party/libxml/win32/include/libxml/xmlversion.h

Next up.... libxslt.
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f776b2a04faede092dfb454616b1b6be2ee45c4

commit 6f776b2a04faede092dfb454616b1b6be2ee45c4
Author: dominicc <dominicc@chromium.org>
Date: Tue May 09 11:38:49 2017

Check in the libxslt roll script.

This rolls libxslt to the same upstream point,
ac341cbd792ee572941cc9a66e73800219a1a386, but with some important
differences:

- The script which does the roll is included along with the roll
  itself.

- The source is consumed similarly to libxml, and similarly to how
  other projects integrate libxslt, by first producing a distribution
  which is then unpacked into the Chromium tree under libxslt/src.

- A patches is applied to the source and it is easy to add more
  patches; the patches will live in the source tree.

This also updates README.chromium to omit mentioning two patches we
already rolled in from upstream:  crbug.com/676623  which was fixed
upstream in
https://git.gnome.org/browse/libxslt/commit/?id=08ab2774b870de1c7b5a48693df75e8154addae5
and  crbug.com/583171  which was fixed upstream after
https://git.gnome.org/browse/libxslt/commit/?id=91d0540ac9beaa86719a05b749219a69baa0dd8d
per  crbug.com/583171#c22 

BUG= 708393 

Review-Url: https://codereview.chromium.org/2865973002
Cr-Commit-Position: refs/heads/master@{#470285}

[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/BUILD.gn
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/COPYING
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/HACKING
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/MAINTAINERS
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/NOTES
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/README.chromium
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/README.cvs-commits
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/chromium/get-file-attributes-a.patch
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/chromium/roll.py
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/compile
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/config.guess
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/config.sub
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/depcomp
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/install-sh
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/libxslt.doap
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/libxslt/xsltwin32config.h
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/COPYING
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/Makefile
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/config.h
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/config.log
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/libexslt.pc
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/libexslt/Makefile
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/libxslt.pc
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/libxslt.spec
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/linux/libxslt/Makefile
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/ltmain.sh
[modify] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/mac/config.h
[delete] https://crrev.com/33f2124d4b3245ca20d3ceb683b15858ffa524c4/third_party/libxslt/missing
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/AUTHORS
[copy] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/COPYING
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/Copyright
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/FEATURES
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/INSTALL
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/Makefile.am
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/Makefile.in
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/README
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/TODO
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/aclocal.m4
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/compile
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/config.guess
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/config.h.in
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/config.sub
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/configure
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/configure.in
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/depcomp
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/install-sh
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt.pc.in
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/Makefile.am
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/Makefile.in
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/common.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/crypto.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/date.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/dynamic.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/exslt.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/exslt.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/exsltconfig.h.in
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/exsltexports.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/functions.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/libexslt.3
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/libexslt.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/math.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/saxon.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/sets.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libexslt/strings.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt.m4
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt.pc.in
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt.spec
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt.spec.in
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/Makefile.am
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/Makefile.in
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/attributes.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/attributes.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/attrvt.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/documents.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/documents.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/extensions.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/extensions.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/extra.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/extra.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/functions.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/functions.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/imports.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/imports.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/keys.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/keys.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/libxslt.3
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/libxslt.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/libxslt.syms
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/namespaces.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/namespaces.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/numbers.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/numbersInternals.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/pattern.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/pattern.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/preproc.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/preproc.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/security.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/security.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/templates.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/templates.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/transform.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/transform.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/trio.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/triodef.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/variables.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/variables.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/win32config.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xslt.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xslt.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltInternals.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltconfig.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltconfig.h.in
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltexports.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltlocale.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltlocale.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltutils.c
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltutils.h
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/libxslt/xsltwin32config.h.in
[add] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/missing
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/Makefile.mingw
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/Makefile.msvc
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/Readme.txt
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/configure.js
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/defgen.xsl
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/libexslt.def.src
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/libxslt.def.src
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/libxslt/libxslt.def
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/libxslt/libxslt.dsw
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/libxslt/libxslt_so.dsp
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/libxslt/xsltproc.dsp
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/win32/runtests.py
[rename] https://crrev.com/6f776b2a04faede092dfb454616b1b6be2ee45c4/third_party/libxslt/src/xsltConf.sh.in

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dc73a8dc343ab19f7f88db4171df65a4e053ab6

commit 7dc73a8dc343ab19f7f88db4171df65a4e053ab6
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Wed Aug 02 16:02:36 2017

libxslt: Update License File's location.

libxslt's source code was moved to src/ in commit 6f776b2a04faed ("Check in
the libxslt roll script"), but README.chromium wasn't updated to point to
the license file's new location.

Bug:  708393 
Change-Id: I041569545e3c9d536b826bfaa198605ba5ca6a88
Reviewed-on: https://chromium-review.googlesource.com/597848
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491388}
[modify] https://crrev.com/7dc73a8dc343ab19f7f88db4171df65a4e053ab6/third_party/libxslt/README.chromium

Sign in to add a comment