New issue
Advanced search Search tips

Issue 708389 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

WebVector API surface should match std:: containers where possible.

Project Member Reported by slangley@chromium.org, Apr 5 2017

Issue description

WebVector is a shim around std::vector and no longer serves any useful purpose - we should remove it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/459f82aea36f5e53298407cb3831ec0f2d22c3ef

commit 459f82aea36f5e53298407cb3831ec0f2d22c3ef
Author: slangley <slangley@chromium.org>
Date: Wed Apr 05 08:48:05 2017

Provide a std::vector compliant empty() method for WebVector.

Provide a std::vector compliant empty() method for WebVector, start moving code
over to use it. This is preperation to completely replace WebVector with
std::vector, as this abstraction is no longer useful

BUG= 708389 

Review-Url: https://codereview.chromium.org/2799553002
Cr-Commit-Position: refs/heads/master@{#462011}

[modify] https://crrev.com/459f82aea36f5e53298407cb3831ec0f2d22c3ef/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/459f82aea36f5e53298407cb3831ec0f2d22c3ef/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/459f82aea36f5e53298407cb3831ec0f2d22c3ef/third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp
[modify] https://crrev.com/459f82aea36f5e53298407cb3831ec0f2d22c3ef/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
[modify] https://crrev.com/459f82aea36f5e53298407cb3831ec0f2d22c3ef/third_party/WebKit/Source/web/WebDocument.cpp
[modify] https://crrev.com/459f82aea36f5e53298407cb3831ec0f2d22c3ef/third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h
[modify] https://crrev.com/459f82aea36f5e53298407cb3831ec0f2d22c3ef/third_party/WebKit/public/platform/WebMediaConstraints.h
[modify] https://crrev.com/459f82aea36f5e53298407cb3831ec0f2d22c3ef/third_party/WebKit/public/platform/WebVector.h

Summary: WebVector API surface should match std:: containers where possible. (was: Remove WebVector)
Common wisdom is that it's not a great idea to remove WebVector, so let's just make the API consistent with developer expectations.
Status: WontFix (was: Assigned)

Sign in to add a comment