New issue
Advanced search Search tips

Issue 708379 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX

Blocked on:
issue 571506

Blocking:
issue 571533



Sign in to add a comment

Rename PageInfoPopupView to PageInfoBubbleView

Project Member Reported by lgar...@chromium.org, Apr 5 2017

Issue description

Consistency
 
Summary: Rename PageInfoPopupView to PageInfoBubbleView (was: Rename PageInfoPopupView to PageInfoBubble)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/026e9c4a99abfba45671badb3e0ec8fa2f0b672f

commit 026e9c4a99abfba45671badb3e0ec8fa2f0b672f
Author: lgarron <lgarron@chromium.org>
Date: Fri Apr 07 20:09:31 2017

Rename PageInfoPopupView to PageInfoBubbleView.

Also renames PageInfoPopupViewBrowserTest to PageInfoBubbleViewBrowserTest.

BUG= 708379 

Review-Url: https://codereview.chromium.org/2797923003
Cr-Commit-Position: refs/heads/master@{#462977}

[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/page_info/page_info_unittest.cc
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/browser_dialogs_views_mac.cc
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/page_info/chosen_object_row.cc
[rename] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[rename] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[rename] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/page_info/page_info_bubble_view_interactive_uitest.cc
[rename] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/page_info/permission_selector_row.cc
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/browser/ui/views/page_info/permission_selector_row.h
[modify] https://crrev.com/026e9c4a99abfba45671badb3e0ec8fa2f0b672f/chrome/test/BUILD.gn

Status: Fixed (was: Available)

Sign in to add a comment