This is going to 100% of stable in M57, so the flag and experiment stuff can all be cleaned up.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7131815b9cd8ff9257fe8f274f96e5b400b437e commit c7131815b9cd8ff9257fe8f274f96e5b400b437e Author: benwells <benwells@chromium.org> Date: Tue May 16 08:42:23 2017 Enable search geolocation consistency by default BUG= 708375 Review-Url: https://codereview.chromium.org/2878503005 Cr-Commit-Position: refs/heads/master@{#472044} [modify] https://crrev.com/c7131815b9cd8ff9257fe8f274f96e5b400b437e/chrome/common/chrome_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3500da4e1d21348bf5f93b022842364b8902b4e0 commit 3500da4e1d21348bf5f93b022842364b8902b4e0 Author: benwells <benwells@chromium.org> Date: Wed May 17 23:47:41 2017 Remove the old search geolocation disclosure text. This text was left in to use as control in experiments but is not being used. BUG= 708375 Review-Url: https://codereview.chromium.org/2887083002 Cr-Commit-Position: refs/heads/master@{#472603} [modify] https://crrev.com/3500da4e1d21348bf5f93b022842364b8902b4e0/chrome/app/generated_resources.grd [modify] https://crrev.com/3500da4e1d21348bf5f93b022842364b8902b4e0/chrome/browser/android/search_geolocation/search_geolocation_disclosure_infobar_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52e21e3b33349a4914866623a30a80c4e559ef33 commit 52e21e3b33349a4914866623a30a80c4e559ef33 Author: Ben Wells <benwells@chromium.org> Date: Mon Sep 04 02:18:21 2017 Remove feature, flag and experiment for search geolocation consistency This has been enabled by default and launched since M59. Bug: 708375 Change-Id: I5e3d785f076a861a488e8592c428eaefe6ae0157 Reviewed-on: https://chromium-review.googlesource.com/644670 Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#499425} [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java [delete] https://crrev.com/f6b13d81492b18b46ad2a9c45ea03c1b49f2b115/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/java_sources.gni [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/about_flags.cc [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/android/search_geolocation/search_geolocation_service.cc [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/android/search_geolocation/search_geolocation_service.h [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/android/search_geolocation/search_geolocation_service_unittest.cc [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/flag_descriptions.h [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/browser/geolocation/geolocation_permission_context_unittest.cc [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/common/chrome_features.cc [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/chrome/common/chrome_features.h [modify] https://crrev.com/52e21e3b33349a4914866623a30a80c4e559ef33/testing/variations/fieldtrial_testing_config.json
Comment 1 by bugdroid1@chromium.org
, May 16 2017