Issue metadata
Sign in to add a comment
|
Rename page_info/PAGE_INFO files and constants to use an underscore. |
||||||||||||||||||||||
Issue descriptionThe Android `pageinfo` folder was renamed to page_info in https://codereview.chromium.org/2765733002 Since Issue 571506 was fixed, most desktop/cross-platform code uses page_info in the file name. There are some files and strings leftover: - pageinfo_strings.grdp - Image names like `pageinfo_good.png` - IDS_PAGEINFO* strings
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2e2a6510e391b9573fdba04f77cc1786660a8f5 commit f2e2a6510e391b9573fdba04f77cc1786660a8f5 Author: lgarron <lgarron@chromium.org> Date: Wed Apr 05 18:52:00 2017 Rename pageinfo_strings.grdp to page_info_strings.grdp BUG= 708368 Review-Url: https://codereview.chromium.org/2797063004 Cr-Commit-Position: refs/heads/master@{#462162} [modify] https://crrev.com/f2e2a6510e391b9573fdba04f77cc1786660a8f5/components/OWNERS [modify] https://crrev.com/f2e2a6510e391b9573fdba04f77cc1786660a8f5/components/components_strings.grd [rename] https://crrev.com/f2e2a6510e391b9573fdba04f77cc1786660a8f5/components/page_info_strings.grdp
,
Nov 10 2017
,
Nov 30 2017
I think it's okay to leave this inconsistency. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Apr 5 2017