New issue
Advanced search Search tips

Issue 708366 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Several fields in content::DropData need to be declared in IPC_TRAIT.

Project Member Reported by xingliu@chromium.org, Apr 5 2017

Issue description

Chrome Version: Chrome/59.0.3042.4
OS: All

In src/content/common/drag_traits.h, we probably miss the following declaration in the IPC_TRAIT for content::DropData.

did_originate_from_renderer
file_mime_types
file_contents_source_url

file_contents_source_url is fixed in CL: https://codereview.chromium.org/2803473003/

It is unclear of the influence of file_mime_types. But in general it won't break the content/download core code since the mechanism here is total unrelated to content/download and only used in drag and drop.


 
Also, we should rename this file to be covered by the ipc security owners
Components: -Content>Core Blink>DataTransfer
Status: Available (was: Untriaged)
I have started working on this.

Uploaded patch by adding missing fields of DropData.

https://codereview.chromium.org/2928353002/ 
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by pwnall@chromium.org, Jun 18 2018

Cc: pwnall@chromium.org
Status: WontFix (was: Untriaged)
dcheng@ commented in https://codereview.chromium.org/2928353002/ stating that the two remaining fields shouldn't be made IPC_TRAIT.

Sign in to add a comment