Screenshots

Deleted: Views.png 399 KB

	Views.png 399 KB View Download

Deleted: Cocoa.png 303 KB

	Cocoa.png 303 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f335b5f72ac30dfee258403ebae955eb162d1867

commit f335b5f72ac30dfee258403ebae955eb162d1867
Author: lgarron <lgarron@chromium.org>
Date: Mon Apr 24 21:07:36 2017

Page Info permissions: make font sizes and spacing more consistent.

1. Change font sizes for permission labels to be consistent to be larger on Views. (Cocoa was already larger.)
2. Change font sizes for permission details strings ("X in use" for cookies", permission decision strings like "Automatically blocked") to be smaller on Cocoa. (Views was already smaller.)
3. Use consistent vertical spacing for detail strings on Cocoa.

(Note: "Cookies" is not a permission, but uses similar layout code.)

BUG= 708358 

Review-Url: https://codereview.chromium.org/2834223002
Cr-Commit-Position: refs/heads/master@{#466763}

[modify] https://crrev.com/f335b5f72ac30dfee258403ebae955eb162d1867/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/f335b5f72ac30dfee258403ebae955eb162d1867/chrome/browser/ui/views/page_info/permission_selector_row.cc

Requesting a merge of f335b5f72ac30dfee258403ebae955eb162d1867 to M59 to include with the M59 permission embargo launch ( Issue 679877 ).

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3662335f27cc9303846d2c74f7554cdad90f5b99

commit 3662335f27cc9303846d2c74f7554cdad90f5b99
Author: Lucas Garron <lgarron@chromium.org>
Date: Tue Apr 25 21:46:31 2017

Page Info permissions: make font sizes and spacing more consistent.

1. Change font sizes for permission labels to be consistent to be larger on Views. (Cocoa was already larger.)
2. Change font sizes for permission details strings ("X in use" for cookies", permission decision strings like "Automatically blocked") to be smaller on Cocoa. (Views was already smaller.)
3. Use consistent vertical spacing for detail strings on Cocoa.

(Note: "Cookies" is not a permission, but uses similar layout code.)

BUG= 708358 

Review-Url: https://codereview.chromium.org/2834223002
Cr-Commit-Position: refs/heads/master@{#466763}
(cherry picked from commit f335b5f72ac30dfee258403ebae955eb162d1867)

Review-Url: https://codereview.chromium.org/2842893002 .
Cr-Commit-Position: refs/branch-heads/3071@{#207}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/3662335f27cc9303846d2c74f7554cdad90f5b99/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/3662335f27cc9303846d2c74f7554cdad90f5b99/chrome/browser/ui/views/page_info/permission_selector_row.cc