New issue
Advanced search Search tips

Issue 708354 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

--disable-extensions-except assumes extensions load asynchronously

Project Member Reported by michae...@chromium.org, Apr 5 2017

Issue description

--disable-extensions-except causes the extensions at the given paths to be loaded and then added to a whitelist.

If the extension finishes being installed synchronously, then it is added to the ExtensionService before the whitelist is updated, so it is not enabled. (The whitelist uses the extension ID, so that may be why we add the ID to the whitelist after creating the Extension, but it creates this assumption.)

This works because UnpackedInstaller runs a RequirementsChecker check, which always posts its callback asynchronously. Is it valid to assume extensions are loaded from the command line asynchronously? Or can we allow checks like RequirementsChecker to finish synchronously?

The CL where this came up (because it caused DisableExtensionsExceptBrowserTest.DisableExtensionsExceptFlag to fail) is: https://codereview.chromium.org/2783813002/
 
It was mostly done this way out of ease, rather than out of a desire to enforce a rule.  I don't see a reason that changing this to behave properly in sync and async environments would be bad, so I'm happy to review a change to make it so, assuming there's a way of doing it without too much added complexity.
Cc: -catmulli...@chromium.org

Sign in to add a comment