Correct operation of SRC_URI in cros-firmware.eclass |
|||
Issue descriptionFrom vapier's comment in: https://chromium-review.googlesource.com/c/458899/10: SRC_URI must be immutable regardless of SYSROOT. so you'll have to figure out a diff way to do this This bug tracks that discussion and resolution.
,
Apr 5 2017
This package has a depend:
unibuild? ( chromeos-base/chromeos-config )
so I would expect the config file to be present when this ebuild is used. It does seem to work locally but perhaps it would have problems in a buildbot?
Ideas:
1. Is there a way to turn off the SRC_URI caching on this ebuild?
2. The whole SRC_URI thing does feel a bit brittle. Is there a way to manually download files given a URI?
3. I'd prefer to avoid doing all this processing before the ebuild is properly being run. Can we move it into a normal ebuild function so that it runs as part of src_prepare(), for example?
,
Apr 7 2017
Proposed approach is here: https://chromium-review.googlesource.com/c/470407/
,
Apr 8 2017
> so I would expect the config file to be present when this ebuild is used. It does seem to work locally but perhaps it would have problems in a buildbot? DEPEND/RDEPEND is irrelevant -- fetching is run independently & in parallel before anything is compiled or installed. this is an explicit design decision, and a good one imo. > 1. Is there a way to turn off the SRC_URI caching on this ebuild? no, nor does such a thing make sense > 2. The whole SRC_URI thing does feel a bit brittle. Is there a way to manually download files given a URI? we do not permit ebuilds/eclasses to download files themselves. it's a bad idea and does not play with caching, reliability, or security. > 3. I'd prefer to avoid doing all this processing before the ebuild is properly being run. Can we move it into a normal ebuild function so that it runs as part of src_prepare(), for example? also not feasible or desirable
,
Apr 10 2017
I've done a change that relies only the source files via a symlink and does not access the root. Hopefully this will resolve this issue. https://chromium-review.googlesource.com/c/458899/
,
Apr 12 2017
Seems to work OK, so I'm closing this. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sjg@chromium.org
, Apr 5 2017