New issue
Advanced search Search tips

Issue 708341 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 708151



Sign in to add a comment

Implement the omnibox in the new architecture

Project Member Reported by rohitrao@chromium.org, Apr 4 2017

Issue description

Umbrella bug for tracking omnibox-related work.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0

commit 74849bc2fdb3ebde47584620b9a1c8da0c72bcd0
Author: rohitrao <rohitrao@chromium.org>
Date: Wed Apr 05 16:57:09 2017

[ios] Adds LocationBarCoordinator.

This CL adds the basics of an omnibox to the clean skeleton app.  The toolbar
now contains a real OmniboxTextFieldIOS with its associated machinery
(OmniboxViewIOS and LocationBarController).  The URL in the omnibox is kept up
to date during navigation and across tab switches.  Typing in the omnibox and
pressing Go will also navigate to the default match.

The omnibox popup is not yet implemented, and neither are the animations when
the omnibox gains or loses focus.

BUG= 708341 

Review-Url: https://codereview.chromium.org/2761343002
Cr-Commit-Position: refs/heads/master@{#462119}

[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/BUILD.gn
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/location_bar_coordinator.h
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/location_bar_coordinator.mm
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/location_bar_coordinator_unittest.mm
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/location_bar_mediator.h
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/location_bar_mediator.mm
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/location_bar_mediator_unittest.mm
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/location_bar_view_controller.h
[add] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/omnibox/location_bar_view_controller.mm
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/clean/chrome/test/BUILD.gn
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/shared/chrome/browser/ui/browser_list/BUILD.gn
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/shared/chrome/browser/ui/browser_list/browser_web_state_list_delegate.mm
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/shared/chrome/browser/ui/omnibox/BUILD.gn
[modify] https://crrev.com/74849bc2fdb3ebde47584620b9a1c8da0c72bcd0/ios/shared/chrome/browser/ui/omnibox/location_bar_delegate.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7774ffbffc14fa93b82ef261a98d923b69db3209

commit 7774ffbffc14fa93b82ef261a98d923b69db3209
Author: Jean-François Geyelin <jif@chromium.org>
Date: Wed Jul 12 16:25:37 2017

[iOS] Prepare for the support of InputAssistantItems on iPad.

This CL cleans the Keyboard Accessory View (KAV) situation for the
web toolbar to support InputAssistantItems on iPad (1).
In particular, this CL:
- Removes keyboard_accessory_view.*.
  Now only new_keyboard_accessory_view.* is used.
- Removes HardwareKeyboardWatcher because it only works when there is
  a KAV (crbug.com/740898).
- Removes |-locationBarChanged| because it would only be used to
  record MobileFirstTextInOmnibox ( crbug.com/740611 ).
- Removes the |_keyboardAccessoryView| ivar. It was used when the KAV
  was not laid out with auto layout and had multiple modes.

(1) https://docs.google.com/document/d/1pWfwHEeCNeWgkDjawJiDoEf93gkDV9usINcYDyXvwcY/edit#heading=h.sku52p315l4d

Bug:  738106 ,  708341 ,  740611 
Change-Id: If6e509de3e6d57f0347b3e355b91af16bd055adb
Reviewed-on: https://chromium-review.googlesource.com/567087
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485989}
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/keyboard/BUILD.gn
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher.h
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher.mm
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher_unittest.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/BUILD.gn
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view.h
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm
[add] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/keyboard_accessory_view_delegate.h
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view_protocol.h
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.h
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/clean/chrome/browser/ui/omnibox/location_bar_mediator.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/shared/chrome/browser/ui/omnibox/location_bar_delegate.h

Status: WontFix (was: Started)
We're not doing the new architecture anymore. 

Sign in to add a comment