New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708337 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 708322



Sign in to add a comment

[Findit] Auto Revert - Metrics page does not show Findit Faster

Project Member Reported by lijeffrey@chromium.org, Apr 4 2017

Issue description

https://findit-for-me.appspot.com/waterfall/auto-revert-metrics

Shows Findit's revert CL was committed by a sheriff (meaning it was faster), but the metrics page says N/A for Findit faster.

Revert CLs Findit creates and committed should be counted in Findit's favor.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b3bb6aebeb2855ddafdbf2a4359e6a9695b6b249

commit b3bb6aebeb2855ddafdbf2a4359e6a9695b6b249
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Tue Apr 04 23:28:44 2017

[Findit] Auto Revert - Fix metrics page to show Findit faster times

Bug:708337

Change-Id: I106f5f38ad1aec6af39e64a5c4ebfcba96cc4328
Reviewed-on: https://chromium-review.googlesource.com/468308
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/b3bb6aebeb2855ddafdbf2a4359e6a9695b6b249/appengine/findit/handlers/auto_revert_metrics.py
[modify] https://crrev.com/b3bb6aebeb2855ddafdbf2a4359e6a9695b6b249/appengine/findit/templates/auto_revert_metrics.html

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b3bb6aebeb2855ddafdbf2a4359e6a9695b6b249

commit b3bb6aebeb2855ddafdbf2a4359e6a9695b6b249
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Tue Apr 04 23:28:44 2017

[Findit] Auto Revert - Fix metrics page to show Findit faster times

Bug:708337

Change-Id: I106f5f38ad1aec6af39e64a5c4ebfcba96cc4328
Reviewed-on: https://chromium-review.googlesource.com/468308
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/b3bb6aebeb2855ddafdbf2a4359e6a9695b6b249/appengine/findit/handlers/auto_revert_metrics.py
[modify] https://crrev.com/b3bb6aebeb2855ddafdbf2a4359e6a9695b6b249/appengine/findit/templates/auto_revert_metrics.html

Status: Verified (was: Assigned)

Sign in to add a comment