New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 708334 link

Starred by 1 user
Status: Verified
Owner:
█ morsed@chromium.org
User never visited
Closed: Apr 2017
Cc:
abodenha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Rollback internationalization change due to size increase of image

Project Member Reported by weifangsun@chromium.org, Apr 4 2017 
Per "Chrome OS Installer Perf Sheriff: 2 anomalies found at 2147483647:30540000940900000." email thread -

We should rollback the changes (likely from  crbug.com/673077 ) as it has added 15MB to the current system image.

We will explore alternate solutions to supporting broader internationalization for Get Help on the follow.

Comment 1 by morsed@google.com, Apr 5 2017

Status: Started (was: Assigned)
For the record, here are the file size increases going from 19 languages for the Get Help app and 16 for the HelpApp to 53 locales for both. Images are largely inconsequential.  The increase was almost entirely text for the Get Help articles going from 6.9mb to 20.4mb (+13.5mb).  Get Help internal content went from 364.7kb to 1.2mb (+836kb).  HelpApp text went from 988.7kb to 2.9mb (+1.9mb).  In all, it's a bit over 16mb for both apps. 


**WITH 53 LANGUAGES...

landed in M59 with 9409.0.0/59.0.3054.0 on 2017-03-28, Tuesday  

HelpApp

chromiumos/src/platform/chromeos-assets/helpapp/offline
168 items, totalling 2.9 MB
chromiumos/src/platform/chromeos-assets/helpapp/offline/images
60 items, totalling 23.2 kB


Get Help app

chromiumos/src/platform/chromeos-assets/genius_app/offline (gKMS/Redwood articles)
433 items, totalling 20.4 MB
chromiumos/src/platform/chromeos-assets/genius_app/offline/images (article images)
272 items, totalling 145.2 kB
chromiumos/src/platform/chromeos-assets/genius_app/_locales (internal Get Help app content, Discover section)
106 items, totalling 1.2 MB


**WITH ORIGINAL LANGUAGES...

HelpApp

chromiumos/src/platform/chromeos-assets/helpapp/offline
74 items, totalling 988.7 kB
chromiumos/src/platform/chromeos-assets/helpapp/offline/images
34 items, totalling 19.5 kB


Get Help app

chromiumos/src/platform/chromeos-assets/genius_app/offline (gKMS/Redwood articles) 
273 items, totalling 6.9 MB 
chromiumos/src/platform/chromeos-assets/genius_app/offline/images (article images)
214 items, totalling 130.7 kB 
chromiumos/src/platform/chromeos-assets/genius_app/_locales (internal Get Help app content, Discover section)
38 items, totalling 364.7 kB

Comment 2 by morsed@google.com, Apr 6 2017 

google3 changelist http://cl/152412546 has been rolled back

Comment 3 by morsed@google.com, Apr 14 2017

Status: Fixed (was: Started)
landed in M59 as per this commit: https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/ce2882231653620cd971b84f8f81eefcebb8f70f

Comment 4 by abod...@chromium.org, May 16 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment