New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 708332 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Apr 2017
Cc:
█ megjab...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 702799



Sign in to add a comment

Fix measuring of overflow menu when footer is present

Project Member Reported by megjab...@chromium.org, Apr 4 2017 
When a footer is on the overflow menu it should take up the full height of the screen and clip half of the last item. In small screens, if the available vertical space for the menu is smaller than 230dp, we should omit the footer, so at least 3 menu items are visible.

If possible for M59, we would also like to be able to support a transparent footer that shows the menu items underneath it.

specs: https://bbergher.googleplex.com/specs/data-saver/overflow-menu/static/

slides: https://docs.google.com/presentation/d/1frp7uNe1e4RVfDmJLNgIo-rOiHF05LbIsqzp19AEzuo/edit#slide=id.g1c01a7095c_3_7
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb2bf86d665fddf7e580cb67f6be8f3c182188b7

commit fb2bf86d665fddf7e580cb67f6be8f3c182188b7
Author: tedchoc <tedchoc@chromium.org>
Date: Mon Apr 10 22:48:00 2017

Fix menu sizing for data saver footer.

First off, the footer sizing has been broken because setMenuHeight
was not adding the footer size to the max available space.

Secondly, this hides the data saver footer if the screen size is
under 240dp (differs from the spec of 230dp as that resulted in
a menu with 2.5 options based on the menu padding and logic to
hide the last of the half row if not enough space).

BUG= 708332 

Review-Url: https://codereview.chromium.org/2807123003
Cr-Commit-Position: refs/heads/master@{#463429}

[modify] https://crrev.com/fb2bf86d665fddf7e580cb67f6be8f3c182188b7/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/fb2bf86d665fddf7e580cb67f6be8f3c182188b7/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/fb2bf86d665fddf7e580cb67f6be8f3c182188b7/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
[modify] https://crrev.com/fb2bf86d665fddf7e580cb67f6be8f3c182188b7/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
[modify] https://crrev.com/fb2bf86d665fddf7e580cb67f6be8f3c182188b7/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/fb2bf86d665fddf7e580cb67f6be8f3c182188b7/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferences.java

Comment 2 by tedc...@chromium.org, Apr 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment