RecentTabsPanelController, BookmarkHomeTabletNTPController, IncognitoPanelController, GoogleLandingController
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/892f16d9e2e43c6d3e410b1cf974391fbe26998a commit 892f16d9e2e43c6d3e410b1cf974391fbe26998a Author: justincohen <justincohen@chromium.org> Date: Tue Apr 18 01:00:50 2017 Convert bookmarks NTP panel to UIViewController. Followup to codereview.chromium.org/2806153004, also convert the bookmarks panel. BUG= 708319 Review-Url: https://codereview.chromium.org/2821063002 Cr-Commit-Position: refs/heads/master@{#465086} [modify] https://crrev.com/892f16d9e2e43c6d3e410b1cf974391fbe26998a/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.h [modify] https://crrev.com/892f16d9e2e43c6d3e410b1cf974391fbe26998a/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm [modify] https://crrev.com/892f16d9e2e43c6d3e410b1cf974391fbe26998a/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.h [modify] https://crrev.com/892f16d9e2e43c6d3e410b1cf974391fbe26998a/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm [modify] https://crrev.com/892f16d9e2e43c6d3e410b1cf974391fbe26998a/ios/chrome/browser/ui/ntp/new_tab_page_controller.h [modify] https://crrev.com/892f16d9e2e43c6d3e410b1cf974391fbe26998a/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/892f16d9e2e43c6d3e410b1cf974391fbe26998a/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm [modify] https://crrev.com/892f16d9e2e43c6d3e410b1cf974391fbe26998a/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc913634cadc4ac06b3637b2025129d1c513bf65 commit bc913634cadc4ac06b3637b2025129d1c513bf65 Author: justincohen <justincohen@chromium.org> Date: Tue Apr 18 14:41:45 2017 Fix NTP parentViewController. NTP.parentViewController can be accessed during init, so setting this as a property after init is too late. BUG= 708319 Review-Url: https://codereview.chromium.org/2820063003 Cr-Commit-Position: refs/heads/master@{#465232} [modify] https://crrev.com/bc913634cadc4ac06b3637b2025129d1c513bf65/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/bc913634cadc4ac06b3637b2025129d1c513bf65/ios/chrome/browser/ui/ntp/new_tab_page_controller.h [modify] https://crrev.com/bc913634cadc4ac06b3637b2025129d1c513bf65/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/bc913634cadc4ac06b3637b2025129d1c513bf65/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4287fc3f51190e6e8c698e36903b47c464596b1 commit d4287fc3f51190e6e8c698e36903b47c464596b1 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Aug 29 09:14:42 2017 Add coordinator for recent tabs RecentTabPanelViewController used a wrapper to display the status bar. This CL removes the wrapper and use the ViewController directly. It also adds a coordinator to wrap the view controller. Bug: 708319 Change-Id: Id2297026f52659640cc03b3bfe3d72952c9c3355 Reviewed-on: https://chromium-review.googlesource.com/633236 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#498059} [modify] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [add] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.h [add] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm [add] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.h [add] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.mm [delete] https://crrev.com/60ee9a090c8bf6fe40f16ee1b6e0b29533ead16f/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_view_controller.h [delete] https://crrev.com/60ee9a090c8bf6fe40f16ee1b6e0b29533ead16f/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_view_controller.mm [modify] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4 commit fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Aug 29 11:01:45 2017 Transform RecentTabsController to coordinator Bug: 708319 Change-Id: Iadc97eeedaa1c52425ba3b05239c02d6eec1bafe Reviewed-on: https://chromium-review.googlesource.com/635031 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#498071} [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_bridges.h [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_bridges.mm [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.h [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.mm [rename] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.h [rename] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.mm [rename] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator_unittest.mm [rename] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/browser/ui/sync/synced_sessions_bridge.h [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/test/BUILD.gn [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/chrome/test/earl_grey/chrome_test_case.mm [modify] https://crrev.com/fb27c0d528e4816ca4cd1b4f3f39da0fa633d5d4/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8160349c62f4b009982930d64225764916577f61 commit 8160349c62f4b009982930d64225764916577f61 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 06 14:43:24 2017 Cleanup WebToolbarDelegate WebToolbarDelegate has a bunch of not used methods and method that does not belong in it. This CL cleans it and removes the dependency of the incognito panel on it. Bug: 708319 Change-Id: Iea84ab8d15eadaebabe1c4856d02d3dd39606f76 Reviewed-on: https://chromium-review.googlesource.com/649652 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#499960} [modify] https://crrev.com/8160349c62f4b009982930d64225764916577f61/ios/chrome/app/main_controller.mm [modify] https://crrev.com/8160349c62f4b009982930d64225764916577f61/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/8160349c62f4b009982930d64225764916577f61/ios/chrome/browser/ui/ntp/incognito_panel_controller.h [modify] https://crrev.com/8160349c62f4b009982930d64225764916577f61/ios/chrome/browser/ui/ntp/incognito_panel_controller.mm [modify] https://crrev.com/8160349c62f4b009982930d64225764916577f61/ios/chrome/browser/ui/ntp/new_tab_page_controller.h [modify] https://crrev.com/8160349c62f4b009982930d64225764916577f61/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/8160349c62f4b009982930d64225764916577f61/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm [modify] https://crrev.com/8160349c62f4b009982930d64225764916577f61/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33720dd3fde1ea19231807611fc15c71a13929ac commit 33720dd3fde1ea19231807611fc15c71a13929ac Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 06 15:36:51 2017 Convert IncognitoController to ViewController Bug: 708319 Change-Id: I9d3067ff016b3e136c36188e24abe3768eadf14e Reviewed-on: https://chromium-review.googlesource.com/649696 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#499970} [modify] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/ntp/BUILD.gn [delete] https://crrev.com/d01eda1692dec29b995ec0b235592ddd9829ab14/ios/chrome/browser/ui/ntp/incognito_panel_controller.h [add] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/ntp/incognito_view.h [rename] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/ntp/incognito_view.mm [add] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/ntp/incognito_view_controller.h [add] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/ntp/incognito_view_controller.mm [modify] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.h [modify] https://crrev.com/33720dd3fde1ea19231807611fc15c71a13929ac/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.h
All should be converted now.
Comment 1 by justincohen@chromium.org
, Apr 4 2017