New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708313 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Replace chell-paladin with cave-paladin with HWTest enabled

Project Member Reported by philipchen@chromium.org, Apr 4 2017

Issue description

Recently we have this issue in the lab:
https://bugs.chromium.org/p/chromium/issues/detail?id=707594

The cause is that these 3 CLs snuck through CQ: 
https://chromium-review.googlesource.com/467888
https://chromium-review.googlesource.com/467889
https://chromium-review.googlesource.com/467890

Can we add HWTest in chell-paladin so we can capture bad CLs next time?

 
Cc: jrbarnette@chromium.org
Owner: bhthompson@chromium.org
I think Bernie started to enable this a while back. I'm not sure what the blocker was.
Status: Assigned (was: Untriaged)
$ board_pools chell
      6 bvt
     14 cts
      7 suites

There aren't enough spare chell DUTs to supply the CQ.

It looks like the spares have been appropriated to run CTS
tests.  That's likely to be more important.  That should mean
that eventually there will be some chell DUTs added to back-fill
the appropriation.

I should note that as a rule we don't test every board on the
CQ, so it's not clear that we'll just add chell even if the DUTs
are available.  But until the DUTs are available, nothing can
happen.

We needed (need) a builder to take over for mario-nowithdebug, so I had a cl for that which never landed, but I am not sure about hwtest on the chell paladin.

I dont see a skl system running hwtest in the cq so chell would be a good candidate, if not we can swap it for something else like sentry or caroline, any recommedations?

If we can fit it, adding caroline would be good, it would get us more ARC++ coverage as well. 
AFAICT, cave is the only board with sufficient supply to do more:

$ board_pools cave    
      6 bvt
     20 cts
      1 performance
     21 suites
      1 wificell
$ board_pools caroline
      6 bvt
     18 cts
      6 suites
$ board_pools cyan 
     18 bvt
      6 cq
     12 cts
      3 suites

We can do cave, if you can allocate to support a hwtest paladin, I will put together a CL series to perform the transition. 

Add cave-paladin builder (with HWTest)
Make cave-paladin builder important
Make chell-paladin builder experimental
Remove chell-paladin builder

Summary: Replace chell-paladin with cave-paladin with HWTest enabled (was: Add HWTest for chell-paladin)
> Add cave-paladin builder (with HWTest)

For this, we should make it run only bvt-inline for now,
to keep the supply requirement manageable.  Take a look
at how elm and kevin do it:
  ShardHWTestsBetweenBuilders('elm-paladin', None)
  ShardHWTestsBetweenBuilders('kevin-paladin', None)

Upload that first CL, and I can allocate the CQ pool for
cave.

https://chromium-review.googlesource.com/#/c/471934/ and https://chromium-review.googlesource.com/#/c/471935/ should do it.

I think we want to leave chell-paladin there though, unless we also want to take chell off of the chrome PFQ (IIRC chromite does not like it if there is a PFQ builder without a corresponding paladin).
Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c9782046486328a600fd1d69a9baf19e80dd5e51

commit c9782046486328a600fd1d69a9baf19e80dd5e51
Author: Bernie Thompson <bhthompson@google.com>
Date: Tue May 02 02:18:20 2017

Make cave-paladin builder important

BUG= chromium:708313 
TEST=None

Change-Id: I3b40036675c7495d8d553ab44d00e37861c902f6
Reviewed-on: https://chromium-review.googlesource.com/471935
Commit-Ready: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/c9782046486328a600fd1d69a9baf19e80dd5e51/cbuildbot/config_dump.json
[modify] https://crrev.com/c9782046486328a600fd1d69a9baf19e80dd5e51/cbuildbot/chromeos_config.py

Project Member

Comment 11 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c9782046486328a600fd1d69a9baf19e80dd5e51

commit c9782046486328a600fd1d69a9baf19e80dd5e51
Author: Bernie Thompson <bhthompson@google.com>
Date: Tue May 02 02:18:20 2017

Make cave-paladin builder important

BUG= chromium:708313 
TEST=None

Change-Id: I3b40036675c7495d8d553ab44d00e37861c902f6
Reviewed-on: https://chromium-review.googlesource.com/471935
Commit-Ready: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/c9782046486328a600fd1d69a9baf19e80dd5e51/cbuildbot/config_dump.json
[modify] https://crrev.com/c9782046486328a600fd1d69a9baf19e80dd5e51/cbuildbot/chromeos_config.py

Status: Fixed (was: Assigned)

Sign in to add a comment