New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708307 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Get rid of web::HttpServer and use EmbeddedTestServer directly

Project Member Reported by huangml@chromium.org, Apr 4 2017

Issue description

We are switching to use the chromium EmbeddedTestServer for tests.  

Currently we have a wrapper around GCDWebServer. There would be a lot of test changes if we move to EmbeddedTestServer directly.  To make the switch smooth, we'll change this wrapper to use chromium EmbeddedTestServer for the existing tests and deprecate it. For any new tests, we'll use embedded test server directly instead of calling this wrapper.

We would want to eventually get rid of this wrapper and update all tests to use the new server directly.
 
Description: Show this description
Components: Test>iOS

Comment 3 by sczs@chromium.org, Apr 5 2017

Status: Assigned (was: Untriaged)
Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00986c02444e4a89e4c6f1f37ae7dc8e18dc866a

commit 00986c02444e4a89e4c6f1f37ae7dc8e18dc866a
Author: Eugene But <eugenebut@google.com>
Date: Fri Feb 02 19:22:50 2018

Convert NavigationAndLoadCallbacksTest to use EmbeddedTestServer.

NavigationAndLoadCallbacksTest used deprecated web::HttpServer.

Bug:  708307 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I817cf817467bde8e531e75a19d866c43daac7412
Reviewed-on: https://chromium-review.googlesource.com/899604
Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534121}
[modify] https://crrev.com/00986c02444e4a89e4c6f1f37ae7dc8e18dc866a/ios/web/web_state/navigation_and_load_callbacks_inttest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment