New issue
Advanced search Search tips

Issue 708306 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 707632



Sign in to add a comment

setValueCurveAtTime curve should be sequence<float>

Project Member Reported by rtoy@chromium.org, Apr 4 2017

Issue description

Non-finite values are not allowed for the curve in setValueCurveAtTime.

See the issue https://github.com/WebAudio/web-audio-api/issues/1171

The merge request to fix this is https://github.com/WebAudio/web-audio-api/pull/1189
 

Comment 1 by rtoy@chromium.org, Apr 4 2017

Blockedon: 707632
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece

commit e78f7c1cc5587c0a09ca68b9519a45b1c3238ece
Author: rtoy <rtoy@chromium.org>
Date: Thu Apr 13 19:31:35 2017

setValueCurveAtTime takes sequence<float> for curve

Instead of a Float32Array, the curve parameter for an
AudioParam.setValueCurveAtTime method is now a sequence<float>.  This
also implies that only finite values for the curve.

This change is (mostly) backward compatible since Float32Array is a
sequence<float>.

Added a test to verify that we throw an error if the curve contains a
non-finite value.

BUG= 708306 
TEST=AudioParam/audioparam-exceptional-values.html

Review-Url: https://codereview.chromium.org/2789883002
Cr-Commit-Position: refs/heads/master@{#464504}

[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/Source/modules/webaudio/AudioParam.idl
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

Comment 3 by rtoy@chromium.org, Apr 14 2017

Status: Fixed (was: Started)

Sign in to add a comment