[Large text entry] Page is loading very slowly when user name is too long. |
|||||||
Issue descriptionRepro steps: - Login to Chrome. - Go to chrome://md-settings/manageProfile - Change the name to a very very large string - Reload the page. Actual: Page is extremely slow to load. Expected: Page should load normally. I am suspecting that this has to do with the long text being processed by Blink for the purposes of elliding. See similar issue from the MD Downloads case at issue 659636 . Probably the same behavior can be reproduced for a very long startup URL (or any other place in the MD Settings page where a very long string can appear), need to investigate.
,
Apr 4 2017
dschuyler@ and tommycli@ and I just discussed this In an ideal world, we would let anybody enter their full name, regardless of length. But arbitrarily sized content is more problematic (exploited) than it is useful in my experience. The places where a very very large name (see: the text of a novel) would be bad: - rendering (text-overflow: ellipsis is hella slow) - IPC - bloating of pref file size - anywhere that doesn't handle large N values so capping to some sane value (especially when displaying, possibly when transmitting or saving) seems fine to me. If somebody with >1024 character name files a bug with legal ID, I'd be happy to look into a fix for them.
,
Apr 10 2017
So we're going to cap the length we allow to be entered / loaded? Seems reasonable to me. Not sure clipping is reasonable for things like URLs though. What can we do in those cases?
,
Apr 10 2017
,
May 27 2017
Related Issue 575606
,
May 27 2017
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90ea2e1a8dbd3e962acbedc97f50277396602e32 commit 90ea2e1a8dbd3e962acbedc97f50277396602e32 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Jan 05 01:54:38 2018 [MD settings] limit the profile name input This CL limits the profile name input to 500 characters. This value is well beyond what is necessary and serves as a guard against absurd (accidental?) entries which can make the page appear to freeze/crash. Bug: 708304 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5751a7f9bfbd4b594e9761ee18f46d4c2173390f Reviewed-on: https://chromium-review.googlesource.com/851268 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#527187} [modify] https://crrev.com/90ea2e1a8dbd3e962acbedc97f50277396602e32/chrome/browser/resources/settings/people_page/manage_profile.html
,
Jan 5 2018
I did a few internet searches about the longest legal names. I limited the input to 500 characters since that seems far beyond what is necessary and is still relatively small.
,
Jan 5 2018
,
Jan 8 2018
Tested the issue on Windows 10, Mac 10.12.6 and Ubuntu 14.04 using Chrome version M65 - 65.0.3314.0 as per the issue mentioned in original comment and Comment #7. Observed that issue is working as intended (Maximum 500 character can be saved as Profile Name in 'chrome://settings/manageProfile' page and refreshing the page will load screen normally). Hence adding TE-Verified label. Attached the screencast for reference. Thank you! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dpa...@chromium.org
, Apr 4 2017