New issue
Advanced search Search tips

Issue 708301 link

Starred by 2 users
Status: Archived
Owner:
martiniss@chromium.org
Closed: May 2017
Cc:
nedngu...@google.com
seanmccullough@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SOM should show how many times a test has failed

Project Member Reported by martiniss@chromium.org, Apr 4 2017 
Currently it just shows "50 since first detection", but we should show something like "failed 13 out of the last 50 builds". It gives sheriffs more information, and gives them some measure of flakiness.

I think the data is already here, so it should just be a server side change. I'll see though.

Comment 1 by nedngu...@google.com, Apr 4 2017

Components: Speed>Benchmarks>Waterfall

Comment 2 by martiniss@chromium.org, Apr 11 2017

Status: Started (was: Assigned)
Have a CL out for this.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e2fd7586f428255bbf4fb495734b7de70be36cae

commit e2fd7586f428255bbf4fb495734b7de70be36cae
Author: Stephen Martinis <martiniss@google.com>
Date: Tue Apr 11 19:12:27 2017

AD: Count number of failures

This CL makes alerts dispatcher count the number of times a step fails
on a builder. This is useful information, to know if the step is
consistently failing, or just flakily failing.

Bug:  708301 
Change-Id: Ica498247d69ac63561613edeec2af5babb2dde85
Reviewed-on: https://chromium-review.googlesource.com/474168
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/test/som-app-test.html
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.js
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/monitoring/analyzer/analyzer_test.go
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/monitoring/messages/alerts.go
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/monitoring/analyzer/analyzer.go
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e2fd7586f428255bbf4fb495734b7de70be36cae

commit e2fd7586f428255bbf4fb495734b7de70be36cae
Author: Stephen Martinis <martiniss@google.com>
Date: Tue Apr 11 19:12:27 2017

AD: Count number of failures

This CL makes alerts dispatcher count the number of times a step fails
on a builder. This is useful information, to know if the step is
consistently failing, or just flakily failing.

Bug:  708301 
Change-Id: Ica498247d69ac63561613edeec2af5babb2dde85
Reviewed-on: https://chromium-review.googlesource.com/474168
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/test/som-app-test.html
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.js
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/monitoring/analyzer/analyzer_test.go
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/monitoring/messages/alerts.go
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/e2fd7586f428255bbf4fb495734b7de70be36cae/go/src/infra/monitoring/analyzer/analyzer.go

Comment 5 by seanmccullough@chromium.org, Apr 24 2017

Labels: Milestone-UX
is this fixed?

Comment 6 by martiniss@chromium.org, May 19 2017

Status: Fixed (was: Started)
Yes, this is fixed!

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment