New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708300 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-08-27
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 712288



Sign in to add a comment

Add benchmark to cover important stories in emerging market

Project Member Reported by ssid@chromium.org, Apr 4 2017

Issue description

We need better stories that cover the sites that are used a lot on mobile devices in emerging markets. This is important to track the Chrome slimming work.
 
Components: -Speed>Telemetry Speed>Benchmarks
Labels: LowMemory
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43069309920d7d079ec2b9417c11b64cae1d47d5

commit 43069309920d7d079ec2b9417c11b64cae1d47d5
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Apr 13 23:20:46 2017

Roll src/third_party/catapult/ 30a617a76..137b8fd0f (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/30a617a768a1..137b8fd0fd76

$ git log 30a617a76..137b8fd0f --date=short --no-merges --format='%ad %ae %s'
2017-04-13 sullivan Ignore benchmark 'names' from spreadsheet header.
2017-04-13 ssid Expose AppUi from devil utils in browser

Created with:
  roll-dep src/third_party/catapult
BUG=708300


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I813aa0717c5dcfd3d1048fd6b5ed2ce421f91c09
Reviewed-on: https://chromium-review.googlesource.com/477610
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464602}
[modify] https://crrev.com/43069309920d7d079ec2b9417c11b64cae1d47d5/DEPS

Comment 4 by ssid@chromium.org, Apr 17 2017

Flipkart story is failing for some reason on bots and not reproducible locally. So, disabling it for now.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/672c3e952db98d1fb73168a8bbd12d84dbf11725

commit 672c3e952db98d1fb73168a8bbd12d84dbf11725
Author: ssid <ssid@chromium.org>
Date: Mon Apr 17 18:32:13 2017

Increase the limit of command line file size

On a release channel chrome we could have field trials that take upto
10KB of the command line file. Adding browser features on telemetry
scripts sometimes take upto 4K. So, increase the limit on command line
file size.

BUG= 688230 ,708300

Review-Url: https://codereview.chromium.org/2817143002
Cr-Commit-Position: refs/heads/master@{#464956}

[modify] https://crrev.com/672c3e952db98d1fb73168a8bbd12d84dbf11725/base/android/java/src/org/chromium/base/CommandLine.java

Comment 6 by ssid@chromium.org, Apr 17 2017

Blockedon: 712288
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c96514f650b4db1f6abebf0d6b307d65bca3e5b

commit 2c96514f650b4db1f6abebf0d6b307d65bca3e5b
Author: ssid <ssid@chromium.org>
Date: Mon Apr 17 20:42:42 2017

Add System health stories for Emerging market

This CL adds system health stories which are important for emerging
market.

BUG=708300, 709436 

Review-Url: https://codereview.chromium.org/2787103003
Cr-Commit-Position: refs/heads/master@{#465012}

[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile.json
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_053.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_055.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_056.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_058.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_059.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_060.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_061.wpr.sha1
[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/system_health/browsing_stories.py
[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/system_health/loading_stories.py
[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/system_health/searching_stories.py
[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/system_health/story_tags.py

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6869120a3a97c50c14188109cd32987bf7f27bb7

commit 6869120a3a97c50c14188109cd32987bf7f27bb7
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Apr 26 23:38:18 2017

Roll src/third_party/catapult/ abff3b492..685851048 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/abff3b4929c7..6858510487e6

$ git log abff3b492..685851048 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 ssid Fix android_action_runner.InputSwipe and InputText

Created with:
  roll-dep src/third_party/catapult
BUG=708300, 712590 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic97851766db7f7a5b0d49cb2ee74b936220f1d34
Reviewed-on: https://chromium-review.googlesource.com/487731
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467510}
[modify] https://crrev.com/6869120a3a97c50c14188109cd32987bf7f27bb7/DEPS

Status: Assigned (was: Untriaged)
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1316e485a40000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itdJzTzM/tmpczC_9Etelemetry/histograms.json'
Looks like the tryjob was misconfigured:

https://chrome-swarming.appspot.com/task?id=3ecc1de40e8ddb10&refresh=10&show_raw=1
No benchmark named "system_health.common_mobile/browse:shopping:flipkart

I'll try re-running (attaching screenshot of what the dialog should look like)

Screen Shot 2018-07-23 at 1.02.15 PM.png
47.3 KB View Download
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/149ff11ba40000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14b32edda40000
All runs failed with JavaScript timeout.
Attached is a failure screenshot from the time of the timeout.

Here's the actual line that we're timing out on: https://cs.chromium.org/chromium/src/tools/perf/page_sets/system_health/browsing_stories.py?type=cs&q=browsing_stories.py:524&sq=package:chromium&g=0&l=524

It looks like we're timing out waiting for an element to appear with the text "Details".

ssid@, could you please investigate what's going on here? The failure screenshot indeed doesn't show any details link. Maybe we need to wait longer, or we're searching for the wrong text?
timeout.png
294 KB View Download
NextAction: 2018-08-27
The NextAction date has arrived: 2018-08-27
Cc: -mariakho...@chromium.org nednguyen@chromium.org
Thanks for the screenshot!

The flipkart story benchmark somehow makes requests to network that is not satisfied by wpr. I am guessing it could be because of service worker requests not being recorded correctly. +Ned can you tell me how do I find/fix such issues? I am not sure where to start.
Cc: u...@chromium.org
#22: ssid@ my advice is to just rerecod the story.

Instruction: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark/harnesses/system_health.md#should-i-add-new-system-health-stories-and-how


+Also please coordinate with Ulan since he is working on refreshing many of these stories
I tried to record the story again. It has the same issue. I would like to understand why the requests from service worker are failing. It maybe the case that the site is making different network requests than while recording to detect if it's online. Not sure I understand wpr enough to debug this.

Sign in to add a comment