After moving multiple files, to a different folder, a random file is selected for focus |
|||||||||
Issue descriptionSteps to reproduce: 1. Select 2+ files and move them to a different folder (w/o navigating away from the current folder). 2. After the files are successfully moved, focus is placed on a random file in the current folder. Feedback report: https://feedback.corp.google.com/product/208/neutron?lView=rd&lReport=55643081814 We may want to select the next file in the list similar to the existing behavior when deleting folder (reference crbug.com/501734 ).
,
Feb 24 2018
,
Feb 28 2018
,
Mar 1 2018
Just verified this is still happening on M66.
,
Nov 7
,
Nov 21
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa8a5d39f2170246768ddf63167b6379b5bf0f2f commit fa8a5d39f2170246768ddf63167b6379b5bf0f2f Author: Sam McNally <sammc@chromium.org> Date: Wed Nov 21 12:54:15 2018 Fix selection jumping around when removing multiple items in cr-list. Previously, when the selected item is removed, the selection is changed to the index after where the old lead index was. When multiple items are removed, the logical next item may move multiple positions. Avoid this by moving to the item that hasn't been removed from prior to the permutation - using its position after the permutation. Bug: 708299 Change-Id: I9393c9f00d5453ef3c3d5378758bb63ed29c43b7 Reviewed-on: https://chromium-review.googlesource.com/c/1345709 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610019} [modify] https://crrev.com/fa8a5d39f2170246768ddf63167b6379b5bf0f2f/chrome/test/data/webui/list_selection_model_test.html [modify] https://crrev.com/fa8a5d39f2170246768ddf63167b6379b5bf0f2f/ui/webui/resources/js/cr/ui/list_selection_model.js
,
Nov 21
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a76d6665c82539e6131a575250ebff0f24adaaa6 commit a76d6665c82539e6131a575250ebff0f24adaaa6 Author: Anders Ruud <andruud@chromium.org> Date: Wed Nov 21 15:38:06 2018 Revert "Fix selection jumping around when removing multiple items in cr-list." This reverts commit fa8a5d39f2170246768ddf63167b6379b5bf0f2f. Reason for revert: Regressed FileManagerUITest.CheckSelect, see https://crbug.com/907510 Original change's description: > Fix selection jumping around when removing multiple items in cr-list. > > Previously, when the selected item is removed, the selection is changed > to the index after where the old lead index was. When multiple items are > removed, the logical next item may move multiple positions. Avoid this > by moving to the item that hasn't been removed from prior to the > permutation - using its position after the permutation. > > Bug: 708299 > Change-Id: I9393c9f00d5453ef3c3d5378758bb63ed29c43b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1345709 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610019} TBR=calamity@chromium.org,sammc@chromium.org Change-Id: Ic44793da74f4fa26243962bf0fa1b0aa17cd8546 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 708299 Reviewed-on: https://chromium-review.googlesource.com/c/1346829 Reviewed-by: Anders Ruud <andruud@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#610070} [modify] https://crrev.com/a76d6665c82539e6131a575250ebff0f24adaaa6/chrome/test/data/webui/list_selection_model_test.html [modify] https://crrev.com/a76d6665c82539e6131a575250ebff0f24adaaa6/ui/webui/resources/js/cr/ui/list_selection_model.js
,
Nov 22
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7824734c4a2887a95806a8d809a6c175b0460588 commit 7824734c4a2887a95806a8d809a6c175b0460588 Author: Sam McNally <sammc@chromium.org> Date: Thu Nov 22 10:06:11 2018 Reland "Fix selection jumping around when removing multiple items in cr-list." This is a reland of fa8a5d39f2170246768ddf63167b6379b5bf0f2f Original change's description: > Fix selection jumping around when removing multiple items in cr-list. > > Previously, when the selected item is removed, the selection is changed > to the index after where the old lead index was. When multiple items are > removed, the logical next item may move multiple positions. Avoid this > by moving to the item that hasn't been removed from prior to the > permutation - using its position after the permutation. > > Bug: 708299 > Change-Id: I9393c9f00d5453ef3c3d5378758bb63ed29c43b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1345709 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610019} Bug: 708299 Tbr: calamity@chromium.org Change-Id: I4de9726b919f88a1efe98f036687de07b23715c2 Reviewed-on: https://chromium-review.googlesource.com/c/1347630 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610358} [modify] https://crrev.com/7824734c4a2887a95806a8d809a6c175b0460588/chrome/test/data/webui/list_selection_model_test.html [modify] https://crrev.com/7824734c4a2887a95806a8d809a6c175b0460588/ui/webui/resources/js/cr/ui/list_selection_model.js
,
Nov 22
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by weifangsun@chromium.org
, Apr 6 2017