New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 708293 link

Starred by 2 users
Status: Verified
Owner:
ayatane@chromium.org
Closed: Apr 2017
Cc:
akes...@chromium.org
█ pho...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
som



Sign in to add a comment

sysmon git commit_time has no data

Project Member Reported by davidri...@chromium.org, Apr 4 2017 
The sysmon/git/commit_time metric has no data, likely because it's declared as a string and is being filled with unix timestamp values.  Changing metric types is hard because we don't have access to delete.

Two things:
- modify commit_time to emit a string that is "YYYYMMDD_HHMM_abcdefgh" where abcdefgh is the first 8 characters of the git hash
- add a new commit_unit_time metric which has an integer value and is a unix epoch timestamp
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d523d967db58e35c6b76e4cbc333b2d8f2203725

commit d523d967db58e35c6b76e4cbc333b2d8f2203725
Author: Allen Li <ayatane@chromium.org>
Date: Fri Apr 07 23:06:59 2017

sysmon: Use new stream for commit time metric

The old stream was created as a string type, so we need to use a new
stream for a gauge type.

BUG= chromium:708293 
TEST=None

Change-Id: I6e9fcbff06594e3b0607b42cfc30be47bf8a384b
Reviewed-on: https://chromium-review.googlesource.com/468208
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/d523d967db58e35c6b76e4cbc333b2d8f2203725/scripts/sysmon/git_metrics.py
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/35db474a9394b542c89262c3c777294f03dd3f90

commit 35db474a9394b542c89262c3c777294f03dd3f90
Author: Allen Li <ayatane@chromium.org>
Date: Fri Apr 07 23:06:59 2017

sysmon: Remove unused import

BUG= chromium:708293 
TEST=None

Change-Id: I26db1d50cfb8efec4d80e2487157159be40cb45b
Reviewed-on: https://chromium-review.googlesource.com/468367
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Paul Hobbs <phobbs@google.com>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/35db474a9394b542c89262c3c777294f03dd3f90/scripts/sysmon/git_metrics.py
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d2333986a493c04c7316f5f9f4b450db27c9eb2c

commit d2333986a493c04c7316f5f9f4b450db27c9eb2c
Author: Allen Li <ayatane@chromium.org>
Date: Fri Apr 07 23:06:59 2017

sysmon: Add docstrings

BUG= chromium:708293 
TEST=None

Change-Id: I8eb9054e8ed337ada2cdab42848e87fd588d3ec9
Reviewed-on: https://chromium-review.googlesource.com/468368
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/d2333986a493c04c7316f5f9f4b450db27c9eb2c/scripts/sysmon/git_metrics.py
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a02d34a784022b8b8f3e9ddfc2931a185a719722

commit a02d34a784022b8b8f3e9ddfc2931a185a719722
Author: Allen Li <ayatane@chromium.org>
Date: Fri Apr 07 23:06:59 2017

sysmon: Fix lint

BUG= chromium:708293 
TEST=None

Change-Id: I584d5ae087c41efee5aedb2a05d200827862a3f5
Reviewed-on: https://chromium-review.googlesource.com/468386
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/a02d34a784022b8b8f3e9ddfc2931a185a719722/scripts/sysmon/git_metrics.py

Comment 5 by ayatane@chromium.org, Apr 10 2017

Status: Verified (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3a2e180b5a55972ddaafdb8b28dccb4453dd3df3

commit 3a2e180b5a55972ddaafdb8b28dccb4453dd3df3
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 12 23:16:40 2017

Fix sysmon unit tests

BUG= chromium:708293 
TEST=Run tests

Change-Id: I07cfc2be4a073b85f2f6ac13d81210a6356fa8a5
Reviewed-on: https://chromium-review.googlesource.com/473487
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/3a2e180b5a55972ddaafdb8b28dccb4453dd3df3/scripts/sysmon/git_metrics_unittest.py
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5fc64b320afe7585fb1a6ec5c92348b400f56c4f

commit 5fc64b320afe7585fb1a6ec5c92348b400f56c4f
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 12 23:16:40 2017

Uncomment chdir

I guess this was commented because the tempdir wasnt working

BUG= chromium:708293 
TEST=Run tests

Change-Id: Ie7e7d82f54c81d72a19def4dd0f9a64063f8000a
Reviewed-on: https://chromium-review.googlesource.com/473490
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/5fc64b320afe7585fb1a6ec5c92348b400f56c4f/scripts/sysmon/git_metrics_unittest.py
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a460c7c90dd293d66af39de4836d1ff8f279d060

commit a460c7c90dd293d66af39de4836d1ff8f279d060
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 12 23:16:40 2017

Inline _InitRepo()

Kind of pointless to have a function just to call another.

BUG= chromium:708293 
TEST=Run tests

Change-Id: Ie8d278f7247de05b4658ee055da371b0ddcf8fac
Reviewed-on: https://chromium-review.googlesource.com/473491
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/a460c7c90dd293d66af39de4836d1ff8f279d060/scripts/sysmon/git_metrics_unittest.py
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/512d704dd8e26eff13cd8a61b45eededa9909cec

commit 512d704dd8e26eff13cd8a61b45eededa9909cec
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 12 23:16:40 2017

Fix naming style

Originally sysmon came from chrome infra using the underscore code
base, so all sysmon code uses this style.  sysmon is also basically
independent from the rest of chromite, other than living in the same
repo.

Its not the best situation, but be consistent inside sysmon for now.

BUG= chromium:708293 
TEST=Run tests

Change-Id: Ibbc43a13dd9477376462d31f897b7f1ea4263d27
Reviewed-on: https://chromium-review.googlesource.com/473492
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/512d704dd8e26eff13cd8a61b45eededa9909cec/scripts/sysmon/git_metrics_unittest.py
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/73b14b08ac496a1fd538a0c30176fe9a6dc6a032

commit 73b14b08ac496a1fd538a0c30176fe9a6dc6a032
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 12 23:16:40 2017

Rename tests with fixtures

BUG= chromium:708293 
TEST=Run tests

Change-Id: I2f39997a61b56c8dfaaa63423ffa826598be9b04
Reviewed-on: https://chromium-review.googlesource.com/473493
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/73b14b08ac496a1fd538a0c30176fe9a6dc6a032/scripts/sysmon/git_metrics_unittest.py
►

Sign in to add a comment