New issue
Advanced search Search tips

Issue 708279 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 706589
issue 708287



Sign in to add a comment

Add the ability for the WindowManager to create windows corresponding to displays

Project Member Reported by sky@chromium.org, Apr 4 2017

Issue description

See 706589 for details on why.
 

Comment 1 by sky@chromium.org, Apr 4 2017

Blocking: 708287

Comment 2 by sky@chromium.org, Apr 5 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c53add46854c4bd7fa46a6f6515835f7292a2b8f

commit c53add46854c4bd7fa46a6f6515835f7292a2b8f
Author: sky <sky@chromium.org>
Date: Thu Apr 20 17:47:49 2017

mus: Changes SetDisplayRoot() to create actual display

It now takes enough information for mus to create the display. Further
we now assume mus has not created the display at the time
SetDisplayRoot() is called.

BUG= 708279 
TEST=covered by tests
R=kylechar@chromium.org, nasko@chromium.org

Review-Url: https://codereview.chromium.org/2829733002
Cr-Commit-Position: refs/heads/master@{#466057}

[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager_forwarding.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager_forwarding.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager_ozone_external.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager_ozone_external.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager_ozone_internal.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager_ozone_internal.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager_stub_internal.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/display/screen_manager_stub_internal.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/public/interfaces/window_manager_constants.mojom
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/service.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/service.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/display_manager.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/display_manager.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/test_utils.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/test_utils.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/window_manager_window_tree_factory.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/window_server_delegate.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/window_server_delegate.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/window_tree.cc
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/window_tree.h
[modify] https://crrev.com/c53add46854c4bd7fa46a6f6515835f7292a2b8f/services/ui/ws/window_tree_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86bb8825f73b55690c94f3fca973462082715ae0

commit 86bb8825f73b55690c94f3fca973462082715ae0
Author: sky <sky@chromium.org>
Date: Mon Apr 24 21:43:15 2017

Wires up WindowTreeClient::SetDisplayRoot()

Mush and mash will make use of this soon.

BUG= 708279 
TEST=covered by test
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2839743002
Cr-Commit-Position: refs/heads/master@{#466781}

[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/mus_types.h
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/window_tree_client_unittest.cc
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/window_tree_host_mus.h
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/window_tree_host_mus_init_params.cc
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/mus/window_tree_host_mus_init_params.h
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/test/mus/window_tree_client_private.cc
[modify] https://crrev.com/86bb8825f73b55690c94f3fca973462082715ae0/ui/aura/test/mus/window_tree_client_private.h

Comment 5 by sky@chromium.org, Apr 25 2017

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment