New issue
Advanced search Search tips

Issue 708275 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[USS] Add SyncMetadataStore interface

Project Member Reported by gangwu@chromium.org, Apr 4 2017

Issue description

Add UpdateSyncMetadata, ClearSyncMetadata, UpdateModelTypeState, ClearModelTypeState into MetadataTable interface.
Also create an unified MetadataChangeList for autofill, typed url...
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47d7aae76735286b86b85a3c582870677fce05d2

commit 47d7aae76735286b86b85a3c582870677fce05d2
Author: gangwu <gangwu@chromium.org>
Date: Sun Apr 23 19:34:52 2017

Add UpdateSyncMetadata, ClearSyncMetadata, UpdateModelTypeState,
ClearModelTypeState into SyncMetadataStore interface.
Let AutofillTable inherit SyncMetadataStore.
Also create a SyncMetadataStoreChangeList for autofill.
Will do this change for typed url in next CL.

BUG= 708275 

Review-Url: https://codereview.chromium.org/2794413002
Cr-Commit-Position: refs/heads/master@{#466568}

[modify] https://crrev.com/47d7aae76735286b86b85a3c582870677fce05d2/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/47d7aae76735286b86b85a3c582870677fce05d2/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
[delete] https://crrev.com/81c2c04d0c269a02e9dd86803de226f219f93615/components/autofill/core/browser/webdata/autofill_metadata_change_list.cc
[delete] https://crrev.com/81c2c04d0c269a02e9dd86803de226f219f93615/components/autofill/core/browser/webdata/autofill_metadata_change_list.h
[modify] https://crrev.com/47d7aae76735286b86b85a3c582870677fce05d2/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/47d7aae76735286b86b85a3c582870677fce05d2/components/sync/BUILD.gn
[add] https://crrev.com/47d7aae76735286b86b85a3c582870677fce05d2/components/sync/model/sync_metadata_store.h
[add] https://crrev.com/47d7aae76735286b86b85a3c582870677fce05d2/components/sync/model_impl/sync_metadata_store_change_list.cc
[add] https://crrev.com/47d7aae76735286b86b85a3c582870677fce05d2/components/sync/model_impl/sync_metadata_store_change_list.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e92abbd14ad37670120e1c38ecf2cf6ce1a7eecd

commit e92abbd14ad37670120e1c38ecf2cf6ce1a7eecd
Author: gangwu <gangwu@chromium.org>
Date: Wed Apr 26 01:18:49 2017

[USS] TypedURLSyncMetadataDatabase inherits SyncMetadataStore

BUG= 708275 

This is a follow up for CL https://codereview.chromium.org/2794413002/.
It allows typed urls to use common implementation of MetadataChangeList
(SyncMetadataStoreChangeList) instead of implementing its own.

Review-Url: https://codereview.chromium.org/2841653003
Cr-Commit-Position: refs/heads/master@{#467193}

[modify] https://crrev.com/e92abbd14ad37670120e1c38ecf2cf6ce1a7eecd/components/history/core/browser/typed_url_sync_metadata_database.cc
[modify] https://crrev.com/e92abbd14ad37670120e1c38ecf2cf6ce1a7eecd/components/history/core/browser/typed_url_sync_metadata_database.h
[modify] https://crrev.com/e92abbd14ad37670120e1c38ecf2cf6ce1a7eecd/components/history/core/browser/typed_url_sync_metadata_database_unittest.cc

Comment 3 by gangwu@chromium.org, Apr 28 2017

Summary: [USS] Add SyncMetadataStore interface (was: [USS] Add MetadataTable interface)
Labels: -Type-Bug Type-Feature
Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2017

Sign in to add a comment